mirror of
https://github.com/n8n-io/n8n.git
synced 2024-09-21 07:17:38 -07:00
4c4082503c
Followup to #7566 | Story: https://linear.app/n8n/issue/PAY-926 ### Manual workflow activation and deactivation In a multi-main scenario, if the user manually activates or deactivates a workflow, the process (whether leader or follower) that handles the PATCH request and updates its internal state should send a message into the command channel, so that all other main processes update their internal state accordingly: - Add to `ActiveWorkflows` if activating - Remove from `ActiveWorkflows` if deactivating - Remove and re-add to `ActiveWorkflows` if the update did not change activation status. After updating their internal state, if activating or deactivating, the recipient main processes should push a message to all connected frontends so that these can update their stores and so reflect the value in the UI. ### Workflow activation errors On failure to activate a workflow, the main instance should record the error in Redis - main instances should always pull activation errors from Redis in a multi-main scenario. ### Leadership change On leadership change... - The old leader should stop pruning and the new leader should start pruning. - The old leader should remove trigger- and poller-based workflows and the new leader should add them.
63 lines
2 KiB
TypeScript
63 lines
2 KiB
TypeScript
import { ActiveWorkflowRunner } from '@/ActiveWorkflowRunner';
|
|
import * as testDb from './shared/testDb';
|
|
import { WorkflowsService } from '@/workflows/workflows.services';
|
|
import { mockInstance } from '../shared/mocking';
|
|
import { Telemetry } from '@/telemetry';
|
|
import { createOwner } from './shared/db/users';
|
|
import { createWorkflow } from './shared/db/workflows';
|
|
|
|
mockInstance(Telemetry);
|
|
|
|
const activeWorkflowRunner = mockInstance(ActiveWorkflowRunner);
|
|
|
|
beforeAll(async () => {
|
|
await testDb.init();
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await testDb.truncate(['Workflow']);
|
|
jest.restoreAllMocks();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await testDb.terminate();
|
|
});
|
|
|
|
describe('update()', () => {
|
|
test('should remove and re-add to active workflows on `active: true` payload', async () => {
|
|
const owner = await createOwner();
|
|
const workflow = await createWorkflow({ active: true }, owner);
|
|
|
|
const removeSpy = jest.spyOn(activeWorkflowRunner, 'remove');
|
|
const addSpy = jest.spyOn(activeWorkflowRunner, 'add');
|
|
|
|
await WorkflowsService.update(owner, workflow, workflow.id);
|
|
|
|
expect(removeSpy).toHaveBeenCalledTimes(1);
|
|
const [removedWorkflowId] = removeSpy.mock.calls[0];
|
|
expect(removedWorkflowId).toBe(workflow.id);
|
|
|
|
expect(addSpy).toHaveBeenCalledTimes(1);
|
|
const [addedWorkflowId, activationMode] = addSpy.mock.calls[0];
|
|
expect(addedWorkflowId).toBe(workflow.id);
|
|
expect(activationMode).toBe('update');
|
|
});
|
|
|
|
test('should remove from active workflows on `active: false` payload', async () => {
|
|
const owner = await createOwner();
|
|
const workflow = await createWorkflow({ active: true }, owner);
|
|
|
|
const removeSpy = jest.spyOn(activeWorkflowRunner, 'remove');
|
|
const addSpy = jest.spyOn(activeWorkflowRunner, 'add');
|
|
|
|
workflow.active = false;
|
|
await WorkflowsService.update(owner, workflow, workflow.id);
|
|
|
|
expect(removeSpy).toHaveBeenCalledTimes(1);
|
|
const [removedWorkflowId] = removeSpy.mock.calls[0];
|
|
expect(removedWorkflowId).toBe(workflow.id);
|
|
|
|
expect(addSpy).not.toHaveBeenCalled();
|
|
});
|
|
});
|