mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-25 20:54:07 -08:00
5ffff1bb22
In the case of a filesystem failure to rename the binary files as part of the execution's cleanup process, the execution would fail to be saved and would never finish. This catch prevents it. ## Summary Whenever an execution is wrapping u to save the data, if it uses binary data n8n will try to find possibly misallocated files and place them in the right folder. If this process fails, the execution fails to finish. Given the execution has already finished at this point, and we cannot handle the binary data errors more gracefully, all we can do at this point is log the message as it's a filesystem issue. The rest of the execution saving process should remain as normal. ## Related tickets and issues https://linear.app/n8n/issue/HELP-430 ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com> |
||
|---|---|---|
| .. | ||
| collaboration | ||
| controllers | ||
| databases/utils | ||
| execution-lifecyle | ||
| ExternalSecrets | ||
| license | ||
| middleware | ||
| push | ||
| repositories | ||
| services | ||
| shared | ||
| utilities | ||
| ActiveExecutions.test.ts | ||
| CredentialsHelper.test.ts | ||
| CredentialTypes.test.ts | ||
| CurlConverterHelper.test.ts | ||
| Helpers.ts | ||
| InternalHooks.test.ts | ||
| License.test.ts | ||
| PermissionChecker.test.ts | ||
| PostHog.test.ts | ||
| SourceControl.test.ts | ||
| Telemetry.test.ts | ||
| TestWebhooks.test.ts | ||
| UserManagementMailer.test.ts | ||
| utils.test.ts | ||
| WebhookHelpers.test.ts | ||
| webhooks.test.ts | ||
| WorkflowCredentials.test.ts | ||
| WorkflowExecuteAdditionalData.test.ts | ||
| WorkflowHelpers.test.ts | ||
| workflowHistoryHelper.test.ts | ||
| WorkflowRunner.test.ts | ||