mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 09:04:07 -08:00
00a4b8b0c6
This extracts all core and editor changes from #7246 and #7137, so that we can get these changes merged first. ADO-1120 [DB Tests](https://github.com/n8n-io/n8n/actions/runs/6379749011) [E2E Tests](https://github.com/n8n-io/n8n/actions/runs/6379751480) [Workflow Tests](https://github.com/n8n-io/n8n/actions/runs/6379752828) --------- Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com> Co-authored-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
595 lines
17 KiB
TypeScript
595 lines
17 KiB
TypeScript
import type { FindOptionsWhere } from 'typeorm';
|
|
import { In } from 'typeorm';
|
|
import { Container } from 'typedi';
|
|
|
|
import type {
|
|
IDataObject,
|
|
IExecuteData,
|
|
INode,
|
|
INodeCredentialsDetails,
|
|
IRun,
|
|
IRunExecutionData,
|
|
ITaskData,
|
|
NodeApiError,
|
|
WorkflowExecuteMode,
|
|
WorkflowOperationError,
|
|
} from 'n8n-workflow';
|
|
import {
|
|
ErrorReporterProxy as ErrorReporter,
|
|
LoggerProxy as Logger,
|
|
NodeOperationError,
|
|
SubworkflowOperationError,
|
|
Workflow,
|
|
} from 'n8n-workflow';
|
|
import { v4 as uuid } from 'uuid';
|
|
import * as Db from '@/Db';
|
|
import type {
|
|
ExecutionPayload,
|
|
IWorkflowErrorData,
|
|
IWorkflowExecutionDataProcess,
|
|
} from '@/Interfaces';
|
|
import { NodeTypes } from '@/NodeTypes';
|
|
// eslint-disable-next-line import/no-cycle
|
|
import { WorkflowRunner } from '@/WorkflowRunner';
|
|
import config from '@/config';
|
|
import type { WorkflowEntity } from '@db/entities/WorkflowEntity';
|
|
import type { User } from '@db/entities/User';
|
|
import omit from 'lodash/omit';
|
|
// eslint-disable-next-line import/no-cycle
|
|
import { PermissionChecker } from './UserManagement/PermissionChecker';
|
|
import { UserService } from './services/user.service';
|
|
import type { SharedWorkflow } from '@db/entities/SharedWorkflow';
|
|
import type { RoleNames } from '@db/entities/Role';
|
|
import { RoleService } from './services/role.service';
|
|
import { ExecutionRepository, RoleRepository } from './databases/repositories';
|
|
import { VariablesService } from './environments/variables/variables.service';
|
|
import type { CredentialsEntity } from './databases/entities/CredentialsEntity';
|
|
|
|
const ERROR_TRIGGER_TYPE = config.getEnv('nodes.errorTriggerType');
|
|
|
|
export function generateFailedExecutionFromError(
|
|
mode: WorkflowExecuteMode,
|
|
error: NodeApiError | NodeOperationError | WorkflowOperationError,
|
|
node: INode,
|
|
): IRun {
|
|
return {
|
|
data: {
|
|
startData: {
|
|
destinationNode: node.name,
|
|
runNodeFilter: [node.name],
|
|
},
|
|
resultData: {
|
|
error,
|
|
runData: {
|
|
[node.name]: [
|
|
{
|
|
startTime: 0,
|
|
executionTime: 0,
|
|
error,
|
|
source: [],
|
|
},
|
|
],
|
|
},
|
|
lastNodeExecuted: node.name,
|
|
},
|
|
executionData: {
|
|
contextData: {},
|
|
metadata: {},
|
|
nodeExecutionStack: [
|
|
{
|
|
node,
|
|
data: {},
|
|
source: null,
|
|
},
|
|
],
|
|
waitingExecution: {},
|
|
waitingExecutionSource: {},
|
|
},
|
|
},
|
|
finished: false,
|
|
mode,
|
|
startedAt: new Date(),
|
|
stoppedAt: new Date(),
|
|
status: 'failed',
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Returns the data of the last executed node
|
|
*
|
|
*/
|
|
export function getDataLastExecutedNodeData(inputData: IRun): ITaskData | undefined {
|
|
const { runData, pinData = {} } = inputData.data.resultData;
|
|
const { lastNodeExecuted } = inputData.data.resultData;
|
|
|
|
if (lastNodeExecuted === undefined) {
|
|
return undefined;
|
|
}
|
|
|
|
if (runData[lastNodeExecuted] === undefined) {
|
|
return undefined;
|
|
}
|
|
|
|
const lastNodeRunData = runData[lastNodeExecuted][runData[lastNodeExecuted].length - 1];
|
|
|
|
let lastNodePinData = pinData[lastNodeExecuted];
|
|
|
|
if (lastNodePinData && inputData.mode === 'manual') {
|
|
if (!Array.isArray(lastNodePinData)) lastNodePinData = [lastNodePinData];
|
|
|
|
const itemsPerRun = lastNodePinData.map((item, index) => {
|
|
return { json: item, pairedItem: { item: index } };
|
|
});
|
|
|
|
return {
|
|
startTime: 0,
|
|
executionTime: 0,
|
|
data: { main: [itemsPerRun] },
|
|
source: lastNodeRunData.source,
|
|
};
|
|
}
|
|
|
|
return lastNodeRunData;
|
|
}
|
|
|
|
/**
|
|
* Executes the error workflow
|
|
*
|
|
* @param {string} workflowId The id of the error workflow
|
|
* @param {IWorkflowErrorData} workflowErrorData The error data
|
|
*/
|
|
export async function executeErrorWorkflow(
|
|
workflowId: string,
|
|
workflowErrorData: IWorkflowErrorData,
|
|
runningUser: User,
|
|
): Promise<void> {
|
|
// Wrap everything in try/catch to make sure that no errors bubble up and all get caught here
|
|
try {
|
|
const workflowData = await Db.collections.Workflow.findOneBy({ id: workflowId });
|
|
|
|
if (workflowData === null) {
|
|
// The error workflow could not be found
|
|
Logger.error(
|
|
`Calling Error Workflow for "${workflowErrorData.workflow.id}". Could not find error workflow "${workflowId}"`,
|
|
{ workflowId },
|
|
);
|
|
return;
|
|
}
|
|
|
|
const executionMode = 'error';
|
|
const nodeTypes = Container.get(NodeTypes);
|
|
|
|
const workflowInstance = new Workflow({
|
|
id: workflowId,
|
|
name: workflowData.name,
|
|
nodeTypes,
|
|
nodes: workflowData.nodes,
|
|
connections: workflowData.connections,
|
|
active: workflowData.active,
|
|
staticData: workflowData.staticData,
|
|
settings: workflowData.settings,
|
|
});
|
|
|
|
try {
|
|
await PermissionChecker.checkSubworkflowExecutePolicy(
|
|
workflowInstance,
|
|
runningUser.id,
|
|
workflowErrorData.workflow.id,
|
|
);
|
|
} catch (error) {
|
|
const initialNode = workflowInstance.getStartNode();
|
|
if (initialNode) {
|
|
const errorWorkflowPermissionError = new SubworkflowOperationError(
|
|
`Another workflow: (ID ${workflowErrorData.workflow.id}) tried to invoke this workflow to handle errors.`,
|
|
"Unfortunately current permissions do not allow this. Please check that this workflow's settings allow it to be called by others",
|
|
);
|
|
|
|
// Create a fake execution and save it to DB.
|
|
const fakeExecution = generateFailedExecutionFromError(
|
|
'error',
|
|
errorWorkflowPermissionError,
|
|
initialNode,
|
|
);
|
|
|
|
const fullExecutionData: ExecutionPayload = {
|
|
data: fakeExecution.data,
|
|
mode: fakeExecution.mode,
|
|
finished: false,
|
|
startedAt: new Date(),
|
|
stoppedAt: new Date(),
|
|
workflowData,
|
|
waitTill: null,
|
|
status: fakeExecution.status,
|
|
workflowId: workflowData.id,
|
|
};
|
|
|
|
await Container.get(ExecutionRepository).createNewExecution(fullExecutionData);
|
|
}
|
|
Logger.info('Error workflow execution blocked due to subworkflow settings', {
|
|
erroredWorkflowId: workflowErrorData.workflow.id,
|
|
errorWorkflowId: workflowId,
|
|
});
|
|
return;
|
|
}
|
|
|
|
let node: INode;
|
|
let workflowStartNode: INode | undefined;
|
|
for (const nodeName of Object.keys(workflowInstance.nodes)) {
|
|
node = workflowInstance.nodes[nodeName];
|
|
if (node.type === ERROR_TRIGGER_TYPE) {
|
|
workflowStartNode = node;
|
|
}
|
|
}
|
|
|
|
if (workflowStartNode === undefined) {
|
|
Logger.error(
|
|
`Calling Error Workflow for "${workflowErrorData.workflow.id}". Could not find "${ERROR_TRIGGER_TYPE}" in workflow "${workflowId}"`,
|
|
);
|
|
return;
|
|
}
|
|
|
|
// Can execute without webhook so go on
|
|
|
|
// Initialize the data of the webhook node
|
|
const nodeExecutionStack: IExecuteData[] = [];
|
|
nodeExecutionStack.push({
|
|
node: workflowStartNode,
|
|
data: {
|
|
main: [
|
|
[
|
|
{
|
|
json: workflowErrorData,
|
|
},
|
|
],
|
|
],
|
|
},
|
|
source: null,
|
|
});
|
|
|
|
const runExecutionData: IRunExecutionData = {
|
|
startData: {},
|
|
resultData: {
|
|
runData: {},
|
|
},
|
|
executionData: {
|
|
contextData: {},
|
|
metadata: {},
|
|
nodeExecutionStack,
|
|
waitingExecution: {},
|
|
waitingExecutionSource: {},
|
|
},
|
|
};
|
|
|
|
const runData: IWorkflowExecutionDataProcess = {
|
|
executionMode,
|
|
executionData: runExecutionData,
|
|
workflowData,
|
|
userId: runningUser.id,
|
|
};
|
|
|
|
const workflowRunner = new WorkflowRunner();
|
|
await workflowRunner.run(runData);
|
|
} catch (error) {
|
|
ErrorReporter.error(error);
|
|
Logger.error(
|
|
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
|
|
`Calling Error Workflow for "${workflowErrorData.workflow.id}": "${error.message}"`,
|
|
{ workflowId: workflowErrorData.workflow.id },
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Returns the static data of workflow
|
|
*/
|
|
export async function getStaticDataById(workflowId: string) {
|
|
const workflowData = await Db.collections.Workflow.findOne({
|
|
select: ['staticData'],
|
|
where: { id: workflowId },
|
|
});
|
|
return workflowData?.staticData ?? {};
|
|
}
|
|
|
|
/**
|
|
* Set node ids if not already set
|
|
*/
|
|
export function addNodeIds(workflow: WorkflowEntity) {
|
|
const { nodes } = workflow;
|
|
if (!nodes) return;
|
|
|
|
nodes.forEach((node) => {
|
|
if (!node.id) {
|
|
node.id = uuid();
|
|
}
|
|
});
|
|
}
|
|
|
|
// Checking if credentials of old format are in use and run a DB check if they might exist uniquely
|
|
export async function replaceInvalidCredentials(workflow: WorkflowEntity): Promise<WorkflowEntity> {
|
|
const { nodes } = workflow;
|
|
if (!nodes) return workflow;
|
|
|
|
// caching
|
|
const credentialsByName: Record<string, Record<string, INodeCredentialsDetails>> = {};
|
|
const credentialsById: Record<string, Record<string, INodeCredentialsDetails>> = {};
|
|
|
|
// for loop to run DB fetches sequential and use cache to keep pressure off DB
|
|
// trade-off: longer response time for less DB queries
|
|
|
|
for (const node of nodes) {
|
|
if (!node.credentials || node.disabled) {
|
|
continue;
|
|
}
|
|
// extract credentials types
|
|
const allNodeCredentials = Object.entries(node.credentials);
|
|
for (const [nodeCredentialType, nodeCredentials] of allNodeCredentials) {
|
|
// Check if Node applies old credentials style
|
|
if (typeof nodeCredentials === 'string' || nodeCredentials.id === null) {
|
|
const name = typeof nodeCredentials === 'string' ? nodeCredentials : nodeCredentials.name;
|
|
// init cache for type
|
|
if (!credentialsByName[nodeCredentialType]) {
|
|
credentialsByName[nodeCredentialType] = {};
|
|
}
|
|
if (credentialsByName[nodeCredentialType][name] === undefined) {
|
|
const credentials = await Db.collections.Credentials.findBy({
|
|
name,
|
|
type: nodeCredentialType,
|
|
});
|
|
// if credential name-type combination is unique, use it
|
|
if (credentials?.length === 1) {
|
|
credentialsByName[nodeCredentialType][name] = {
|
|
id: credentials[0].id,
|
|
name: credentials[0].name,
|
|
};
|
|
node.credentials[nodeCredentialType] = credentialsByName[nodeCredentialType][name];
|
|
continue;
|
|
}
|
|
|
|
// nothing found - add invalid credentials to cache to prevent further DB checks
|
|
credentialsByName[nodeCredentialType][name] = {
|
|
id: null,
|
|
name,
|
|
};
|
|
} else {
|
|
// get credentials from cache
|
|
node.credentials[nodeCredentialType] = credentialsByName[nodeCredentialType][name];
|
|
}
|
|
continue;
|
|
}
|
|
|
|
// Node has credentials with an ID
|
|
|
|
// init cache for type
|
|
if (!credentialsById[nodeCredentialType]) {
|
|
credentialsById[nodeCredentialType] = {};
|
|
}
|
|
|
|
// check if credentials for ID-type are not yet cached
|
|
if (credentialsById[nodeCredentialType][nodeCredentials.id] === undefined) {
|
|
// check first if ID-type combination exists
|
|
const credentials = await Db.collections.Credentials.findOneBy({
|
|
id: nodeCredentials.id,
|
|
type: nodeCredentialType,
|
|
});
|
|
if (credentials) {
|
|
credentialsById[nodeCredentialType][nodeCredentials.id] = {
|
|
id: credentials.id,
|
|
name: credentials.name,
|
|
};
|
|
node.credentials[nodeCredentialType] =
|
|
credentialsById[nodeCredentialType][nodeCredentials.id];
|
|
continue;
|
|
}
|
|
// no credentials found for ID, check if some exist for name
|
|
const credsByName = await Db.collections.Credentials.findBy({
|
|
name: nodeCredentials.name,
|
|
type: nodeCredentialType,
|
|
});
|
|
// if credential name-type combination is unique, take it
|
|
if (credsByName?.length === 1) {
|
|
// add found credential to cache
|
|
credentialsById[nodeCredentialType][credsByName[0].id] = {
|
|
id: credsByName[0].id,
|
|
name: credsByName[0].name,
|
|
};
|
|
node.credentials[nodeCredentialType] =
|
|
credentialsById[nodeCredentialType][credsByName[0].id];
|
|
continue;
|
|
}
|
|
|
|
// nothing found - add invalid credentials to cache to prevent further DB checks
|
|
credentialsById[nodeCredentialType][nodeCredentials.id] = nodeCredentials;
|
|
continue;
|
|
}
|
|
|
|
// get credentials from cache
|
|
node.credentials[nodeCredentialType] =
|
|
credentialsById[nodeCredentialType][nodeCredentials.id];
|
|
}
|
|
}
|
|
/* eslint-enable no-await-in-loop */
|
|
return workflow;
|
|
}
|
|
|
|
/**
|
|
* Get the IDs of the workflows that have been shared with the user.
|
|
* Returns all IDs if user is global owner (see `whereClause`)
|
|
*/
|
|
export async function getSharedWorkflowIds(user: User, roles?: RoleNames[]): Promise<string[]> {
|
|
const where: FindOptionsWhere<SharedWorkflow> = {};
|
|
if (user.globalRole?.name !== 'owner') {
|
|
where.userId = user.id;
|
|
}
|
|
if (roles?.length) {
|
|
const roleIds = await Container.get(RoleRepository)
|
|
.find({
|
|
select: ['id'],
|
|
where: { name: In(roles), scope: 'workflow' },
|
|
})
|
|
.then((role) => role.map(({ id }) => id));
|
|
|
|
where.roleId = In(roleIds);
|
|
}
|
|
const sharedWorkflows = await Db.collections.SharedWorkflow.find({
|
|
where,
|
|
select: ['workflowId'],
|
|
});
|
|
return sharedWorkflows.map(({ workflowId }) => workflowId);
|
|
}
|
|
/**
|
|
* Check if user owns more than 15 workflows or more than 2 workflows with at least 2 nodes.
|
|
* If user does, set flag in its settings.
|
|
*/
|
|
export async function isBelowOnboardingThreshold(user: User): Promise<boolean> {
|
|
let belowThreshold = true;
|
|
const skippedTypes = ['n8n-nodes-base.start', 'n8n-nodes-base.stickyNote'];
|
|
|
|
const workflowOwnerRole = await Container.get(RoleService).findWorkflowOwnerRole();
|
|
const ownedWorkflowsIds = await Db.collections.SharedWorkflow.find({
|
|
where: {
|
|
userId: user.id,
|
|
roleId: workflowOwnerRole?.id,
|
|
},
|
|
select: ['workflowId'],
|
|
}).then((ownedWorkflows) => ownedWorkflows.map(({ workflowId }) => workflowId));
|
|
|
|
if (ownedWorkflowsIds.length > 15) {
|
|
belowThreshold = false;
|
|
} else {
|
|
// just fetch workflows' nodes to keep memory footprint low
|
|
const workflows = await Db.collections.Workflow.find({
|
|
where: { id: In(ownedWorkflowsIds) },
|
|
select: ['nodes'],
|
|
});
|
|
|
|
// valid workflow: 2+ nodes without start node
|
|
const validWorkflowCount = workflows.reduce((counter, workflow) => {
|
|
if (counter <= 2 && workflow.nodes.length > 2) {
|
|
const nodes = workflow.nodes.filter((node) => !skippedTypes.includes(node.type));
|
|
if (nodes.length >= 2) {
|
|
return counter + 1;
|
|
}
|
|
}
|
|
return counter;
|
|
}, 0);
|
|
|
|
// more than 2 valid workflows required
|
|
belowThreshold = validWorkflowCount <= 2;
|
|
}
|
|
|
|
// user is above threshold --> set flag in settings
|
|
if (!belowThreshold) {
|
|
void Container.get(UserService).updateSettings(user.id, { isOnboarded: true });
|
|
}
|
|
|
|
return belowThreshold;
|
|
}
|
|
|
|
/** Get all nodes in a workflow where the node credential is not accessible to the user. */
|
|
export function getNodesWithInaccessibleCreds(workflow: WorkflowEntity, userCredIds: string[]) {
|
|
if (!workflow.nodes) {
|
|
return [];
|
|
}
|
|
return workflow.nodes.filter((node) => {
|
|
if (!node.credentials) return false;
|
|
|
|
const allUsedCredentials = Object.values(node.credentials);
|
|
|
|
const allUsedCredentialIds = allUsedCredentials.map((nodeCred) => nodeCred.id?.toString());
|
|
return allUsedCredentialIds.some(
|
|
(nodeCredId) => nodeCredId && !userCredIds.includes(nodeCredId),
|
|
);
|
|
});
|
|
}
|
|
|
|
export function validateWorkflowCredentialUsage(
|
|
newWorkflowVersion: WorkflowEntity,
|
|
previousWorkflowVersion: WorkflowEntity,
|
|
credentialsUserHasAccessTo: CredentialsEntity[],
|
|
) {
|
|
/**
|
|
* We only need to check nodes that use credentials the current user cannot access,
|
|
* since these can be 2 possibilities:
|
|
* - Same ID already exist: it's a read only node and therefore cannot be changed
|
|
* - It's a new node which indicates tampering and therefore must fail saving
|
|
*/
|
|
|
|
const allowedCredentialIds = credentialsUserHasAccessTo.map((cred) => cred.id);
|
|
|
|
const nodesWithCredentialsUserDoesNotHaveAccessTo = getNodesWithInaccessibleCreds(
|
|
newWorkflowVersion,
|
|
allowedCredentialIds,
|
|
);
|
|
|
|
// If there are no nodes with credentials the user does not have access to we can skip the rest
|
|
if (nodesWithCredentialsUserDoesNotHaveAccessTo.length === 0) {
|
|
return newWorkflowVersion;
|
|
}
|
|
|
|
const previouslyExistingNodeIds = previousWorkflowVersion.nodes.map((node) => node.id);
|
|
|
|
// If it's a new node we can't allow it to be saved
|
|
// since it uses creds the node doesn't have access
|
|
const isTamperingAttempt = (inaccessibleCredNodeId: string) =>
|
|
!previouslyExistingNodeIds.includes(inaccessibleCredNodeId);
|
|
|
|
nodesWithCredentialsUserDoesNotHaveAccessTo.forEach((node) => {
|
|
if (isTamperingAttempt(node.id)) {
|
|
Logger.verbose('Blocked workflow update due to tampering attempt', {
|
|
nodeType: node.type,
|
|
nodeName: node.name,
|
|
nodeId: node.id,
|
|
nodeCredentials: node.credentials,
|
|
});
|
|
// Node is new, so this is probably a tampering attempt. Throw an error
|
|
throw new NodeOperationError(
|
|
node,
|
|
`You don't have access to the credentials in the '${node.name}' node. Ask the owner to share them with you.`,
|
|
);
|
|
}
|
|
// Replace the node with the previous version of the node
|
|
// Since it cannot be modified (read only node)
|
|
const nodeIdx = newWorkflowVersion.nodes.findIndex(
|
|
(newWorkflowNode) => newWorkflowNode.id === node.id,
|
|
);
|
|
|
|
Logger.debug('Replacing node with previous version when saving updated workflow', {
|
|
nodeType: node.type,
|
|
nodeName: node.name,
|
|
nodeId: node.id,
|
|
});
|
|
const previousNodeVersion = previousWorkflowVersion.nodes.find(
|
|
(previousNode) => previousNode.id === node.id,
|
|
);
|
|
// Allow changing only name, position and disabled status for read-only nodes
|
|
Object.assign(
|
|
newWorkflowVersion.nodes[nodeIdx],
|
|
omit(previousNodeVersion, ['name', 'position', 'disabled']),
|
|
);
|
|
});
|
|
|
|
return newWorkflowVersion;
|
|
}
|
|
|
|
export function getExecutionStartNode(data: IWorkflowExecutionDataProcess, workflow: Workflow) {
|
|
let startNode;
|
|
if (
|
|
data.startNodes?.length === 1 &&
|
|
Object.keys(data.pinData ?? {}).includes(data.startNodes[0])
|
|
) {
|
|
startNode = workflow.getNode(data.startNodes[0]) ?? undefined;
|
|
}
|
|
|
|
return startNode;
|
|
}
|
|
|
|
export async function getVariables(): Promise<IDataObject> {
|
|
const variables = await Container.get(VariablesService).getAllCached();
|
|
return Object.freeze(
|
|
variables.reduce((prev, curr) => {
|
|
prev[curr.key] = curr.value;
|
|
return prev;
|
|
}, {} as IDataObject),
|
|
);
|
|
}
|