mirror of
https://github.com/n8n-io/n8n.git
synced 2025-01-10 12:27:31 -08:00
cd08c8e4c6
Based on #7065 | Story: https://linear.app/n8n/issue/PAY-771 n8n on filesystem mode marks binary data to delete on manual execution deletion, on unsaved execution completion, and on every execution pruning cycle. We later prune binary data in a separate cycle via these marker files, based on the configured TTL. In the context of introducing an S3 client to manage binary data, the filesystem mode's mark-and-prune setup is too tightly coupled to the general binary data management client interface. This PR... - Ensures the deletion of an execution causes the deletion of any binary data associated to it. This does away with the need for binary data TTL and simplifies the filesystem mode's mark-and-prune setup. - Refactors all execution deletions (including pruning) to cause soft deletions, hard-deletes soft-deleted executions based on the existing pruning config, and adjusts execution endpoints to filter out soft-deleted executions. This reduces DB load, and keeps binary data around long enough for users to access it when building workflows with unsaved executions. - Moves all execution pruning work from an execution lifecycle hook to `execution.repository.ts`. This keeps related logic in a single place. - Removes all marking logic from the binary data manager. This simplifies the interface that the S3 client will meet. - Adds basic sanity-check tests to pruning logic and execution deletion. Out of scope: - Improving existing pruning logic. - Improving existing execution repository logic. - Adjusting dir structure for filesystem mode. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> |
||
|---|---|---|
| .. | ||
| controllers | ||
| ExternalSecrets | ||
| middleware | ||
| repositories | ||
| services | ||
| shared | ||
| ActiveExecutions.test.ts | ||
| ActiveWorkflowRunner.test.ts | ||
| CredentialsHelper.test.ts | ||
| CredentialTypes.test.ts | ||
| CurlConverterHelper.test.ts | ||
| Helpers.ts | ||
| License.test.ts | ||
| PermissionChecker.test.ts | ||
| PostHog.test.ts | ||
| SourceControl.test.ts | ||
| Telemetry.test.ts | ||
| utils.test.ts | ||
| webhooks.test.ts | ||
| WorkflowCredentials.test.ts | ||
| WorkflowExecuteAdditionalData.test.ts | ||
| WorkflowHelpers.test.ts | ||