mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 14:44:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity
n8n/packages/editor-ui
History
Milorad FIlipović 711fa2b925
fix(editor): Fix operation change failing in certain conditions (#8114) 
## Summary
This PR handles the case when there are multiple parameters with the
same name but different `options` and `displayOptions`. In this case, if
one of such fields is set, changing the dependent parameter value so the
other should be shown causes an error in case their options are not
compatible (this
[check](7806a65229/packages/workflow/src/NodeHelpers.ts (L786))).

#### Example:
LDAP node has two `options` properties with the same name:
1. `attributes` with predefined options (`add`, `replace`, `delete`).
Shown when **Update** operation is selected
2. `attributes` with a collection of `attribute` objects. Shows for the
**Create** operation

Setting one of these parameter values and switching operation so the
other is shown breaks the app.
This PR checks if there is a value saved for such parameter and removes
it before calling `getNodeParameters` in `valueChanged` handler.

## Related tickets and issues
Fixes ADO-1589

## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [x] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again.
   > A feature is not complete without tests.
2023-12-22 08:41:20 +01:00
..
public refactor(editor): Color palette updates, introduce dark mode (#6980) 2023-11-01 13:33:36 +01:00
src fix(editor): Fix operation change failing in certain conditions (#8114) 2023-12-22 08:41:20 +01:00
tests/e2e feat: migrate editor-ui to Vite.js and various DX improvements (N8N-2277) (#4061) 2022-09-23 17:14:28 +03:00
.browserslistrc Initial commit to release 2019-06-23 12:35:23 +02:00
.eslintrc.js perf: Make frontend linting faster (no-changelog) (#7717) 2023-11-22 15:01:22 +01:00
.gitignore Initial commit to release 2019-06-23 12:35:23 +02:00
.npmignore fix: delete unused dependencies (#4231) 2022-09-29 17:31:33 +02:00
index.html fix(editor): Revert Fix telemetry initialization (no-changelog) (#6968) 2023-08-18 13:06:13 +02:00
index.js ✨ Serve editor-ui correctly also when installed as package 2019-08-19 20:41:10 +02:00
LICENSE.md docs: scope Sustainable Use License to contents of the main branch (#4450) 2022-10-26 16:50:33 +02:00
LICENSE_EE.md docs(license): Introduce n8n Enterprise License (#3945) 2022-08-29 22:08:42 +02:00
package.json 🚀 Release 1.22.0 (#8115) 2023-12-21 13:51:24 +01:00
postcss.config.js Initial commit to release 2019-06-23 12:35:23 +02:00
README.md docs: Replace http://faircode.io to https://faircode.io in .md files (#7908) 2023-12-12 15:23:22 +00:00
tsconfig.json build: Upgrade to Vite 5 (#7784) 2023-11-23 11:55:02 +01:00
vite.config.mts build: Fix vite config (switch to module type) (#7818) 2023-11-27 10:56:57 +01:00

README.md

n8n.io - Workflow Automation

n8n-editor-ui

The UI to create and update n8n workflows

npm install n8n -g

Project setup

pnpm install

Compiles and hot-reloads for development

pnpm serve

Compiles and minifies for production

pnpm build

Run your tests

pnpm test

Lints and fixes files

pnpm lint

Run your end-to-end tests

pnpm test:e2e

Run your unit tests

pnpm test:unit

Customize configuration

See Configuration Reference.

License

n8n is fair-code distributed under the Sustainable Use License.

Proprietary licenses are available for enterprise customers. Get in touch

Additional information about the license can be found in the docs.