mirror of
https://github.com/n8n-io/n8n.git
synced 2024-09-20 06:47:32 -07:00
766501723b
* WIP: Nodeview * Replace types * Finish N8nPlus endpoint type * Working on connector * Apply prettier * Fixed prettier issues * Debugging rendering * Fixed connectorrs position recalc * Fix snapping and output labels, WIP dragging * Fix N8nPlus endpoint rendering issues * Cleanup * Fix undo/redo and canvas add button position, cleanup * Cleanup * Revert accidental CLI changes * Fix pnpm-lock * Address bugs that came up during review * Reset CLI package from master * Various fixes * Fix run items label toggling * Linter fixes * Fix stalk size for larger run items label * Remove comment * Correctly reset workspace after renaming the node * Fix canvas e2e tests * Fix undo/redo tests * Fix stalk positioning and triggering of endpoint overlays * Repaint connections on pin removal * Limit repaintings * Unbind jsPlumb events on deactivation * Fix jsPlumb managment of Sticky and minor memort managment improvments * Address rest of PR points * Lint fix * Copy patches folder to docker * Fix e2e tests * set allowNonAppliedPatches to allow build * fix(editor): Handling router errors when navigation is canceled by user (#5271) * 🔨 Handling router errors in main sidebar, removing unused code * 🔨 Handling router errors in modals * ci(core): Fix docker nightly/custom image build (no-changelog) (#5284) * ci(core): Copy patches dir to Docker (no-changelog) * Update patch * Update package-lock * reapply the patch * skip patchedDependencies after the frontend is built --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> * Fix connector hover state on success * Remove allowNonAppliedPatches from package.json --------- Co-authored-by: Milorad FIlipović <milorad@n8n.io> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
306 lines
13 KiB
TypeScript
306 lines
13 KiB
TypeScript
import { CODE_NODE_NAME, SET_NODE_NAME } from './../constants';
|
|
import { SCHEDULE_TRIGGER_NODE_NAME } from '../constants';
|
|
import { WorkflowPage as WorkflowPageClass } from '../pages/workflow';
|
|
import { NDV } from '../pages/ndv';
|
|
|
|
// Suite-specific constants
|
|
const CODE_NODE_NEW_NAME = 'Something else';
|
|
|
|
const WorkflowPage = new WorkflowPageClass();
|
|
const ndv = new NDV();
|
|
|
|
describe('Undo/Redo', () => {
|
|
beforeEach(() => {
|
|
cy.resetAll();
|
|
cy.skipSetup();
|
|
WorkflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
});
|
|
|
|
it('should undo/redo adding nodes', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 0);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 1);
|
|
});
|
|
|
|
it('should undo/redo adding connected nodes', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 1);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
});
|
|
|
|
it('should undo/redo adding node in the middle', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(SET_NODE_NAME);
|
|
WorkflowPage.getters.nodeConnections().realHover();
|
|
cy.get('.connection-actions .add').filter(':visible').click();
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME, false);
|
|
WorkflowPage.actions.zoomToFit();
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 3);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 2);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 4);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 3);
|
|
});
|
|
|
|
it('should undo/redo deleting node using delete button', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters
|
|
.canvasNodeByName(CODE_NODE_NAME)
|
|
.find('[data-test-id=delete-node-button]')
|
|
.click({ force: true });
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 1);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 1);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
});
|
|
|
|
it('should undo/redo deleting node using keyboard shortcut', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters.canvasNodeByName(CODE_NODE_NAME).click();
|
|
cy.get('body').type('{backspace}');
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 1);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 1);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
});
|
|
|
|
it('should undo/redo deleting node between two connected nodes', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(SET_NODE_NAME);
|
|
WorkflowPage.getters.canvasNodeByName(CODE_NODE_NAME).click();
|
|
WorkflowPage.actions.zoomToFit();
|
|
cy.get('body').type('{backspace}');
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 3);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 2);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
});
|
|
|
|
it('should undo/redo deleting whole workflow', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
cy.get('body').type('{esc}');
|
|
cy.get('body').type('{esc}');
|
|
WorkflowPage.actions.selectAll();
|
|
cy.get('body').type('{backspace}');
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 0);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 0);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
});
|
|
|
|
it('should undo/redo moving nodes', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
cy.drag('[data-test-id="canvas-node"].jtk-drag-selected', 50, 150);
|
|
WorkflowPage.getters
|
|
.canvasNodes()
|
|
.last()
|
|
.should('have.attr', 'style', 'left: 740px; top: 360px;');
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters
|
|
.canvasNodes()
|
|
.last()
|
|
.should('have.attr', 'style', 'left: 640px; top: 260px;');
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters
|
|
.canvasNodes()
|
|
.last()
|
|
.should('have.attr', 'style', 'left: 740px; top: 360px;');
|
|
});
|
|
|
|
it('should undo/redo deleting a connection by pressing delete button', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters.nodeConnections().realHover();
|
|
cy.get('.connection-actions .delete').filter(':visible').should('be.visible').click();
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
});
|
|
|
|
it('should undo/redo deleting a connection by moving it away', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
cy.drag('.rect-input-endpoint.jtk-endpoint-connected', 0, -100);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 0);
|
|
});
|
|
|
|
it('should undo/redo disabling a node using disable button', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters
|
|
.canvasNodes()
|
|
.last()
|
|
.find('[data-test-id="disable-node-button"]')
|
|
.click({ force: true });
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 1);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 0);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 1);
|
|
});
|
|
|
|
it('should undo/redo disabling a node using keyboard shortcut', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters.canvasNodes().last().click();
|
|
WorkflowPage.actions.hitDisableNodeShortcut();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 1);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 0);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 1);
|
|
});
|
|
|
|
it('should undo/redo disabling multiple nodes', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
cy.get('body').type('{esc}');
|
|
cy.get('body').type('{esc}');
|
|
WorkflowPage.actions.selectAll();
|
|
WorkflowPage.actions.hitDisableNodeShortcut();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 2);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 0);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 2);
|
|
});
|
|
|
|
it('should undo/redo renaming node using NDV', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').type('{enter}');
|
|
ndv.actions.rename(CODE_NODE_NEW_NAME);
|
|
cy.get('body').type('{esc}');
|
|
WorkflowPage.actions.hitUndo();
|
|
cy.get('body').type('{esc}');
|
|
WorkflowPage.getters.canvasNodeByName(CODE_NODE_NAME).should('exist');
|
|
WorkflowPage.actions.hitRedo();
|
|
cy.get('body').type('{esc}');
|
|
WorkflowPage.getters.canvasNodeByName(CODE_NODE_NEW_NAME).should('exist');
|
|
});
|
|
|
|
it('should undo/redo renaming node using keyboard shortcut', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').trigger('keydown', { key: 'F2' });
|
|
cy.get('.rename-prompt').should('be.visible');
|
|
cy.get('body').type(CODE_NODE_NEW_NAME);
|
|
cy.get('body').type('{enter}');
|
|
WorkflowPage.actions.hitUndo();
|
|
cy.get('body').type('{esc}');
|
|
WorkflowPage.getters.canvasNodeByName(CODE_NODE_NAME).should('exist');
|
|
WorkflowPage.actions.hitRedo();
|
|
cy.get('body').type('{esc}');
|
|
WorkflowPage.getters.canvasNodeByName(CODE_NODE_NEW_NAME).should('exist');
|
|
});
|
|
|
|
it('should undo/redo duplicating a node', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters
|
|
.canvasNodes()
|
|
.last()
|
|
.find('[data-test-id="duplicate-node-button"]')
|
|
.click({ force: true });
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.length', 2);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.length', 3);
|
|
});
|
|
|
|
it('should undo/redo pasting nodes', () => {
|
|
cy.fixture('Test_workflow-actions_paste-data.json').then((data) => {
|
|
cy.get('body').paste(JSON.stringify(data));
|
|
WorkflowPage.actions.zoomToFit();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 0);
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
});
|
|
});
|
|
|
|
it('should undo/redo multiple steps', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(SET_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.actions.zoomToFit();
|
|
|
|
// Disable last node
|
|
WorkflowPage.getters.canvasNodes().last().click();
|
|
WorkflowPage.actions.hitDisableNodeShortcut();
|
|
// Move first one
|
|
WorkflowPage.getters.canvasNodes().first().click();
|
|
cy.drag('[data-test-id="canvas-node"].jtk-drag-selected', 50, 150);
|
|
// Delete the set node
|
|
WorkflowPage.getters.canvasNodeByName(SET_NODE_NAME).click().click();
|
|
cy.get('body').type('{backspace}');
|
|
|
|
// First undo: Should return deleted node
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.canvasNodes().should('have.length', 4);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 3);
|
|
// Second undo: Should move first node to it's original position
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters
|
|
.canvasNodes()
|
|
.first()
|
|
.should('have.attr', 'style', 'left: 420px; top: 260px;');
|
|
// Third undo: Should enable last node
|
|
WorkflowPage.actions.hitUndo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 0);
|
|
|
|
// First redo: Should disable last node
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.disabledNodes().should('have.length', 1);
|
|
// Second redo: Should move the first node
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters
|
|
.canvasNodes()
|
|
.first()
|
|
.should('have.attr', 'style', 'left: 540px; top: 400px;');
|
|
// Third redo: Should delete the Set node
|
|
WorkflowPage.actions.hitRedo();
|
|
WorkflowPage.getters.canvasNodes().should('have.length', 3);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 2);
|
|
});
|
|
});
|