mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-28 22:19:41 -08:00
c3ba0123ad
* first commit for postgres migration * (not working) * sqlite migration * quicksave * fix tests * fix pg test * fix postgres * fix variables import * fix execution saving * add user settings fix * change migration to single lines * patch preferences endpoint * cleanup * improve variable import * cleanup unusued code * Update packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts Co-authored-by: Omar Ajoue <krynble@gmail.com> * address review notes * fix var update/import * refactor: Separate execution data to its own table (#6323) * wip: Temporary migration process * refactor: Create boilerplate repository methods for executions * fix: Lint issues * refactor: Added search endpoint to repository * refactor: Make the execution list work again * wip: Updating how we create and update executions everywhere * fix: Lint issues and remove most of the direct access to execution model * refactor: Remove includeWorkflowData flag and fix more tests * fix: Lint issues * fix: Fixed ordering of executions for FE, removed transaction when saving execution and removed unnecessary update * refactor: Add comment about missing feature * refactor: Refactor counting executions * refactor: Add migration for other dbms and fix issues found * refactor: Fix lint issues * refactor: Remove unnecessary comment and auto inject repo to internal hooks * refactor: remove type assertion * fix: Fix broken tests * fix: Remove unnecessary import * Remove unnecessary toString() call Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * fix: Address comments after review * refactor: Remove unused import * fix: Lint issues * fix: Add correct migration files --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * remove null values from credential export * fix: Fix an issue with queue mode where all running execution would be returned * fix: Update n8n node to allow for workflow ids with letters * set upstream on set branch * remove typo * add nodeAccess to credentials * fix unsaved run check for undefined id * fix(core): Rename version control feature to source control (#6480) * rename versionControl to sourceControl * fix source control tooltip wording --------- Co-authored-by: Romain Minaud <romain.minaud@gmail.com> * fix(editor): Pay 548 hide the set up version control button (#6485) * feat(DebugHelper Node): Fix and include in main app (#6406) * improve node a bit * fixing continueOnFail() ton contain error in json * improve pairedItem * fix random data returning object results * fix nanoId length typo * update pnpm-lock file --------- Co-authored-by: Marcus <marcus@n8n.io> * fix(editor): Remove setup source control CTA button * fix(editor): Remove setup source control CTA button --------- Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com> Co-authored-by: Marcus <marcus@n8n.io> * fix(editor): Update source control docs links (#6488) * feat(DebugHelper Node): Fix and include in main app (#6406) * improve node a bit * fixing continueOnFail() ton contain error in json * improve pairedItem * fix random data returning object results * fix nanoId length typo * update pnpm-lock file --------- Co-authored-by: Marcus <marcus@n8n.io> * feat(editor): Replace root events with event bus events (no-changelog) (#6454) * feat: replace root events with event bus events * fix: prevent cypress from replacing global with globalThis in import path * feat: remove emitter mixin * fix: replace component events with event bus * fix: fix linting issue * fix: fix breaking expression switch * chore: prettify ndv e2e suite code * fix(editor): Update source control docs links --------- Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com> Co-authored-by: Marcus <marcus@n8n.io> Co-authored-by: Alex Grozav <alex@grozav.com> * fix tag endpoint regex --------- Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Romain Minaud <romain.minaud@gmail.com> Co-authored-by: Csaba Tuncsik <csaba@n8n.io> Co-authored-by: Marcus <marcus@n8n.io> Co-authored-by: Alex Grozav <alex@grozav.com>
162 lines
5.3 KiB
TypeScript
162 lines
5.3 KiB
TypeScript
import { ActiveExecutions } from '@/ActiveExecutions';
|
|
import PCancelable from 'p-cancelable';
|
|
import { v4 as uuid } from 'uuid';
|
|
import type { IExecuteResponsePromiseData, IRun } from 'n8n-workflow';
|
|
import { createDeferredPromise } from 'n8n-workflow';
|
|
import type { IWorkflowExecutionDataProcess } from '@/Interfaces';
|
|
import { ExecutionRepository } from '@/databases/repositories';
|
|
import Container from 'typedi';
|
|
|
|
const FAKE_EXECUTION_ID = '15';
|
|
const FAKE_SECOND_EXECUTION_ID = '20';
|
|
|
|
const updateExistingExecution = jest.fn();
|
|
const createNewExecution = jest.fn(async () => {
|
|
return { id: FAKE_EXECUTION_ID };
|
|
});
|
|
|
|
Container.set(ExecutionRepository, {
|
|
updateExistingExecution,
|
|
createNewExecution,
|
|
});
|
|
|
|
describe('ActiveExecutions', () => {
|
|
let activeExecutions: ActiveExecutions;
|
|
|
|
beforeEach(() => {
|
|
activeExecutions = new ActiveExecutions();
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
test('Should initialize activeExecutions with empty list', () => {
|
|
expect(activeExecutions.getActiveExecutions().length).toBe(0);
|
|
});
|
|
|
|
test('Should add execution to active execution list', async () => {
|
|
const newExecution = mockExecutionData();
|
|
const executionId = await activeExecutions.add(newExecution);
|
|
|
|
expect(executionId).toBe(FAKE_EXECUTION_ID);
|
|
expect(activeExecutions.getActiveExecutions().length).toBe(1);
|
|
expect(createNewExecution).toHaveBeenCalledTimes(1);
|
|
expect(updateExistingExecution).toHaveBeenCalledTimes(0);
|
|
});
|
|
|
|
test('Should update execution if add is called with execution ID', async () => {
|
|
const newExecution = mockExecutionData();
|
|
const executionId = await activeExecutions.add(
|
|
newExecution,
|
|
undefined,
|
|
FAKE_SECOND_EXECUTION_ID,
|
|
);
|
|
|
|
expect(executionId).toBe(FAKE_SECOND_EXECUTION_ID);
|
|
expect(activeExecutions.getActiveExecutions().length).toBe(1);
|
|
expect(createNewExecution).toHaveBeenCalledTimes(0);
|
|
expect(updateExistingExecution).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('Should fail attaching execution to invalid executionId', async () => {
|
|
const deferredPromise = mockCancelablePromise();
|
|
|
|
expect(() => {
|
|
activeExecutions.attachWorkflowExecution(FAKE_EXECUTION_ID, deferredPromise);
|
|
}).toThrow();
|
|
});
|
|
|
|
test('Should successfully attach execution to valid executionId', async () => {
|
|
const newExecution = mockExecutionData();
|
|
await activeExecutions.add(newExecution, undefined, FAKE_EXECUTION_ID);
|
|
const deferredPromise = mockCancelablePromise();
|
|
|
|
expect(() =>
|
|
activeExecutions.attachWorkflowExecution(FAKE_EXECUTION_ID, deferredPromise),
|
|
).not.toThrow();
|
|
});
|
|
|
|
test('Should attach and resolve response promise to existing execution', async () => {
|
|
const newExecution = mockExecutionData();
|
|
await activeExecutions.add(newExecution, undefined, FAKE_EXECUTION_ID);
|
|
const deferredPromise = await mockDeferredPromise();
|
|
activeExecutions.attachResponsePromise(FAKE_EXECUTION_ID, deferredPromise);
|
|
const fakeResponse = { data: { resultData: { runData: {} } } };
|
|
activeExecutions.resolveResponsePromise(FAKE_EXECUTION_ID, fakeResponse);
|
|
|
|
await expect(deferredPromise.promise()).resolves.toEqual(fakeResponse);
|
|
});
|
|
|
|
test('Should remove an existing execution', async () => {
|
|
const newExecution = mockExecutionData();
|
|
const executionId = await activeExecutions.add(newExecution);
|
|
activeExecutions.remove(executionId);
|
|
|
|
expect(activeExecutions.getActiveExecutions().length).toBe(0);
|
|
});
|
|
|
|
test('Should resolve post execute promise on removal', async () => {
|
|
const newExecution = mockExecutionData();
|
|
const executionId = await activeExecutions.add(newExecution);
|
|
const postExecutePromise = activeExecutions.getPostExecutePromise(executionId);
|
|
// Force the above to be executed since we cannot await it
|
|
await new Promise((res) => {
|
|
setTimeout(res, 100);
|
|
});
|
|
const fakeOutput = mockFullRunData();
|
|
activeExecutions.remove(executionId, fakeOutput);
|
|
|
|
await expect(postExecutePromise).resolves.toEqual(fakeOutput);
|
|
});
|
|
|
|
test('Should throw error when trying to create a promise with invalid execution', async () => {
|
|
await expect(activeExecutions.getPostExecutePromise(FAKE_EXECUTION_ID)).rejects.toThrow();
|
|
});
|
|
|
|
test('Should call function to cancel execution when asked to stop', async () => {
|
|
const newExecution = mockExecutionData();
|
|
const executionId = await activeExecutions.add(newExecution);
|
|
const cancelExecution = jest.fn();
|
|
const cancellablePromise = mockCancelablePromise();
|
|
cancellablePromise.cancel = cancelExecution;
|
|
activeExecutions.attachWorkflowExecution(executionId, cancellablePromise);
|
|
void activeExecutions.stopExecution(executionId);
|
|
|
|
expect(cancelExecution).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
function mockExecutionData(): IWorkflowExecutionDataProcess {
|
|
return {
|
|
executionMode: 'manual',
|
|
workflowData: {
|
|
name: 'Test workflow 1',
|
|
active: false,
|
|
createdAt: new Date(),
|
|
updatedAt: new Date(),
|
|
nodes: [],
|
|
connections: {},
|
|
},
|
|
userId: uuid(),
|
|
};
|
|
}
|
|
|
|
function mockFullRunData(): IRun {
|
|
return {
|
|
data: {
|
|
resultData: {
|
|
runData: {},
|
|
},
|
|
},
|
|
mode: 'manual',
|
|
startedAt: new Date(),
|
|
status: 'new',
|
|
};
|
|
}
|
|
|
|
// eslint-disable-next-line @typescript-eslint/promise-function-async
|
|
const mockCancelablePromise = () => new PCancelable<IRun>((resolve) => resolve());
|
|
// eslint-disable-next-line @typescript-eslint/promise-function-async
|
|
const mockDeferredPromise = () => createDeferredPromise<IExecuteResponsePromiseData>();
|