n8n/packages/cli/test/unit/middleware/listQuery.test.ts
Iván Ovejero dceff675ec
perf(core): Add filtering and pagination to GET /workflows (#6845)
* Initial setup

* Specify max paginated items

* Simplify

* Add tests

* Add more tests

* Add migrations

* Add top-level property

* Add field selection

* Cleanup

* Rename `total` to `count`

* More cleanup

* Move query logic into `WorkflowRepository`

* Create `AbstractRepository`

* Cleanup

* Fix name

* Remove leftover comments

* Replace reference

* Add default for `rawSkip`

* Remove unneeded typing

* Switch to `class-validator`

* Simplify

* Simplify

* Type as optional

* Make typing more accurate

* Fix lint

* Use `getOwnPropertyNames`

* Use DSL

* Set schema at repo level

* Cleanup

* Remove comment

* Refactor repository methods to middleware

* Add middleware tests

* Remove old test files

* Remove generic experiment

* Reuse `reportError`

* Remove unused type

* Cleanup

* Improve wording

* Reduce diff

* Add missing mw

* Use `Container.get`

* Adjust lint rule

* Reorganize into subdir

* Remove unused directive

* Remove nodes

* Silly mistake

* Validate take

* refactor(core): Adjust index handling in new migrations DSL (no-changelog) (#6876)

* refactor(core): Adjust index handling in new migrations DSL (no-changelog)

* Account for custom index name

* Also for dropping

* Fix `select` issue with `relations`

* Tighten validation

* Ensure `ownerId` is not added when specifying `select`
2023-08-09 12:30:02 +02:00

120 lines
3.8 KiB
TypeScript

import { filterListQueryMiddleware } from '@/middlewares/listQuery/filter';
import { LoggerProxy } from 'n8n-workflow';
import { getLogger } from '@/Logger';
import type { Request, Response, NextFunction } from 'express';
import type { ListQueryRequest } from '@/requests';
import { selectListQueryMiddleware } from '@/middlewares/listQuery/select';
import { paginationListQueryMiddleware } from '@/middlewares/listQuery/pagination';
describe('List query middleware', () => {
let mockReq: Partial<ListQueryRequest>;
let mockRes: Partial<Response>;
let nextFn: NextFunction = jest.fn();
let args: [Request, Response, NextFunction];
beforeEach(() => {
LoggerProxy.init(getLogger());
mockReq = { baseUrl: '/rest/workflows' };
args = [mockReq as Request, mockRes as Response, nextFn];
jest.restoreAllMocks();
});
describe('Query filter', () => {
test('should parse valid filter', () => {
mockReq.query = { filter: '{ "name": "My Workflow" }' };
filterListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toEqual({ filter: { name: 'My Workflow' } });
expect(nextFn).toBeCalledTimes(1);
});
test('should ignore invalid filter', () => {
mockReq.query = { filter: '{ "name": "My Workflow", "foo": "bar" }' };
filterListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toEqual({ filter: { name: 'My Workflow' } });
expect(nextFn).toBeCalledTimes(1);
});
test('should throw on invalid JSON', () => {
mockReq.query = { filter: '{ "name" : "My Workflow"' };
const call = () => filterListQueryMiddleware(...args);
expect(call).toThrowError('Failed to parse filter JSON');
});
});
describe('Query select', () => {
test('should parse valid select', () => {
mockReq.query = { select: '["name", "id"]' };
selectListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toEqual({ select: { name: true, id: true } });
expect(nextFn).toBeCalledTimes(1);
});
test('ignore invalid select', () => {
mockReq.query = { select: '["name", "foo"]' };
selectListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toEqual({ select: { name: true } });
expect(nextFn).toBeCalledTimes(1);
});
test('throw on invalid JSON', () => {
mockReq.query = { select: '["name"' };
const call = () => selectListQueryMiddleware(...args);
expect(call).toThrowError('Failed to parse select JSON');
});
test('throw on non-string-array JSON for select', () => {
mockReq.query = { select: '"name"' };
const call = () => selectListQueryMiddleware(...args);
expect(call).toThrowError('Parsed select is not a string array');
});
});
describe('Query pagination', () => {
test('should parse valid pagination', () => {
mockReq.query = { skip: '1', take: '2' };
paginationListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toEqual({ skip: 1, take: 2 });
expect(nextFn).toBeCalledTimes(1);
});
test('should ignore skip without take', () => {
mockReq.query = { skip: '1' };
paginationListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toBeUndefined();
expect(nextFn).toBeCalledTimes(1);
});
test('should default skip to 0', () => {
mockReq.query = { take: '2' };
paginationListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toEqual({ skip: 0, take: 2 });
expect(nextFn).toBeCalledTimes(1);
});
test('should cap take at 50', () => {
mockReq.query = { take: '51' };
paginationListQueryMiddleware(...args);
expect(mockReq.listQueryOptions).toEqual({ skip: 0, take: 50 });
expect(nextFn).toBeCalledTimes(1);
});
test('should throw on non-numeric-integer take', () => {
mockReq.query = { take: '3.2' };
const call = () => paginationListQueryMiddleware(...args);
expect(call).toThrowError('Parameter take or skip is not an integer string');
});
});
});