mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-10 14:44:05 -08:00
c3ba0123ad
* first commit for postgres migration * (not working) * sqlite migration * quicksave * fix tests * fix pg test * fix postgres * fix variables import * fix execution saving * add user settings fix * change migration to single lines * patch preferences endpoint * cleanup * improve variable import * cleanup unusued code * Update packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts Co-authored-by: Omar Ajoue <krynble@gmail.com> * address review notes * fix var update/import * refactor: Separate execution data to its own table (#6323) * wip: Temporary migration process * refactor: Create boilerplate repository methods for executions * fix: Lint issues * refactor: Added search endpoint to repository * refactor: Make the execution list work again * wip: Updating how we create and update executions everywhere * fix: Lint issues and remove most of the direct access to execution model * refactor: Remove includeWorkflowData flag and fix more tests * fix: Lint issues * fix: Fixed ordering of executions for FE, removed transaction when saving execution and removed unnecessary update * refactor: Add comment about missing feature * refactor: Refactor counting executions * refactor: Add migration for other dbms and fix issues found * refactor: Fix lint issues * refactor: Remove unnecessary comment and auto inject repo to internal hooks * refactor: remove type assertion * fix: Fix broken tests * fix: Remove unnecessary import * Remove unnecessary toString() call Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * fix: Address comments after review * refactor: Remove unused import * fix: Lint issues * fix: Add correct migration files --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * remove null values from credential export * fix: Fix an issue with queue mode where all running execution would be returned * fix: Update n8n node to allow for workflow ids with letters * set upstream on set branch * remove typo * add nodeAccess to credentials * fix unsaved run check for undefined id * fix(core): Rename version control feature to source control (#6480) * rename versionControl to sourceControl * fix source control tooltip wording --------- Co-authored-by: Romain Minaud <romain.minaud@gmail.com> * fix(editor): Pay 548 hide the set up version control button (#6485) * feat(DebugHelper Node): Fix and include in main app (#6406) * improve node a bit * fixing continueOnFail() ton contain error in json * improve pairedItem * fix random data returning object results * fix nanoId length typo * update pnpm-lock file --------- Co-authored-by: Marcus <marcus@n8n.io> * fix(editor): Remove setup source control CTA button * fix(editor): Remove setup source control CTA button --------- Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com> Co-authored-by: Marcus <marcus@n8n.io> * fix(editor): Update source control docs links (#6488) * feat(DebugHelper Node): Fix and include in main app (#6406) * improve node a bit * fixing continueOnFail() ton contain error in json * improve pairedItem * fix random data returning object results * fix nanoId length typo * update pnpm-lock file --------- Co-authored-by: Marcus <marcus@n8n.io> * feat(editor): Replace root events with event bus events (no-changelog) (#6454) * feat: replace root events with event bus events * fix: prevent cypress from replacing global with globalThis in import path * feat: remove emitter mixin * fix: replace component events with event bus * fix: fix linting issue * fix: fix breaking expression switch * chore: prettify ndv e2e suite code * fix(editor): Update source control docs links --------- Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com> Co-authored-by: Marcus <marcus@n8n.io> Co-authored-by: Alex Grozav <alex@grozav.com> * fix tag endpoint regex --------- Co-authored-by: Omar Ajoue <krynble@gmail.com> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Romain Minaud <romain.minaud@gmail.com> Co-authored-by: Csaba Tuncsik <csaba@n8n.io> Co-authored-by: Marcus <marcus@n8n.io> Co-authored-by: Alex Grozav <alex@grozav.com>
239 lines
5.6 KiB
TypeScript
239 lines
5.6 KiB
TypeScript
import { v4 as uuid } from 'uuid';
|
|
import * as Db from '@/Db';
|
|
import config from '@/config';
|
|
import { audit } from '@/audit';
|
|
import { CREDENTIALS_REPORT } from '@/audit/constants';
|
|
import { getRiskSection } from './utils';
|
|
import * as testDb from '../shared/testDb';
|
|
import { generateNanoId } from '@/databases/utils/generators';
|
|
|
|
beforeAll(async () => {
|
|
await testDb.init();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await testDb.truncate(['Workflow', 'Credentials', 'Execution']);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await testDb.terminate();
|
|
});
|
|
|
|
test('should report credentials not in any use', async () => {
|
|
const credentialDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Slack Credential',
|
|
data: 'U2FsdGVkX18WjITBG4IDqrGB1xE/uzVNjtwDAG3lP7E=',
|
|
type: 'slackApi',
|
|
nodesAccess: [{ nodeType: 'n8n-nodes-base.slack', date: '2022-12-21T11:23:00.561Z' }],
|
|
};
|
|
|
|
const workflowDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Test Workflow',
|
|
active: false,
|
|
connections: {},
|
|
nodeTypes: {},
|
|
nodes: [
|
|
{
|
|
id: uuid(),
|
|
name: 'My Node',
|
|
type: 'n8n-nodes-base.slack',
|
|
typeVersion: 1,
|
|
position: [0, 0] as [number, number],
|
|
},
|
|
],
|
|
};
|
|
|
|
await Promise.all([
|
|
Db.collections.Credentials.save(credentialDetails),
|
|
Db.collections.Workflow.save(workflowDetails),
|
|
]);
|
|
|
|
const testAudit = await audit(['credentials']);
|
|
|
|
const section = getRiskSection(
|
|
testAudit,
|
|
CREDENTIALS_REPORT.RISK,
|
|
CREDENTIALS_REPORT.SECTIONS.CREDS_NOT_IN_ANY_USE,
|
|
);
|
|
|
|
expect(section.location).toHaveLength(1);
|
|
expect(section.location[0]).toMatchObject({
|
|
id: credentialDetails.id,
|
|
name: 'My Slack Credential',
|
|
});
|
|
});
|
|
|
|
test('should report credentials not in active use', async () => {
|
|
const credentialDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Slack Credential',
|
|
data: 'U2FsdGVkX18WjITBG4IDqrGB1xE/uzVNjtwDAG3lP7E=',
|
|
type: 'slackApi',
|
|
nodesAccess: [{ nodeType: 'n8n-nodes-base.slack', date: '2022-12-21T11:23:00.561Z' }],
|
|
};
|
|
|
|
const credential = await Db.collections.Credentials.save(credentialDetails);
|
|
|
|
const workflowDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Test Workflow',
|
|
active: false,
|
|
connections: {},
|
|
nodeTypes: {},
|
|
nodes: [
|
|
{
|
|
id: uuid(),
|
|
name: 'My Node',
|
|
type: 'n8n-nodes-base.slack',
|
|
typeVersion: 1,
|
|
position: [0, 0] as [number, number],
|
|
},
|
|
],
|
|
};
|
|
|
|
await Db.collections.Workflow.save(workflowDetails);
|
|
|
|
const testAudit = await audit(['credentials']);
|
|
|
|
const section = getRiskSection(
|
|
testAudit,
|
|
CREDENTIALS_REPORT.RISK,
|
|
CREDENTIALS_REPORT.SECTIONS.CREDS_NOT_IN_ACTIVE_USE,
|
|
);
|
|
|
|
expect(section.location).toHaveLength(1);
|
|
expect(section.location[0]).toMatchObject({
|
|
id: credential.id,
|
|
name: 'My Slack Credential',
|
|
});
|
|
});
|
|
|
|
test('should report credential in not recently executed workflow', async () => {
|
|
const credentialDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Slack Credential',
|
|
data: 'U2FsdGVkX18WjITBG4IDqrGB1xE/uzVNjtwDAG3lP7E=',
|
|
type: 'slackApi',
|
|
nodesAccess: [{ nodeType: 'n8n-nodes-base.slack', date: '2022-12-21T11:23:00.561Z' }],
|
|
};
|
|
|
|
const credential = await Db.collections.Credentials.save(credentialDetails);
|
|
|
|
const workflowDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Test Workflow',
|
|
active: false,
|
|
connections: {},
|
|
nodeTypes: {},
|
|
nodes: [
|
|
{
|
|
id: uuid(),
|
|
name: 'My Node',
|
|
type: 'n8n-nodes-base.slack',
|
|
typeVersion: 1,
|
|
position: [0, 0] as [number, number],
|
|
credentials: {
|
|
slackApi: {
|
|
id: credential.id,
|
|
name: credential.name,
|
|
},
|
|
},
|
|
},
|
|
],
|
|
};
|
|
|
|
const workflow = await Db.collections.Workflow.save(workflowDetails);
|
|
|
|
const date = new Date();
|
|
date.setDate(date.getDate() - config.getEnv('security.audit.daysAbandonedWorkflow') - 1);
|
|
|
|
const savedExecution = await Db.collections.Execution.save({
|
|
finished: true,
|
|
mode: 'manual',
|
|
startedAt: date,
|
|
stoppedAt: date,
|
|
workflowId: workflow.id,
|
|
waitTill: null,
|
|
});
|
|
await Db.collections.ExecutionData.save({
|
|
execution: savedExecution,
|
|
data: '[]',
|
|
workflowData: workflow,
|
|
});
|
|
|
|
const testAudit = await audit(['credentials']);
|
|
|
|
const section = getRiskSection(
|
|
testAudit,
|
|
CREDENTIALS_REPORT.RISK,
|
|
CREDENTIALS_REPORT.SECTIONS.CREDS_NOT_RECENTLY_EXECUTED,
|
|
);
|
|
|
|
expect(section.location).toHaveLength(1);
|
|
expect(section.location[0]).toMatchObject({
|
|
id: credential.id,
|
|
name: credential.name,
|
|
});
|
|
});
|
|
|
|
test('should not report credentials in recently executed workflow', async () => {
|
|
const credentialDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Slack Credential',
|
|
data: 'U2FsdGVkX18WjITBG4IDqrGB1xE/uzVNjtwDAG3lP7E=',
|
|
type: 'slackApi',
|
|
nodesAccess: [{ nodeType: 'n8n-nodes-base.slack', date: '2022-12-21T11:23:00.561Z' }],
|
|
};
|
|
|
|
const credential = await Db.collections.Credentials.save(credentialDetails);
|
|
|
|
const workflowDetails = {
|
|
id: generateNanoId(),
|
|
name: 'My Test Workflow',
|
|
active: true,
|
|
connections: {},
|
|
nodeTypes: {},
|
|
nodes: [
|
|
{
|
|
id: uuid(),
|
|
name: 'My Node',
|
|
type: 'n8n-nodes-base.slack',
|
|
typeVersion: 1,
|
|
position: [0, 0] as [number, number],
|
|
credentials: {
|
|
slackApi: {
|
|
id: credential.id,
|
|
name: credential.name,
|
|
},
|
|
},
|
|
},
|
|
],
|
|
};
|
|
|
|
const workflow = await Db.collections.Workflow.save(workflowDetails);
|
|
|
|
const date = new Date();
|
|
date.setDate(date.getDate() - config.getEnv('security.audit.daysAbandonedWorkflow') + 1);
|
|
|
|
const savedExecution = await Db.collections.Execution.save({
|
|
finished: true,
|
|
mode: 'manual',
|
|
startedAt: date,
|
|
stoppedAt: date,
|
|
workflowId: workflow.id,
|
|
waitTill: null,
|
|
});
|
|
|
|
await Db.collections.ExecutionData.save({
|
|
execution: savedExecution,
|
|
data: '[]',
|
|
workflowData: workflow,
|
|
});
|
|
|
|
const testAudit = await audit(['credentials']);
|
|
|
|
expect(testAudit).toBeEmptyArray();
|
|
});
|