mirror of
https://github.com/n8n-io/n8n.git
synced 2025-01-24 19:11:55 -08:00
97cd564f7b
* 🎉 starting feature development * ✨ sharing/unsharing a credential (#3601) * 🎉 initial design * ✨ sharing/unsharing of credentials * ✅ add tests for EE credentials controller * 💪 implement review comments * 🛠 refactor agent creation and credential role locking * 👕 linting adjustments (#3691) * 👕 Adjust rule `naming-convention` * 👕 Fix `naming-convention` config value * 👕 Disregard casing for EE-prefixed vars Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * 🛠 refactor authAgents in tests (#3725) * 🛠 refactor authAgent * 🛠 refactor authAgent * 🛠 refactor authAgent * 🛠 refactor authAgent * 👕 fix ts issue * 🐘 add migration for mysql and postgres + add AuthAgent type Co-authored-by: Iván Ovejero <ivov.src@gmail.com> * ⚡️ refactor existing credentials routes (#3672) * 🎉 initial design * ✨ sharing/unsharing of credentials * ♻️ split credential update route into controller and service * 🔥 remove credentials test that is no longer applicable * ♻️ split credential creation route into controller and service * ♻️ split single credential get * ♻️ split delete credentials route * ♻️ split get all credentials route * 🔥 remove unused imports in credentials contoller * 🔥 remove console.log * :refactor: changes to credentials controller and service from review - removed credentials from service function names - made relations list optional - put allowGlobalOwner in options objects - check length of relations array so join doesn't happen if empty - update some comments to further explain rationale - remove unneeded `Object.assign` - remove non-null assertion from test * ♻️ move filtered credentials selected fields to variable * ♻️ remove unneeded merges in credentials service Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com> * ✅ fix test * 🐛 fix imports * 👕 fix lint issue * User Management: switch over to decorators to define routes (#3827) * Add permissions details to credentials for User Management (#3863) * ⚡ Open `GET /users` * ⚡ Add permissions to cred service * 🚚 Rename method * ⚡ Refactor cred controller * 🧪 Adjust test * ✏️ Improve comment * ✏️ Improve another comment * ⚡ Account for multiple sharings * 🐛 Fix access when user is editor * 📘 Expand interface * 📘 Relocate types * 📘 Exempt cred entity with service-injected fields * 📘 Adjust interface * ♻️ Add permissions only in `GET /credentials` * 🧪 Add expectations for `ownedBy` * 🧪 Add sharing details test * 🧪 Make `ownedBy` checks more granular * 📘 Adjust interface * 🚚 Rename cred getter * ♻️ Refactor cred getter * 🧪 Expand tests * ♻️ Refactor to use guard * 👕 Remove unneeded lint exception * 🔥 Remove unneeded relation * 🚚 Move relation to `GET /credentials/:id` * 📘 Consolidate typings * 🎨 Add multiline for readability * 🔥 Remove unneeded type * ✏️ Clarity comment * ✏️ Make comments consistent * 👕 Add exception to fix build * 👕 Add more lint exceptions to fix build * 🐛 Check for non-owner * 📘 Improve typings * 🧪 Temporarily skip tests * 🔥 Remove `@ts-ignore` * 👕 Move lint exceptions * ♻️ Refactor cred service and controller * ⚡ Simplify check * ✏️ adjust naming to experimental * ⚡️ add credentialsSharing flag to settings * 🛠 add helper to check if UM is also enabled as dependency for CredentialsSharing * 👕 fix lint error * 🐘 change name of credential role * 🚧 WIP batch sharing * 🚧 WIP use put for sharing * ✅ add tests for batch sharing, 🛠 implement review suggestions * ✅ expand credential sharing tests for User Management (#3931) * 🧪 Expand cred sharing tests * ⚡ Add recently added flags * ✅ fix and adjust tests for /credentials Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> * ✨ User management v2 Front End (#3795) * feat: Added responsive generic page view layout. * feat: Added empty state. * feat: Added credentials view empty state. * test: Added unit tests for N8nActionBox * feat: Added credentials list initial design. * feat: Added credential actions. Started working on filters. * feat: Updated InfoTip markup, added tests and changed stories to typescript. * feat: Added credentials filtering by type. Added support for apply/reset filters. * feat: Added credential sharing user select and user list. Added paywall component. * feat: Updated credentials view permissions. * feat: Added support for temporary sharing config for unsaved credentials. * test: Fixed broken snapshots. * feat: Added overflow styles to page-view-layout list. * feat: Handled sharee specific views. * feat: Integration between FE and BE to support real-world credential sharing scenario. * feat: Added front end permissions table. * feat: Refactored credential sharing flow. Updated design elements. * feat: Added margin and padding auto spacer utilities. * feat: Rehauled permissions to support instanceOwner role and action inheritance. * feat: Updated credentials view to apply filters automatically. * feat: Removed apply filters button and added active button state. * test: Updated component snapshots. * refactor: Renamed ResourceSharee to ResourceReader. * feat: Credential sharing error handling, permissions improvement. * feat: Updated permissions and error handling. * chore: Removed console.log. * 🛠 refactor enabling of credentialsSharing * feat: Removed owner menu selector from credentials when sharing is disabled. * refactor: Moved EE features into ee store module file. * 🛠 add sharing info to GET credentials/:id * fix: Fixed initial credential data loading for sharing. * chore: Removed console.log. * 🐛 owner can fetch any credential * 🛠 refactor users test * 👕 fix build type issue * fix: Removed owner tag when credential sharing is disabled. Fixed small reactivity issue. * chore: Removed console.log. * 🚧 separate fetching credentials between EE and open * fix: Fixed empty dropdown in users list. * fix: Fixed error message and initialization when credential gets unshared. * ✅ add tests for fetching single credential * Revert decorators based controllers * ⚡️ adjust credentials test route to also allow testing for sharees (#3999) * ⚡️ pull data if user is sharee * fix: Removed sharedWith and ownedBy from credentialData on testing credentials. Co-authored-by: Alex Grozav <alex@grozav.com> * 📈 add BE analytics * 💪 improve credential test * ⚡️ adjust tracking properties * ⚡️ removed roles from tracking * 🐛 fix build by removing imports * 🐛 fix missed merge conflict * feat: User management P2 Front End bug bash and improvements (#4014) * fix: Fixed type select size after reopening dropdown. * fix: Fixed template cards. * fix: Fixed card content size and copy input. * fix: Fixed horizontal overflow. * fix: Hiding el-tags scrollbar in select. * fix: Added fallback credential icon. Added oAuth credential owner check. * feat: Added disabled state to user select. * feat: Added fallback scenario for non-existent credential types. * feat: Adjusted credentials empty state to show that there are shared credentials. * fix: Fixed time title. * feat: Added actionable empty state when shared credentials are present. * fix: Made action box x padding smaller * feat: Repositioned owner tag for credential card. * feat: Updated message box styling to use n8n css variables. * feat: Added confirmation for deleting sharee. * fix: Fixed deleted credential types. Fixed select in dropdown bug. * fix: Various code improvements. Addressed PR review comments. * fix: Fixed credential deletion errors. * fix: Various code quality improvements. * feat: N8N-4531 update cloud coming soon features (#4025) * feat: Showing different upcoming feature messages and format for cloud. * fix: Changed url format. * fix: Updated how cloud deployment is determined. * feat: N8N-4527 implementing credential sharing FE telemetry (#4023) * feat: Added credential sharing telemetry. * chore: Renamed computed function for consistency. * refactor: Simplified subview telemetry sending. * fix: Changed to callDebounced() helper. * 📧 update email text * fix: Adjusted feature coming soon margin. * chore: Fixed type and line height for delete sharee confirmation modal. * refactor(editor-ui): Update telemetry (#4040) * 🔥 Remove `identify` from BE * ⚡ Add `versionCli` * ⚡ Add node creator ignore input * ⚡ Move obfuscators to editor-ui * ⚡ Refactor `ph-no-capture` * ⚡ Pass `user_id` to manual exec props * 🚚 Relocate class in `SettingsApiView` * ⚡ Add `userId` to BE PH `identify` call * ⏪ Revert "⚡ Add `userId` to BE PH `identify` call" This reverts commit895aaa45e5
. * Revert "⏪ Revert "⚡ Add `userId` to BE PH `identify` call"" This reverts commitb86a098c20
. * 🐛 Fix `Promise` handling in `track()` call * ⏪ Restore `Db.collections` call * ⚡ Set up PH payload to mirror RS * 🔥 Remove excess `userId` * 📘 Remove `userId` from interface * 🔥 Remove unused ref and method * fix: Fixed bug causing instanceOwner to become credential owner on update. (#4079) * 🐛 fix test for credential shared with member * 👕 fix lint issues * delete conflicting migration. this data is already seeded in CreateUserManagement * feat: Expand obfuscation to User Management credential sharing (#4070) ⚡ Expand obfuscation * feat: Added credential sharing infotip for instance owner. * bring back the migration. add a check to avoid conflicts on inserts * fix(cli): use a non-env config flag to detect of enterprise features are enabled (#4105) * chore: Changed ampersand to and in translation. * refactor(telemetry): Obfuscate code and JSON editors (#4118) ⚡ Obfuscate code and JSON editors * feat(editor): improve design and functionality of coming soon features (#4116) * feat: Improved coming soon feature design and functionality. * style: Removed empty line. * chore: Removed unused translation. * fix: fix telemetry for credential creates and updates (#4125) fix telemetry for credential creates and updates * feat: Display errors due to missing credentials in the correct node (#4124) feat: Display errors due to invalid credentials in the correct node when missing permissions * fix: remove duplicate header for coming soon features in cloud deployment * telemetry: fix the payload for `User viewed credential tab` * telemetry: add credential_id to 'User selected credential from node modal' * feat: update empty states for coming soon features * Update ActionBox.spec.ts.snap * replace UserSharingsDetails with a subset of User properties * rename the CreateCredentialsEditorRole to CreateCredentialsUserRole * move IUser to the workflow package * use IUser in the frontend as well Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Valya <68596159+valya@users.noreply.github.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com> Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in> Co-authored-by: Omar Ajoue <krynble@gmail.com>
183 lines
5.7 KiB
TypeScript
183 lines
5.7 KiB
TypeScript
/* eslint-disable import/no-cycle */
|
|
import express from 'express';
|
|
import { INodeCredentialTestResult, LoggerProxy } from 'n8n-workflow';
|
|
import { Db, InternalHooksManager, ResponseHelper } from '..';
|
|
import type { CredentialsEntity } from '../databases/entities/CredentialsEntity';
|
|
|
|
import type { CredentialRequest } from '../requests';
|
|
import { EECredentialsService as EECredentials } from './credentials.service.ee';
|
|
import type { CredentialWithSharings } from './credentials.types';
|
|
import { isCredentialsSharingEnabled, rightDiff } from './helpers';
|
|
|
|
// eslint-disable-next-line @typescript-eslint/naming-convention
|
|
export const EECredentialsController = express.Router();
|
|
|
|
EECredentialsController.use((req, res, next) => {
|
|
if (!isCredentialsSharingEnabled()) {
|
|
// skip ee router and use free one
|
|
next('router');
|
|
return;
|
|
}
|
|
// use ee router
|
|
next();
|
|
});
|
|
|
|
/**
|
|
* GET /credentials
|
|
*/
|
|
EECredentialsController.get(
|
|
'/',
|
|
ResponseHelper.send(async (req: CredentialRequest.GetAll): Promise<CredentialWithSharings[]> => {
|
|
try {
|
|
const allCredentials = await EECredentials.getAll(req.user, {
|
|
relations: ['shared', 'shared.role', 'shared.user'],
|
|
});
|
|
|
|
// eslint-disable-next-line @typescript-eslint/unbound-method
|
|
return allCredentials.map(EECredentials.addOwnerAndSharings);
|
|
} catch (error) {
|
|
LoggerProxy.error('Request to list credentials failed', error as Error);
|
|
throw error;
|
|
}
|
|
}),
|
|
);
|
|
|
|
/**
|
|
* GET /credentials/:id
|
|
*/
|
|
EECredentialsController.get(
|
|
'/:id',
|
|
(req, res, next) => (req.params.id === 'new' ? next('router') : next()), // skip ee router and use free one for naming
|
|
ResponseHelper.send(async (req: CredentialRequest.Get) => {
|
|
const { id: credentialId } = req.params;
|
|
const includeDecryptedData = req.query.includeData === 'true';
|
|
|
|
if (Number.isNaN(Number(credentialId))) {
|
|
throw new ResponseHelper.ResponseError(`Credential ID must be a number.`, undefined, 400);
|
|
}
|
|
|
|
let credential = (await EECredentials.get(
|
|
{ id: credentialId },
|
|
{ relations: ['shared', 'shared.role', 'shared.user'] },
|
|
)) as CredentialsEntity & CredentialWithSharings;
|
|
|
|
if (!credential) {
|
|
throw new ResponseHelper.ResponseError(
|
|
`Credential with ID "${credentialId}" could not be found.`,
|
|
undefined,
|
|
404,
|
|
);
|
|
}
|
|
|
|
const userSharing = credential.shared?.find((shared) => shared.user.id === req.user.id);
|
|
|
|
if (!userSharing && req.user.globalRole.name !== 'owner') {
|
|
throw new ResponseHelper.ResponseError(`Forbidden.`, undefined, 403);
|
|
}
|
|
|
|
credential = EECredentials.addOwnerAndSharings(credential);
|
|
|
|
// @ts-ignore @TODO_TECH_DEBT: Stringify `id` with entity field transformer
|
|
credential.id = credential.id.toString();
|
|
|
|
if (!includeDecryptedData || !userSharing || userSharing.role.name !== 'owner') {
|
|
// eslint-disable-next-line @typescript-eslint/no-unused-vars
|
|
const { id, data: _, ...rest } = credential;
|
|
|
|
// @TODO_TECH_DEBT: Stringify `id` with entity field transformer
|
|
return { id: id.toString(), ...rest };
|
|
}
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-unused-vars
|
|
const { id, data: _, ...rest } = credential;
|
|
|
|
const key = await EECredentials.getEncryptionKey();
|
|
const decryptedData = await EECredentials.decrypt(key, credential);
|
|
|
|
// @TODO_TECH_DEBT: Stringify `id` with entity field transformer
|
|
return { id: id.toString(), data: decryptedData, ...rest };
|
|
}),
|
|
);
|
|
|
|
/**
|
|
* POST /credentials/test
|
|
*
|
|
* Test if a credential is valid.
|
|
*/
|
|
EECredentialsController.post(
|
|
'/test',
|
|
ResponseHelper.send(async (req: CredentialRequest.Test): Promise<INodeCredentialTestResult> => {
|
|
const { credentials, nodeToTestWith } = req.body;
|
|
|
|
const encryptionKey = await EECredentials.getEncryptionKey();
|
|
|
|
const { ownsCredential } = await EECredentials.isOwned(req.user, credentials.id.toString());
|
|
|
|
if (!ownsCredential) {
|
|
const sharing = await EECredentials.getSharing(req.user, credentials.id);
|
|
if (!sharing) {
|
|
throw new ResponseHelper.ResponseError(`Forbidden`, undefined, 403);
|
|
}
|
|
|
|
const decryptedData = await EECredentials.decrypt(encryptionKey, sharing.credentials);
|
|
Object.assign(credentials, { data: decryptedData });
|
|
}
|
|
|
|
return EECredentials.test(req.user, encryptionKey, credentials, nodeToTestWith);
|
|
}),
|
|
);
|
|
|
|
/**
|
|
* (EE) PUT /credentials/:id/share
|
|
*
|
|
* Grant or remove users' access to a credential.
|
|
*/
|
|
|
|
EECredentialsController.put('/:credentialId/share', async (req: CredentialRequest.Share, res) => {
|
|
const { credentialId } = req.params;
|
|
const { shareWithIds } = req.body;
|
|
|
|
if (!Array.isArray(shareWithIds) || !shareWithIds.every((userId) => typeof userId === 'string')) {
|
|
return res.status(400).send('Bad Request');
|
|
}
|
|
|
|
const { ownsCredential, credential } = await EECredentials.isOwned(req.user, credentialId);
|
|
|
|
if (!ownsCredential || !credential) {
|
|
return res.status(403).send();
|
|
}
|
|
|
|
let amountRemoved: number | null = null;
|
|
let newShareeIds: string[] = [];
|
|
await Db.transaction(async (trx) => {
|
|
// remove all sharings that are not supposed to exist anymore
|
|
const { affected } = await EECredentials.pruneSharings(trx, credentialId, [
|
|
req.user.id,
|
|
...shareWithIds,
|
|
]);
|
|
if (affected) amountRemoved = affected;
|
|
|
|
const sharings = await EECredentials.getSharings(trx, credentialId);
|
|
|
|
// extract the new sharings that need to be added
|
|
newShareeIds = rightDiff(
|
|
[sharings, (sharing) => sharing.userId],
|
|
[shareWithIds, (shareeId) => shareeId],
|
|
);
|
|
|
|
if (newShareeIds.length) {
|
|
await EECredentials.share(trx, credential, newShareeIds);
|
|
}
|
|
});
|
|
|
|
void InternalHooksManager.getInstance().onUserSharedCredentials({
|
|
credential_type: credential.type,
|
|
credential_id: credential.id.toString(),
|
|
user_id_sharer: req.user.id,
|
|
user_ids_sharees_added: newShareeIds,
|
|
sharees_removed: amountRemoved,
|
|
});
|
|
|
|
return res.status(200).send();
|
|
});
|