mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-10 22:54:05 -08:00
1bb987140a
* feat: add variables db models and migrations * feat: variables api endpoints * feat: add $variables to expressions * test: fix ActiveWorkflowRunner tests failing * test: a different fix for the tests broken by $variables * feat: variables licensing * fix: could create one extra variable than licensed for * feat: Add Variables UI page and $vars global property (#5750) * feat: add support for row slot to datatable * feat: add variables create, read, update, delete * feat: add vars autocomplete * chore: remove alert * feat: add variables autocomplete for code and expressions * feat: add tests for variable components * feat: add variables search and sort * test: update tests for variables view * chore: fix test and linting issue * refactor: review changes * feat: add variable creation telemetry * fix: Improve variables listing and disabled case, fix resource sorting (no-changelog) (#5903) * fix: Improve variables disabled experience and fix sorting * fix: update action box margin * test: update tests for variables row and datatable * fix: Add ee controller to base controller * fix: variables.ee routes not being added * feat: add variables validation * fix: fix vue-fragment bug that breaks everything * chore: Update lock * feat: Add variables input validation and permissions (no-changelog) (#5910) * feat: add input validation * feat: handle variables view for non-instance-owner users * test: update variables tests * fix: fix data-testid pattern * feat: improve overflow styles * test: fix variables row snapshot * feat: update sorting to take newly created variables into account * fix: fix list layout overflow * fix: fix adding variables on page other than 1. fix validation * feat: add docs link * fix: fix default displayName function for resource-list-layout * feat: improve vars expressions ux, cm-tooltip * test: fix datatable test * feat: add MATCH_REGEX validation rule * fix: overhaul how datatable pagination selector works * feat: update completer description * fix: conditionally update usage syntax based on key validation * test: update datatable snapshot * fix: fix variables-row button margins * fix: fix pagination overflow * test: Fix broken test * test: Update snapshot * fix: Remove duplicate declaration * feat: add custom variables icon --------- Co-authored-by: Alex Grozav <alex@grozav.com> Co-authored-by: Omar Ajoue <krynble@gmail.com>
270 lines
8.5 KiB
TypeScript
270 lines
8.5 KiB
TypeScript
import { v4 as uuid } from 'uuid';
|
|
import { mocked } from 'jest-mock';
|
|
|
|
import {
|
|
ICredentialTypes,
|
|
INodesAndCredentials,
|
|
LoggerProxy,
|
|
NodeOperationError,
|
|
Workflow,
|
|
} from 'n8n-workflow';
|
|
|
|
import { ActiveWorkflowRunner } from '@/ActiveWorkflowRunner';
|
|
import * as Db from '@/Db';
|
|
import { WorkflowEntity } from '@db/entities/WorkflowEntity';
|
|
import { SharedWorkflow } from '@db/entities/SharedWorkflow';
|
|
import { Role } from '@db/entities/Role';
|
|
import { User } from '@db/entities/User';
|
|
import { getLogger } from '@/Logger';
|
|
import { randomEmail, randomName } from '../integration/shared/random';
|
|
import * as Helpers from './Helpers';
|
|
import * as WorkflowExecuteAdditionalData from '@/WorkflowExecuteAdditionalData';
|
|
|
|
import { WorkflowRunner } from '@/WorkflowRunner';
|
|
import { mock } from 'jest-mock-extended';
|
|
import { ExternalHooks } from '@/ExternalHooks';
|
|
import { Container } from 'typedi';
|
|
import { LoadNodesAndCredentials } from '@/LoadNodesAndCredentials';
|
|
import { mockInstance } from '../integration/shared/utils';
|
|
import { Push } from '@/push';
|
|
import { ActiveExecutions } from '@/ActiveExecutions';
|
|
import { NodeTypes } from '@/NodeTypes';
|
|
|
|
/**
|
|
* TODO:
|
|
* - test workflow webhooks activation (that trigger `executeWebhook`and other webhook methods)
|
|
* - test activation error catching and getters such as `getActivationError` (requires building a workflow that fails to activate)
|
|
* - test queued workflow activation functions (might need to create a non-working workflow to test this)
|
|
*/
|
|
|
|
let databaseActiveWorkflowsCount = 0;
|
|
let databaseActiveWorkflowsList: WorkflowEntity[] = [];
|
|
|
|
const generateWorkflows = (count: number): WorkflowEntity[] => {
|
|
const workflows: WorkflowEntity[] = [];
|
|
const ownerRole = new Role();
|
|
ownerRole.scope = 'workflow';
|
|
ownerRole.name = 'owner';
|
|
ownerRole.id = '1';
|
|
|
|
const owner = new User();
|
|
owner.id = uuid();
|
|
owner.firstName = randomName();
|
|
owner.lastName = randomName();
|
|
owner.email = randomEmail();
|
|
|
|
for (let i = 0; i < count; i++) {
|
|
const workflow = new WorkflowEntity();
|
|
Object.assign(workflow, {
|
|
id: i + 1,
|
|
name: randomName(),
|
|
active: true,
|
|
createdAt: new Date(),
|
|
updatedAt: new Date(),
|
|
nodes: [
|
|
{
|
|
parameters: {
|
|
rule: {
|
|
interval: [{}],
|
|
},
|
|
},
|
|
id: uuid(),
|
|
name: 'Schedule Trigger',
|
|
type: 'n8n-nodes-base.scheduleTrigger',
|
|
typeVersion: 1,
|
|
position: [900, 460],
|
|
},
|
|
],
|
|
connections: {},
|
|
tags: [],
|
|
});
|
|
const sharedWorkflow = new SharedWorkflow();
|
|
sharedWorkflow.workflowId = workflow.id;
|
|
sharedWorkflow.role = ownerRole;
|
|
sharedWorkflow.user = owner;
|
|
|
|
workflow.shared = [sharedWorkflow];
|
|
|
|
workflows.push(workflow);
|
|
}
|
|
databaseActiveWorkflowsList = workflows;
|
|
return workflows;
|
|
};
|
|
|
|
const MOCK_NODE_TYPES_DATA = Helpers.mockNodeTypesData(['scheduleTrigger'], {
|
|
addTrigger: true,
|
|
});
|
|
|
|
jest.mock('@/Db', () => {
|
|
return {
|
|
collections: {
|
|
Workflow: {
|
|
find: jest.fn(async () => Promise.resolve(generateWorkflows(databaseActiveWorkflowsCount))),
|
|
findOne: jest.fn(async (searchParams) => {
|
|
const foundWorkflow = databaseActiveWorkflowsList.find(
|
|
(workflow) => workflow.id.toString() === searchParams.where.id.toString(),
|
|
);
|
|
return Promise.resolve(foundWorkflow);
|
|
}),
|
|
update: jest.fn(),
|
|
createQueryBuilder: jest.fn(() => {
|
|
const fakeQueryBuilder = {
|
|
update: () => fakeQueryBuilder,
|
|
set: () => fakeQueryBuilder,
|
|
where: () => fakeQueryBuilder,
|
|
execute: () => Promise.resolve(),
|
|
};
|
|
return fakeQueryBuilder;
|
|
}),
|
|
},
|
|
Webhook: {
|
|
clear: jest.fn(),
|
|
delete: jest.fn(),
|
|
},
|
|
Variables: {
|
|
find: jest.fn(() => []),
|
|
},
|
|
},
|
|
};
|
|
});
|
|
|
|
const workflowCheckIfCanBeActivated = jest.fn(() => true);
|
|
|
|
jest
|
|
.spyOn(Workflow.prototype, 'checkIfWorkflowCanBeActivated')
|
|
.mockImplementation(workflowCheckIfCanBeActivated);
|
|
|
|
const removeFunction = jest.spyOn(ActiveWorkflowRunner.prototype, 'remove');
|
|
const removeWebhooksFunction = jest.spyOn(ActiveWorkflowRunner.prototype, 'removeWorkflowWebhooks');
|
|
const workflowRunnerRun = jest.spyOn(WorkflowRunner.prototype, 'run');
|
|
const workflowExecuteAdditionalDataExecuteErrorWorkflowSpy = jest.spyOn(
|
|
WorkflowExecuteAdditionalData,
|
|
'executeErrorWorkflow',
|
|
);
|
|
|
|
describe('ActiveWorkflowRunner', () => {
|
|
let externalHooks: ExternalHooks;
|
|
let activeWorkflowRunner: ActiveWorkflowRunner;
|
|
|
|
beforeAll(async () => {
|
|
LoggerProxy.init(getLogger());
|
|
const nodesAndCredentials: INodesAndCredentials = {
|
|
loaded: {
|
|
nodes: MOCK_NODE_TYPES_DATA,
|
|
credentials: {},
|
|
},
|
|
known: { nodes: {}, credentials: {} },
|
|
credentialTypes: {} as ICredentialTypes,
|
|
};
|
|
Container.set(LoadNodesAndCredentials, nodesAndCredentials);
|
|
mockInstance(Push);
|
|
});
|
|
|
|
beforeEach(() => {
|
|
externalHooks = mock();
|
|
activeWorkflowRunner = new ActiveWorkflowRunner(
|
|
new ActiveExecutions(),
|
|
externalHooks,
|
|
Container.get(NodeTypes),
|
|
);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await activeWorkflowRunner.removeAll();
|
|
databaseActiveWorkflowsCount = 0;
|
|
databaseActiveWorkflowsList = [];
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
test('Should initialize activeWorkflowRunner with empty list of active workflows and call External Hooks', async () => {
|
|
await activeWorkflowRunner.init();
|
|
expect(await activeWorkflowRunner.getActiveWorkflows()).toHaveLength(0);
|
|
expect(mocked(Db.collections.Workflow.find)).toHaveBeenCalled();
|
|
expect(mocked(Db.collections.Webhook.clear)).toHaveBeenCalled();
|
|
expect(externalHooks.run).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('Should initialize activeWorkflowRunner with one active workflow', async () => {
|
|
databaseActiveWorkflowsCount = 1;
|
|
await activeWorkflowRunner.init();
|
|
expect(await activeWorkflowRunner.getActiveWorkflows()).toHaveLength(
|
|
databaseActiveWorkflowsCount,
|
|
);
|
|
expect(mocked(Db.collections.Workflow.find)).toHaveBeenCalled();
|
|
expect(mocked(Db.collections.Webhook.clear)).toHaveBeenCalled();
|
|
expect(externalHooks.run).toHaveBeenCalled();
|
|
});
|
|
|
|
test('Should make sure function checkIfWorkflowCanBeActivated was called for every workflow', async () => {
|
|
databaseActiveWorkflowsCount = 2;
|
|
await activeWorkflowRunner.init();
|
|
expect(workflowCheckIfCanBeActivated).toHaveBeenCalledTimes(databaseActiveWorkflowsCount);
|
|
});
|
|
|
|
test('Call to removeAll should remove every workflow', async () => {
|
|
databaseActiveWorkflowsCount = 2;
|
|
await activeWorkflowRunner.init();
|
|
expect(await activeWorkflowRunner.getActiveWorkflows()).toHaveLength(
|
|
databaseActiveWorkflowsCount,
|
|
);
|
|
await activeWorkflowRunner.removeAll();
|
|
expect(removeFunction).toHaveBeenCalledTimes(databaseActiveWorkflowsCount);
|
|
});
|
|
|
|
test('Call to remove should also call removeWorkflowWebhooks', async () => {
|
|
databaseActiveWorkflowsCount = 1;
|
|
await activeWorkflowRunner.init();
|
|
expect(await activeWorkflowRunner.getActiveWorkflows()).toHaveLength(
|
|
databaseActiveWorkflowsCount,
|
|
);
|
|
await activeWorkflowRunner.remove('1');
|
|
expect(removeWebhooksFunction).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('Call to isActive should return true for valid workflow', async () => {
|
|
databaseActiveWorkflowsCount = 1;
|
|
await activeWorkflowRunner.init();
|
|
expect(await activeWorkflowRunner.isActive('1')).toBe(true);
|
|
});
|
|
|
|
test('Call to isActive should return false for invalid workflow', async () => {
|
|
databaseActiveWorkflowsCount = 1;
|
|
await activeWorkflowRunner.init();
|
|
expect(await activeWorkflowRunner.isActive('2')).toBe(false);
|
|
});
|
|
|
|
test('Calling add should call checkIfWorkflowCanBeActivated', async () => {
|
|
// Initialize with default (0) workflows
|
|
await activeWorkflowRunner.init();
|
|
generateWorkflows(1);
|
|
await activeWorkflowRunner.add('1', 'activate');
|
|
expect(workflowCheckIfCanBeActivated).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('runWorkflow should call run method in WorkflowRunner', async () => {
|
|
await activeWorkflowRunner.init();
|
|
const workflow = generateWorkflows(1);
|
|
const additionalData = await WorkflowExecuteAdditionalData.getBase('fake-user-id');
|
|
|
|
workflowRunnerRun.mockImplementationOnce(() => Promise.resolve('invalid-execution-id'));
|
|
|
|
await activeWorkflowRunner.runWorkflow(
|
|
workflow[0],
|
|
workflow[0].nodes[0],
|
|
[[]],
|
|
additionalData,
|
|
'trigger',
|
|
);
|
|
|
|
expect(workflowRunnerRun).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('executeErrorWorkflow should call function with same name in WorkflowExecuteAdditionalData', async () => {
|
|
const workflowData = generateWorkflows(1)[0];
|
|
const error = new NodeOperationError(workflowData.nodes[0], 'Fake error message');
|
|
await activeWorkflowRunner.init();
|
|
activeWorkflowRunner.executeErrorWorkflow(error, workflowData, 'trigger');
|
|
expect(workflowExecuteAdditionalDataExecuteErrorWorkflowSpy).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|