mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-10 22:54:05 -08:00
1d27a9e87e
* Add path mapping and response error interfaces * Add error handling and throwing functionality * Refactor error handling into a single function * Re-implement error handling in Hacker News node * Fix linting details * Re-implement error handling in Spotify node * Re-implement error handling in G Suite Admin node * 🚧 create basic setup NodeError * 🚧 add httpCodes * 🚧 add path priolist * 🚧 handle statusCode in error, adjust interfaces * 🚧 fixing type issues w/Ivan * 🚧 add error exploration * 👔 fix linter issues * 🔧 improve object check * 🚧 remove path passing from NodeApiError * 🚧 add multi error + refactor findProperty method * 👔 allow any * 🔧 handle multi error message callback * ⚡ change return type of callback * ⚡ add customCallback to MultiError * 🚧 refactor to use INode * 🔨 handle arrays, continue search after first null property found * 🚫 refactor method access * 🚧 setup NodeErrorView * ⚡ change timestamp to Date.now * 📚 Add documentation for methods and constants * 🚧 change message setting * 🚚 move NodeErrors to workflow * ✨ add new ErrorView for Nodes * 🎨 improve error notification * 🎨 refactor interfaces * ⚡ add WorkflowOperationError, refactor error throwing * 👕 fix linter issues * 🎨 rename param * 🐛 fix handling normal errors * ⚡ add usage of NodeApiError * 🎨 fix throw new error instead of constructor * 🎨 remove unnecessary code/comments * 🎨 adjusted spacing + updated status messages * 🎨 fix tab indentation * ✨ Replace current errors with custom errors (#1576) * ⚡ Introduce NodeApiError in catch blocks * ⚡ Introduce NodeOperationError in nodes * ⚡ Add missing errors and remove incompatible * ⚡ Fix NodeOperationError in incompatible nodes * 🔧 Adjust error handling in missed nodes PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes * 🔨 Adjust Strava Trigger node error handling * 🔨 Adjust AWS nodes error handling * 🔨 Remove duplicate instantiation of NodeApiError * 🐛 fix strava trigger node error handling * Add XML parsing to NodeApiError constructor (#1633) * 🐛 Remove type annotation from catch variable * ✨ Add XML parsing to NodeApiError * ⚡ Simplify error handling in Rekognition node * ⚡ Pass in XML flag in generic functions * 🔥 Remove try/catch wrappers at call sites * 🔨 Refactor setting description from XML * 🔨 Refactor let to const in resource loaders * ⚡ Find property in parsed XML * ⚡ Change let to const * 🔥 Remove unneeded try/catch block * 👕 Fix linting issues * 🐛 Fix errors from merge conflict resolution * ⚡ Add custom errors to latest contributions * 👕 Fix linting issues * ⚡ Refactor MongoDB helpers for custom errors * 🐛 Correct custom error type * ⚡ Apply feedback to A nodes * ⚡ Apply feedback to missed A node * ⚡ Apply feedback to B-D nodes * ⚡ Apply feedback to E-F nodes * ⚡ Apply feedback to G nodes * ⚡ Apply feedback to H-L nodes * ⚡ Apply feedback to M nodes * ⚡ Apply feedback to P nodes * ⚡ Apply feedback to R nodes * ⚡ Apply feedback to S nodes * ⚡ Apply feedback to T nodes * ⚡ Apply feedback to V-Z nodes * ⚡ Add HTTP code to iterable node error * 🔨 Standardize e as error * 🔨 Standardize err as error * ⚡ Fix error handling for non-standard nodes Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
386 lines
8.3 KiB
TypeScript
386 lines
8.3 KiB
TypeScript
import {
|
|
IExecuteFunctions,
|
|
} from 'n8n-core';
|
|
|
|
import {
|
|
IDataObject,
|
|
INodeExecutionData,
|
|
INodeType,
|
|
INodeTypeDescription,
|
|
NodeOperationError,
|
|
} from 'n8n-workflow';
|
|
|
|
import {
|
|
hackerNewsApiRequest,
|
|
hackerNewsApiRequestAllItems,
|
|
} from './GenericFunctions';
|
|
|
|
export class HackerNews implements INodeType {
|
|
description: INodeTypeDescription = {
|
|
displayName: 'Hacker News',
|
|
name: 'hackerNews',
|
|
icon: 'file:hackernews.png',
|
|
group: ['transform'],
|
|
version: 1,
|
|
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
|
|
description: 'Consume Hacker News API',
|
|
defaults: {
|
|
name: 'Hacker News',
|
|
color: '#ff6600',
|
|
},
|
|
inputs: ['main'],
|
|
outputs: ['main'],
|
|
properties: [
|
|
// ----------------------------------
|
|
// Resources
|
|
// ----------------------------------
|
|
{
|
|
displayName: 'Resource',
|
|
name: 'resource',
|
|
type: 'options',
|
|
options: [
|
|
{
|
|
name: 'All',
|
|
value: 'all',
|
|
},
|
|
{
|
|
name: 'Article',
|
|
value: 'article',
|
|
},
|
|
{
|
|
name: 'User',
|
|
value: 'user',
|
|
},
|
|
],
|
|
default: 'article',
|
|
description: 'Resource to consume.',
|
|
},
|
|
|
|
|
|
// ----------------------------------
|
|
// Operations
|
|
// ----------------------------------
|
|
{
|
|
displayName: 'Operation',
|
|
name: 'operation',
|
|
type: 'options',
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'all',
|
|
],
|
|
},
|
|
},
|
|
options: [
|
|
{
|
|
name: 'Get All',
|
|
value: 'getAll',
|
|
description: 'Get all items',
|
|
},
|
|
],
|
|
default: 'getAll',
|
|
description: 'Operation to perform.',
|
|
},
|
|
{
|
|
displayName: 'Operation',
|
|
name: 'operation',
|
|
type: 'options',
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'article',
|
|
],
|
|
},
|
|
},
|
|
options: [
|
|
{
|
|
name: 'Get',
|
|
value: 'get',
|
|
description: 'Get a Hacker News article',
|
|
},
|
|
],
|
|
default: 'get',
|
|
description: 'Operation to perform.',
|
|
},
|
|
{
|
|
displayName: 'Operation',
|
|
name: 'operation',
|
|
type: 'options',
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'user',
|
|
],
|
|
},
|
|
},
|
|
options: [
|
|
{
|
|
name: 'Get',
|
|
value: 'get',
|
|
description: 'Get a Hacker News user',
|
|
},
|
|
],
|
|
default: 'get',
|
|
description: 'Operation to perform.',
|
|
},
|
|
// ----------------------------------
|
|
// Fields
|
|
// ----------------------------------
|
|
{
|
|
displayName: 'Article ID',
|
|
name: 'articleId',
|
|
type: 'string',
|
|
required: true,
|
|
default: '',
|
|
description: 'The ID of the Hacker News article to be returned',
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'article',
|
|
],
|
|
operation: [
|
|
'get',
|
|
],
|
|
},
|
|
},
|
|
},
|
|
{
|
|
displayName: 'Username',
|
|
name: 'username',
|
|
type: 'string',
|
|
required: true,
|
|
default: '',
|
|
description: 'The Hacker News user to be returned',
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'user',
|
|
],
|
|
operation: [
|
|
'get',
|
|
],
|
|
},
|
|
},
|
|
},
|
|
{
|
|
displayName: 'Return All',
|
|
name: 'returnAll',
|
|
type: 'boolean',
|
|
default: false,
|
|
description: 'Whether to return all results for the query or only up to a limit.',
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'all',
|
|
],
|
|
operation: [
|
|
'getAll',
|
|
],
|
|
},
|
|
},
|
|
},
|
|
{
|
|
displayName: 'Limit',
|
|
name: 'limit',
|
|
type: 'number',
|
|
default: 100,
|
|
description: 'Limit of Hacker News articles to be returned for the query.',
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'all',
|
|
],
|
|
operation: [
|
|
'getAll',
|
|
],
|
|
returnAll: [
|
|
false,
|
|
],
|
|
},
|
|
},
|
|
},
|
|
{
|
|
displayName: 'Additional Fields',
|
|
name: 'additionalFields',
|
|
type: 'collection',
|
|
placeholder: 'Add Field',
|
|
default: {},
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'article',
|
|
],
|
|
operation: [
|
|
'get',
|
|
],
|
|
},
|
|
},
|
|
options: [
|
|
{
|
|
displayName: 'Include comments',
|
|
name: 'includeComments',
|
|
type: 'boolean',
|
|
default: false,
|
|
description: 'Whether to include all the comments in a Hacker News article.',
|
|
},
|
|
],
|
|
},
|
|
{
|
|
displayName: 'Additional Fields',
|
|
name: 'additionalFields',
|
|
type: 'collection',
|
|
placeholder: 'Add Field',
|
|
default: {},
|
|
displayOptions: {
|
|
show: {
|
|
resource: [
|
|
'all',
|
|
],
|
|
operation: [
|
|
'getAll',
|
|
],
|
|
},
|
|
},
|
|
options: [
|
|
{
|
|
displayName: 'Keyword',
|
|
name: 'keyword',
|
|
type: 'string',
|
|
default: '',
|
|
description: 'The keyword for filtering the results of the query.',
|
|
},
|
|
{
|
|
displayName: 'Tags',
|
|
name: 'tags',
|
|
type: 'multiOptions',
|
|
options: [
|
|
{
|
|
name: 'Story',
|
|
value: 'story',
|
|
description: 'Returns query results filtered by story tag',
|
|
},
|
|
{
|
|
name: 'Comment',
|
|
value: 'comment',
|
|
description: 'Returns query results filtered by comment tag',
|
|
},
|
|
{
|
|
name: 'Poll',
|
|
value: 'poll',
|
|
description: 'Returns query results filtered by poll tag',
|
|
},
|
|
{
|
|
name: 'Show HN',
|
|
value: 'show_hn', // snake case per HN tags
|
|
description: 'Returns query results filtered by Show HN tag',
|
|
},
|
|
{
|
|
name: 'Ask HN',
|
|
value: 'ask_hn', // snake case per HN tags
|
|
description: 'Returns query results filtered by Ask HN tag',
|
|
},
|
|
{
|
|
name: 'Front Page',
|
|
value: 'front_page', // snake case per HN tags
|
|
description: 'Returns query results filtered by Front Page tag',
|
|
},
|
|
],
|
|
default: '',
|
|
description: 'Tags for filtering the results of the query.',
|
|
},
|
|
],
|
|
},
|
|
],
|
|
};
|
|
|
|
|
|
async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
|
|
const items = this.getInputData();
|
|
const returnData: IDataObject[] = [];
|
|
|
|
const resource = this.getNodeParameter('resource', 0) as string;
|
|
const operation = this.getNodeParameter('operation', 0) as string;
|
|
let returnAll = false;
|
|
|
|
for (let i = 0; i < items.length; i++) {
|
|
|
|
let qs: IDataObject = {};
|
|
let endpoint = '';
|
|
let includeComments = false;
|
|
|
|
if (resource === 'all') {
|
|
if (operation === 'getAll') {
|
|
|
|
const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject;
|
|
const keyword = additionalFields.keyword as string;
|
|
const tags = additionalFields.tags as string[];
|
|
|
|
qs = {
|
|
query: keyword,
|
|
tags: tags ? tags.join() : '',
|
|
};
|
|
|
|
returnAll = this.getNodeParameter('returnAll', i) as boolean;
|
|
|
|
if (!returnAll) {
|
|
qs.hitsPerPage = this.getNodeParameter('limit', i) as number;
|
|
}
|
|
|
|
endpoint = 'search?';
|
|
|
|
} else {
|
|
throw new NodeOperationError(this.getNode(), `The operation '${operation}' is unknown!`);
|
|
}
|
|
} else if (resource === 'article') {
|
|
|
|
if (operation === 'get') {
|
|
|
|
endpoint = `items/${this.getNodeParameter('articleId', i)}`;
|
|
const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject;
|
|
includeComments = additionalFields.includeComments as boolean;
|
|
|
|
} else {
|
|
throw new NodeOperationError(this.getNode(), `The operation '${operation}' is unknown!`);
|
|
}
|
|
|
|
} else if (resource === 'user') {
|
|
|
|
if (operation === 'get') {
|
|
endpoint = `users/${this.getNodeParameter('username', i)}`;
|
|
|
|
} else {
|
|
throw new NodeOperationError(this.getNode(), `The operation '${operation}' is unknown!`);
|
|
}
|
|
|
|
} else {
|
|
throw new NodeOperationError(this.getNode(), `The resource '${resource}' is unknown!`);
|
|
}
|
|
|
|
|
|
let responseData;
|
|
if (returnAll === true) {
|
|
responseData = await hackerNewsApiRequestAllItems.call(this, 'GET', endpoint, qs);
|
|
} else {
|
|
responseData = await hackerNewsApiRequest.call(this, 'GET', endpoint, qs);
|
|
if (resource === 'all' && operation === 'getAll') {
|
|
responseData = responseData.hits;
|
|
}
|
|
}
|
|
|
|
if (resource === 'article' && operation === 'get' && !includeComments) {
|
|
delete responseData.children;
|
|
}
|
|
|
|
if (Array.isArray(responseData)) {
|
|
returnData.push.apply(returnData, responseData as IDataObject[]);
|
|
} else {
|
|
returnData.push(responseData as IDataObject);
|
|
}
|
|
|
|
}
|
|
|
|
return [this.helpers.returnJsonArray(returnData)];
|
|
|
|
}
|
|
}
|