n8n/packages/nodes-base
Ricardo Espinoza a169b74062
fix(Redis Trigger Node): Activating a workflow with a Redis trigger fails (#8129)
## Summary
> Describe what the PR does and how to test. Photos and videos are
recommended.

We were awaiting for the promise to resolve before returning. Because
the trigger method does not return until the first message is received
or the connection errors, the requests that actives the workflows did
not respond making the activation button irresponsive.

Without the change:

https://www.loom.com/share/769b26d5d4ee407e999344fab3905eae

With the change:

https://www.loom.com/share/d1691ee1941248bc97f2ed97b0c129a3

## Related tickets and issues

https://linear.app/n8n/issue/ADO-895/activating-a-workflow-with-a-redis-trigger-fails


## Review / Merge checklist
- [x] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
2023-12-21 12:29:26 -05:00
..
credentials refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914) 2023-12-05 11:17:08 +01:00
nodes fix(Redis Trigger Node): Activating a workflow with a Redis trigger fails (#8129) 2023-12-21 12:29:26 -05:00
scripts
test refactor(Peekalink Node): Stricter typing for Peekalink api call + Tests (no-changelog) (#8125) 2023-12-21 18:22:32 +01:00
utils refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914) 2023-12-05 11:17:08 +01:00
.eslintrc.js refactor(Peekalink Node): Stricter typing for Peekalink api call + Tests (no-changelog) (#8125) 2023-12-21 18:22:32 +01:00
gulpfile.js
index.js
jest.config.js refactor(core): Abstract away InstanceSettings and encryptionKey into injectable services (no-changelog) (#7471) 2023-10-23 13:39:35 +02:00
LICENSE.md
LICENSE_EE.md
package.json feat(Snowflake Node): Update snowflake-sdk (no-changelog) (#8087) 2023-12-21 14:52:54 +01:00
README.md docs: Replace http://faircode.io to https://faircode.io in .md files (#7908) 2023-12-12 15:23:22 +00:00
tsconfig.build.json ci: Fix typescript incremental builds (no-changelog) (#7275) 2023-09-29 13:26:06 +02:00
tsconfig.json ci: Fix typescript incremental builds (no-changelog) (#7275) 2023-09-29 13:26:06 +02:00

n8n.io - Workflow Automation

n8n-nodes-base

The nodes which are included by default in n8n

npm install n8n-nodes-base -g

License

n8n is fair-code distributed under the Sustainable Use License.

Proprietary licenses are available for enterprise customers. Get in touch

Additional information about the license can be found in the docs.