mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-27 21:49:41 -08:00
e01b9e5ae1
This is related to an issue with how Bull handles stalled jobs, see https://github.com/OptimalBits/bull/issues/1415 for reference. CPU intensive workflows can in certain cases take a long while to finish up, thereby blocking the thread and causing Bull queue to think the job has stalled, even though it finished successfully. In these cases the error handling could then overwrite the successful execution data with the error message.
84 lines
2.3 KiB
TypeScript
84 lines
2.3 KiB
TypeScript
import type { User } from '@db/entities/User';
|
|
import * as testDb from '../integration/shared/testDb';
|
|
import * as utils from '../integration/shared/utils/';
|
|
import { createWorkflow, createExecution } from '../integration/shared/testDb';
|
|
import { WorkflowRunner } from '@/WorkflowRunner';
|
|
import { WorkflowHooks, type ExecutionError, type IWorkflowExecuteHooks } from 'n8n-workflow';
|
|
import { Push } from '../../src/push';
|
|
import { mockInstance } from '../integration/shared/utils';
|
|
import Container from 'typedi';
|
|
import config from '../../src/config';
|
|
|
|
let owner: User;
|
|
let runner: WorkflowRunner;
|
|
let hookFunctions: IWorkflowExecuteHooks;
|
|
utils.setupTestServer({ endpointGroups: [] });
|
|
|
|
class Watchers {
|
|
workflowExecuteAfter = jest.fn();
|
|
}
|
|
const watchers = new Watchers();
|
|
const watchedWorkflowExecuteAfter = jest.spyOn(watchers, 'workflowExecuteAfter');
|
|
|
|
beforeAll(async () => {
|
|
const globalOwnerRole = await testDb.getGlobalOwnerRole();
|
|
owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
mockInstance(Push);
|
|
Container.set(Push, new Push());
|
|
|
|
runner = new WorkflowRunner();
|
|
|
|
hookFunctions = {
|
|
workflowExecuteAfter: [watchers.workflowExecuteAfter],
|
|
};
|
|
});
|
|
|
|
afterAll(() => {
|
|
jest.restoreAllMocks();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await testDb.truncate(['Workflow', 'SharedWorkflow']);
|
|
});
|
|
|
|
test('processError should return early in Bull stalled edge case', async () => {
|
|
const workflow = await createWorkflow({}, owner);
|
|
const execution = await createExecution(
|
|
{
|
|
status: 'success',
|
|
finished: true,
|
|
},
|
|
workflow,
|
|
);
|
|
config.set('executions.mode', 'queue');
|
|
await runner.processError(
|
|
new Error('test') as ExecutionError,
|
|
new Date(),
|
|
'webhook',
|
|
execution.id,
|
|
new WorkflowHooks(hookFunctions, 'webhook', execution.id, workflow),
|
|
);
|
|
expect(watchedWorkflowExecuteAfter).toHaveBeenCalledTimes(0);
|
|
});
|
|
|
|
test('processError should process error', async () => {
|
|
const workflow = await createWorkflow({}, owner);
|
|
const execution = await createExecution(
|
|
{
|
|
status: 'success',
|
|
finished: true,
|
|
},
|
|
workflow,
|
|
);
|
|
config.set('executions.mode', 'regular');
|
|
await runner.processError(
|
|
new Error('test') as ExecutionError,
|
|
new Date(),
|
|
'webhook',
|
|
execution.id,
|
|
new WorkflowHooks(hookFunctions, 'webhook', execution.id, workflow),
|
|
);
|
|
expect(watchedWorkflowExecuteAfter).toHaveBeenCalledTimes(1);
|
|
});
|