n8n/packages/nodes-base/nodes/Yourls/GenericFunctions.ts
Michael Kret b201ff8f23
fix(Nextcloud Node): Throw an actual error if server responded with Fatal error (#8234)
## Summary
Nextcloud and Yourls receiving response with OK status as string
containing 'Fatal error', throw an actual error in such case

![image](https://github.com/n8n-io/n8n/assets/88898367/7cba4b8c-3b34-476f-8a35-e10738022427)

## Related tickets and issues

https://linear.app/n8n/issue/NODE-1035/nextcloud-and-yourls-throw-an-actual-error-if-server-responded-with
2024-01-05 12:13:29 +02:00

55 lines
1.2 KiB
TypeScript

import type { OptionsWithUri } from 'request';
import type {
IExecuteFunctions,
ILoadOptionsFunctions,
IDataObject,
JsonObject,
} from 'n8n-workflow';
import { NodeApiError, NodeOperationError } from 'n8n-workflow';
export async function yourlsApiRequest(
this: IExecuteFunctions | ILoadOptionsFunctions,
method: string,
body: any = {},
qs: IDataObject = {},
): Promise<any> {
const credentials = await this.getCredentials('yourlsApi');
qs.signature = credentials.signature as string;
qs.format = 'json';
const options: OptionsWithUri = {
method,
body,
qs,
uri: `${credentials.url}/yourls-api.php`,
json: true,
};
try {
const response = await this.helpers.request.call(this, options);
if (response.status === 'fail') {
throw new NodeOperationError(
this.getNode(),
`Yourls error response [400]: ${response.message}`,
);
}
if (typeof response === 'string' && response.includes('<b>Fatal error</b>')) {
throw new NodeOperationError(
this.getNode(),
"Yourls responded with a 'Fatal error', check description for more details",
{
description: `Server response:\n${response}`,
},
);
}
return response;
} catch (error) {
throw new NodeApiError(this.getNode(), error as JsonObject);
}
}