mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-10 22:54:05 -08:00
561882f599
* refactor(core): Avoid fetching all workflows and credentials for the owner setup screen * refactor(core): Add unit tests for the owner controller
135 lines
5.1 KiB
TypeScript
135 lines
5.1 KiB
TypeScript
import type { Repository } from 'typeorm';
|
|
import type { CookieOptions, Response } from 'express';
|
|
import { anyObject, captor, mock } from 'jest-mock-extended';
|
|
import type { ILogger } from 'n8n-workflow';
|
|
import jwt from 'jsonwebtoken';
|
|
import type { ICredentialsDb, IInternalHooksClass } from '@/Interfaces';
|
|
import type { User } from '@db/entities/User';
|
|
import type { Settings } from '@db/entities/Settings';
|
|
import type { WorkflowEntity } from '@db/entities/WorkflowEntity';
|
|
import type { Config } from '@/config';
|
|
import { BadRequestError } from '@/ResponseHelper';
|
|
import type { OwnerRequest } from '@/requests';
|
|
import { OwnerController } from '@/controllers';
|
|
import { badPasswords } from '../shared/testData';
|
|
import { AUTH_COOKIE_NAME } from '@/constants';
|
|
|
|
describe('OwnerController', () => {
|
|
const config = mock<Config>();
|
|
const logger = mock<ILogger>();
|
|
const internalHooks = mock<IInternalHooksClass>();
|
|
const userRepository = mock<Repository<User>>();
|
|
const settingsRepository = mock<Repository<Settings>>();
|
|
const credentialsRepository = mock<Repository<ICredentialsDb>>();
|
|
const workflowsRepository = mock<Repository<WorkflowEntity>>();
|
|
const controller = new OwnerController({
|
|
config,
|
|
logger,
|
|
internalHooks,
|
|
repositories: {
|
|
User: userRepository,
|
|
Settings: settingsRepository,
|
|
Credentials: credentialsRepository,
|
|
Workflow: workflowsRepository,
|
|
},
|
|
});
|
|
|
|
describe('preSetup', () => {
|
|
it('should throw a BadRequestError if the instance owner is already setup', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(true);
|
|
expect(controller.preSetup()).rejects.toThrowError(
|
|
new BadRequestError('Instance owner already setup'),
|
|
);
|
|
});
|
|
|
|
it('should a return credential and workflow count', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
credentialsRepository.countBy.mockResolvedValue(7);
|
|
workflowsRepository.countBy.mockResolvedValue(31);
|
|
const { credentials, workflows } = await controller.preSetup();
|
|
expect(credentials).toBe(7);
|
|
expect(workflows).toBe(31);
|
|
});
|
|
});
|
|
|
|
describe('setupOwner', () => {
|
|
it('should throw a BadRequestError if the instance owner is already setup', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(true);
|
|
expect(controller.setupOwner(mock(), mock())).rejects.toThrowError(
|
|
new BadRequestError('Instance owner already setup'),
|
|
);
|
|
});
|
|
|
|
it('should throw a BadRequestError if the email is invalid', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
const req = mock<OwnerRequest.Post>({ body: { email: 'invalid email' } });
|
|
expect(controller.setupOwner(req, mock())).rejects.toThrowError(
|
|
new BadRequestError('Invalid email address'),
|
|
);
|
|
});
|
|
|
|
describe('should throw if the password is invalid', () => {
|
|
Object.entries(badPasswords).forEach(([password, errorMessage]) => {
|
|
it(password, async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
const req = mock<OwnerRequest.Post>({ body: { email: 'valid@email.com', password } });
|
|
expect(controller.setupOwner(req, mock())).rejects.toThrowError(
|
|
new BadRequestError(errorMessage),
|
|
);
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should throw a BadRequestError if firstName & lastName are missing ', async () => {
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
const req = mock<OwnerRequest.Post>({
|
|
body: { email: 'valid@email.com', password: 'NewPassword123', firstName: '', lastName: '' },
|
|
});
|
|
expect(controller.setupOwner(req, mock())).rejects.toThrowError(
|
|
new BadRequestError('First and last names are mandatory'),
|
|
);
|
|
});
|
|
|
|
it('should setup the instance owner successfully', async () => {
|
|
const user = mock<User>({
|
|
id: 'userId',
|
|
globalRole: { scope: 'global', name: 'owner' },
|
|
authIdentities: [],
|
|
});
|
|
const req = mock<OwnerRequest.Post>({
|
|
body: {
|
|
email: 'valid@email.com',
|
|
password: 'NewPassword123',
|
|
firstName: 'Jane',
|
|
lastName: 'Doe',
|
|
},
|
|
user,
|
|
});
|
|
const res = mock<Response>();
|
|
config.getEnv.calledWith('userManagement.isInstanceOwnerSetUp').mockReturnValue(false);
|
|
userRepository.save.calledWith(anyObject()).mockResolvedValue(user);
|
|
jest.spyOn(jwt, 'sign').mockImplementation(() => 'signed-token');
|
|
|
|
await controller.setupOwner(req, res);
|
|
|
|
expect(userRepository.save).toHaveBeenCalledWith(user);
|
|
|
|
const cookieOptions = captor<CookieOptions>();
|
|
expect(res.cookie).toHaveBeenCalledWith(AUTH_COOKIE_NAME, 'signed-token', cookieOptions);
|
|
expect(cookieOptions.value.httpOnly).toBe(true);
|
|
expect(cookieOptions.value.sameSite).toBe('lax');
|
|
});
|
|
});
|
|
|
|
describe('skipSetup', () => {
|
|
it('should skip setting up the instance owner', async () => {
|
|
await controller.skipSetup();
|
|
expect(settingsRepository.update).toHaveBeenCalledWith(
|
|
{ key: 'userManagement.skipInstanceOwnerSetup' },
|
|
{ value: JSON.stringify(true) },
|
|
);
|
|
expect(config.set).toHaveBeenCalledWith('userManagement.skipInstanceOwnerSetup', true);
|
|
});
|
|
});
|
|
});
|