mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-12 23:54:07 -08:00
e4f041815a
* refactor: Create `RoleService` * refactor: Refactor to use service * refactor: Move `getUserRoleForWorkflow` * refactor: Clear out old `RoleService` * refactor: Consolidate utils into service * refactor: Remove unused methods * test: Add tests * refactor: Remove redundant return types * refactor: Missing utility * chore: Remove commented out bit * refactor: Make `Db.collections.Repository` inaccessible * chore: Cleanup * feat: Prepopulate cache * chore: Remove logging * fix: Account for tests where roles are undefined * fix: Restore `prettier.prettierPath` * test: Account for cache enabled and disabled * fix: Restore `Role` in `Db.collections` * refactor: Simplify by removing `orFail` * refactor: Rename for clarity * refactor: Use `cacheKey` for readability * refactor: Validate role before creation * refacator: Remove redundant `cache` prefix * ci: Lint fix * test: Fix e2e
70 lines
2.3 KiB
TypeScript
70 lines
2.3 KiB
TypeScript
import { OwnershipService } from '@/services/ownership.service';
|
|
import { SharedWorkflowRepository, UserRepository } from '@/databases/repositories';
|
|
import { mockInstance } from '../../integration/shared/utils';
|
|
import { Role } from '@/databases/entities/Role';
|
|
import { randomInteger } from '../../integration/shared/random';
|
|
import { SharedWorkflow } from '@/databases/entities/SharedWorkflow';
|
|
import { CacheService } from '@/services/cache.service';
|
|
import { User } from '@/databases/entities/User';
|
|
import { RoleService } from '@/services/role.service';
|
|
|
|
const wfOwnerRole = () =>
|
|
Object.assign(new Role(), {
|
|
scope: 'workflow',
|
|
name: 'owner',
|
|
id: randomInteger(),
|
|
});
|
|
|
|
describe('OwnershipService', () => {
|
|
const cacheService = mockInstance(CacheService);
|
|
const roleService = mockInstance(RoleService);
|
|
const userRepository = mockInstance(UserRepository);
|
|
const sharedWorkflowRepository = mockInstance(SharedWorkflowRepository);
|
|
|
|
const ownershipService = new OwnershipService(
|
|
cacheService,
|
|
userRepository,
|
|
roleService,
|
|
sharedWorkflowRepository,
|
|
);
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
describe('getWorkflowOwner()', () => {
|
|
test('should retrieve a workflow owner', async () => {
|
|
roleService.findWorkflowOwnerRole.mockResolvedValueOnce(wfOwnerRole());
|
|
|
|
const mockOwner = new User();
|
|
const mockNonOwner = new User();
|
|
|
|
const sharedWorkflow = Object.assign(new SharedWorkflow(), {
|
|
role: new Role(),
|
|
user: mockOwner,
|
|
});
|
|
|
|
sharedWorkflowRepository.findOneOrFail.mockResolvedValueOnce(sharedWorkflow);
|
|
|
|
const returnedOwner = await ownershipService.getWorkflowOwnerCached('some-workflow-id');
|
|
|
|
expect(returnedOwner).toBe(mockOwner);
|
|
expect(returnedOwner).not.toBe(mockNonOwner);
|
|
});
|
|
|
|
test('should throw if no workflow owner role found', async () => {
|
|
roleService.findWorkflowOwnerRole.mockRejectedValueOnce(new Error());
|
|
|
|
await expect(ownershipService.getWorkflowOwnerCached('some-workflow-id')).rejects.toThrow();
|
|
});
|
|
|
|
test('should throw if no workflow owner found', async () => {
|
|
roleService.findWorkflowOwnerRole.mockResolvedValueOnce(wfOwnerRole());
|
|
|
|
sharedWorkflowRepository.findOneOrFail.mockRejectedValue(new Error());
|
|
|
|
await expect(ownershipService.getWorkflowOwnerCached('some-workflow-id')).rejects.toThrow();
|
|
});
|
|
});
|
|
});
|