mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-16 09:34:07 -08:00
b2aba48dfe
* ✨ Added history store and mixin * ✨ Implemented node position change undo/redo * ✨ Implemented move nodes bulk command * ⚡ Not clearing the redo stack after pushing the bulk command * 🔨 Implemented commands using classes * 🔥 Removed unnecessary interfaces and actions * 🔥 Removing unused constants * 🔨 Refactoring classes file * ⚡ Adding eventBus to command obects * ✨ Added undo/redo support for adding and removing nodes * ✨ Implemented initial add/remove connections undo support * ⚡ Covering some corner cases with reconnecting nodes * ⚡ Adding undo support for reconnecting nodes * ⚡ Fixing going back and forward between undo and redo * ✨ Implemented async command revert * ⚡ Preventing push to undo if bulk redo/undo is in progress * ⚡ Handling re-connecting nodes and stopped pushing empty bulk actions to undo stack * ✨ Handling adding a node between two connected nodes * ⚡ Handling the case of removing multiple connections on the same index. Adding debounce to undo/redo keyboard calls * ⚡ Removing unnecessary timeouts, adding missing awaits, refactoring * ⚡ Resetting history when opening new workflow, fixing incorrect bulk recording when inserting node * ✔️ Fixing lint error * ⚡ Minor refactoring + some temporary debugging logs * ⚡ Preserving node properties when undoing it's removal, removing some unused repaint code * ✨ Added undo/redo support for import workflow and node enable/disable * 🔥 Removing some unused constant * ✨ Added undo/redo support for renaming nodes * ⚡ Fixing rename history recording * ✨ Added undo/redo support for duplicating nodes * 📈 Implemented telemetry events * 🔨 A bit of refactoring * ⚡ Fixing edgecases in removing connection and moving nodes * ⚡ Handling case of adding duplicate nodes when going back and forward in history * ⚡ Recording connections added directly to store * ⚡ Moving main history reset after wf is opened * 🔨 Simplifying rename recording * 📈 Adding NDV telemetry event, updating existing event name case * 📈 Updating telemetry events * ⚡ Fixing duplicate connections on undo/redo * ⚡ Stopping undo events from firing constantly on keydown * 📈 Updated telemetry event for hitting undo in NDV * ⚡ Adding undo support for disabling nodes using keyboard shortcuts * ⚡ Preventing adding duplicate connection commands to history * ⚡ Clearing redo stack when new change is added * ⚡ Preventing adding connection actions to undo stack while redoing them * 👌 Addressing PR comments part 1 * 👌 Moving undo logic for disabling nodes to `NodeView` * 👌 Implemented command comparing logic * ⚡ Fix for not clearing redo stack on every user action * ⚡ Fixing recording when moving nodes * ⚡ Fixing undo for moving connections * ⚡ Fixing tracking new nodes after latest merge * ⚡ Fixing broken bulk delete * ⚡ Preventing undo/redo when not on main node view tab * 👌 Addressing PR comments * 👌 Addressing PR comment
373 lines
12 KiB
TypeScript
373 lines
12 KiB
TypeScript
import { PropType } from "vue";
|
|
import mixins from 'vue-typed-mixins';
|
|
import { IJsPlumbInstance, IEndpointOptions, INodeUi, XYPosition } from '@/Interface';
|
|
import { deviceSupportHelpers } from '@/mixins/deviceSupportHelpers';
|
|
import { NO_OP_NODE_TYPE, STICKY_NODE_TYPE } from '@/constants';
|
|
|
|
import {
|
|
INodeTypeDescription,
|
|
} from 'n8n-workflow';
|
|
import { mapStores } from 'pinia';
|
|
import { useUIStore } from '@/stores/ui';
|
|
import { useWorkflowsStore } from "@/stores/workflows";
|
|
import { useNodeTypesStore } from "@/stores/nodeTypes";
|
|
import * as NodeViewUtils from '@/utils/nodeViewUtils';
|
|
import { getStyleTokenValue } from "@/utils";
|
|
import { useHistoryStore } from "@/stores/history";
|
|
import { MoveNodeCommand } from "@/models/history";
|
|
|
|
export const nodeBase = mixins(
|
|
deviceSupportHelpers,
|
|
).extend({
|
|
mounted () {
|
|
// Initialize the node
|
|
if (this.data !== null) {
|
|
try {
|
|
this.__addNode(this.data);
|
|
} catch(error) {
|
|
// This breaks when new nodes are loaded into store but workflow tab is not currently active
|
|
// Shouldn't affect anything
|
|
}
|
|
}
|
|
},
|
|
computed: {
|
|
...mapStores(
|
|
useNodeTypesStore,
|
|
useUIStore,
|
|
useWorkflowsStore,
|
|
useHistoryStore,
|
|
),
|
|
data (): INodeUi | null {
|
|
return this.workflowsStore.getNodeByName(this.name);
|
|
},
|
|
nodeId (): string {
|
|
return this.data?.id || '';
|
|
},
|
|
},
|
|
props: {
|
|
name: {
|
|
type: String,
|
|
},
|
|
instance: {
|
|
type: Object as PropType<IJsPlumbInstance>,
|
|
},
|
|
isReadOnly: {
|
|
type: Boolean,
|
|
},
|
|
isActive: {
|
|
type: Boolean,
|
|
},
|
|
hideActions: {
|
|
type: Boolean,
|
|
},
|
|
disableSelecting: {
|
|
type: Boolean,
|
|
},
|
|
showCustomTooltip: {
|
|
type: Boolean,
|
|
},
|
|
},
|
|
methods: {
|
|
__addInputEndpoints (node: INodeUi, nodeTypeData: INodeTypeDescription) {
|
|
// Add Inputs
|
|
let index;
|
|
const indexData: {
|
|
[key: string]: number;
|
|
} = {};
|
|
|
|
nodeTypeData.inputs.forEach((inputName: string, i: number) => {
|
|
// Increment the index for inputs with current name
|
|
if (indexData.hasOwnProperty(inputName)) {
|
|
indexData[inputName]++;
|
|
} else {
|
|
indexData[inputName] = 0;
|
|
}
|
|
index = indexData[inputName];
|
|
|
|
// Get the position of the anchor depending on how many it has
|
|
const anchorPosition = NodeViewUtils.ANCHOR_POSITIONS.input[nodeTypeData.inputs.length][index];
|
|
|
|
const newEndpointData: IEndpointOptions = {
|
|
uuid:NodeViewUtils. getInputEndpointUUID(this.nodeId, index),
|
|
anchor: anchorPosition,
|
|
maxConnections: -1,
|
|
endpoint: 'Rectangle',
|
|
endpointStyle: NodeViewUtils.getInputEndpointStyle(nodeTypeData, '--color-foreground-xdark'),
|
|
endpointHoverStyle: NodeViewUtils.getInputEndpointStyle(nodeTypeData, '--color-primary'),
|
|
isSource: false,
|
|
isTarget: !this.isReadOnly && nodeTypeData.inputs.length > 1, // only enabled for nodes with multiple inputs.. otherwise attachment handled by connectionDrag event in NodeView,
|
|
parameters: {
|
|
nodeId: this.nodeId,
|
|
type: inputName,
|
|
index,
|
|
},
|
|
enabled: !this.isReadOnly, // enabled in default case to allow dragging
|
|
cssClass: 'rect-input-endpoint',
|
|
dragAllowedWhenFull: true,
|
|
dropOptions: {
|
|
tolerance: 'touch',
|
|
hoverClass: 'dropHover',
|
|
},
|
|
};
|
|
|
|
if (nodeTypeData.inputNames) {
|
|
// Apply input names if they got set
|
|
newEndpointData.overlays = [
|
|
NodeViewUtils.getInputNameOverlay(nodeTypeData.inputNames[index]),
|
|
];
|
|
}
|
|
|
|
const endpoint = this.instance.addEndpoint(this.nodeId, newEndpointData);
|
|
if(!Array.isArray(endpoint)) {
|
|
endpoint.__meta = {
|
|
nodeName: node.name,
|
|
nodeId: this.nodeId,
|
|
index: i,
|
|
totalEndpoints: nodeTypeData.inputs.length,
|
|
};
|
|
}
|
|
|
|
// TODO: Activate again if it makes sense. Currently makes problems when removing
|
|
// connection on which the input has a name. It does not get hidden because
|
|
// the endpoint to which it connects when letting it go over the node is
|
|
// different to the regular one (have different ids). So that seems to make
|
|
// problems when hiding the input-name.
|
|
|
|
// if (index === 0 && inputName === 'main') {
|
|
// // Make the first main-input the default one to connect to when connection gets dropped on node
|
|
// this.instance.makeTarget(this.nodeId, newEndpointData);
|
|
// }
|
|
});
|
|
},
|
|
__addOutputEndpoints(node: INodeUi, nodeTypeData: INodeTypeDescription) {
|
|
let index;
|
|
const indexData: {
|
|
[key: string]: number;
|
|
} = {};
|
|
|
|
nodeTypeData.outputs.forEach((inputName: string, i: number) => {
|
|
// Increment the index for outputs with current name
|
|
if (indexData.hasOwnProperty(inputName)) {
|
|
indexData[inputName]++;
|
|
} else {
|
|
indexData[inputName] = 0;
|
|
}
|
|
index = indexData[inputName];
|
|
|
|
// Get the position of the anchor depending on how many it has
|
|
const anchorPosition = NodeViewUtils.ANCHOR_POSITIONS.output[nodeTypeData.outputs.length][index];
|
|
|
|
const newEndpointData: IEndpointOptions = {
|
|
uuid: NodeViewUtils.getOutputEndpointUUID(this.nodeId, index),
|
|
anchor: anchorPosition,
|
|
maxConnections: -1,
|
|
endpoint: 'Dot',
|
|
endpointStyle: NodeViewUtils.getOutputEndpointStyle(nodeTypeData, '--color-foreground-xdark'),
|
|
endpointHoverStyle: NodeViewUtils.getOutputEndpointStyle(nodeTypeData, '--color-primary'),
|
|
isSource: true,
|
|
isTarget: false,
|
|
enabled: !this.isReadOnly,
|
|
parameters: {
|
|
nodeId: this.nodeId,
|
|
type: inputName,
|
|
index,
|
|
},
|
|
cssClass: 'dot-output-endpoint',
|
|
dragAllowedWhenFull: false,
|
|
dragProxy: ['Rectangle', {width: 1, height: 1, strokeWidth: 0}],
|
|
};
|
|
|
|
if (nodeTypeData.outputNames) {
|
|
// Apply output names if they got set
|
|
newEndpointData.overlays = [
|
|
NodeViewUtils.getOutputNameOverlay(nodeTypeData.outputNames[index]),
|
|
];
|
|
}
|
|
|
|
const endpoint = this.instance.addEndpoint(this.nodeId, {...newEndpointData});
|
|
if(!Array.isArray(endpoint)) {
|
|
endpoint.__meta = {
|
|
nodeName: node.name,
|
|
nodeId: this.nodeId,
|
|
index: i,
|
|
totalEndpoints: nodeTypeData.outputs.length,
|
|
};
|
|
}
|
|
|
|
if (!this.isReadOnly) {
|
|
const plusEndpointData: IEndpointOptions = {
|
|
uuid: NodeViewUtils.getOutputEndpointUUID(this.nodeId, index),
|
|
anchor: anchorPosition,
|
|
maxConnections: -1,
|
|
endpoint: 'N8nPlus',
|
|
isSource: true,
|
|
isTarget: false,
|
|
enabled: !this.isReadOnly,
|
|
endpointStyle: {
|
|
fill: getStyleTokenValue('--color-xdark'),
|
|
outlineStroke: 'none',
|
|
hover: false,
|
|
showOutputLabel: nodeTypeData.outputs.length === 1,
|
|
size: nodeTypeData.outputs.length >= 3 ? 'small' : 'medium',
|
|
hoverMessage: this.$locale.baseText('nodeBase.clickToAddNodeOrDragToConnect'),
|
|
},
|
|
endpointHoverStyle: {
|
|
fill: getStyleTokenValue('--color-primary'),
|
|
outlineStroke: 'none',
|
|
hover: true, // hack to distinguish hover state
|
|
},
|
|
parameters: {
|
|
nodeId: this.nodeId,
|
|
type: inputName,
|
|
index,
|
|
},
|
|
cssClass: 'plus-draggable-endpoint',
|
|
dragAllowedWhenFull: false,
|
|
dragProxy: ['Rectangle', {width: 1, height: 1, strokeWidth: 0}],
|
|
};
|
|
|
|
const plusEndpoint = this.instance.addEndpoint(this.nodeId, plusEndpointData);
|
|
if(!Array.isArray(plusEndpoint)) {
|
|
plusEndpoint.__meta = {
|
|
nodeName: node.name,
|
|
nodeId: this.nodeId,
|
|
index: i,
|
|
totalEndpoints: nodeTypeData.outputs.length,
|
|
};
|
|
}
|
|
}
|
|
});
|
|
},
|
|
__makeInstanceDraggable(node: INodeUi) {
|
|
// TODO: This caused problems with displaying old information
|
|
// https://github.com/jsplumb/katavorio/wiki
|
|
// https://jsplumb.github.io/jsplumb/home.html
|
|
// Make nodes draggable
|
|
this.instance.draggable(this.nodeId, {
|
|
grid: [NodeViewUtils.GRID_SIZE, NodeViewUtils.GRID_SIZE],
|
|
start: (params: { e: MouseEvent }) => {
|
|
if (this.isReadOnly === true) {
|
|
// Do not allow to move nodes in readOnly mode
|
|
return false;
|
|
}
|
|
// @ts-ignore
|
|
this.dragging = true;
|
|
|
|
const isSelected = this.uiStore.isNodeSelected(this.data.name);
|
|
const nodeName = this.data.name;
|
|
if (this.data.type === STICKY_NODE_TYPE && !isSelected) {
|
|
setTimeout(() => {
|
|
this.$emit('nodeSelected', nodeName, false, true);
|
|
}, 0);
|
|
}
|
|
|
|
if (params.e && !isSelected) {
|
|
// Only the node which gets dragged directly gets an event, for all others it is
|
|
// undefined. So check if the currently dragged node is selected and if not clear
|
|
// the drag-selection.
|
|
this.instance.clearDragSelection();
|
|
this.uiStore.resetSelectedNodes();
|
|
}
|
|
|
|
this.uiStore.addActiveAction('dragActive');
|
|
return true;
|
|
},
|
|
stop: (params: { e: MouseEvent }) => {
|
|
// @ts-ignore
|
|
this.dragging = false;
|
|
if (this.uiStore.isActionActive('dragActive')) {
|
|
const moveNodes = this.uiStore.getSelectedNodes.slice();
|
|
const selectedNodeNames = moveNodes.map((node: INodeUi) => node.name);
|
|
if (!selectedNodeNames.includes(this.data.name)) {
|
|
// If the current node is not in selected add it to the nodes which
|
|
// got moved manually
|
|
moveNodes.push(this.data);
|
|
}
|
|
|
|
if(moveNodes.length > 1) {
|
|
this.historyStore.startRecordingUndo();
|
|
}
|
|
// This does for some reason just get called once for the node that got clicked
|
|
// even though "start" and "drag" gets called for all. So lets do for now
|
|
// some dirty DOM query to get the new positions till I have more time to
|
|
// create a proper solution
|
|
let newNodePosition: XYPosition;
|
|
moveNodes.forEach((node: INodeUi) => {
|
|
const element = document.getElementById(node.id);
|
|
if (element === null) {
|
|
return;
|
|
}
|
|
|
|
newNodePosition = [
|
|
parseInt(element.style.left!.slice(0, -2), 10),
|
|
parseInt(element.style.top!.slice(0, -2), 10),
|
|
];
|
|
|
|
const updateInformation = {
|
|
name: node.name,
|
|
properties: {
|
|
// @ts-ignore, draggable does not have definitions
|
|
position: newNodePosition,
|
|
},
|
|
};
|
|
const oldPosition = node.position;
|
|
if (oldPosition[0] !== newNodePosition[0] || oldPosition[1] !== newNodePosition[1]) {
|
|
this.historyStore.pushCommandToUndo(new MoveNodeCommand(node.name, oldPosition, newNodePosition, this));
|
|
this.workflowsStore.updateNodeProperties(updateInformation);
|
|
this.$emit('moved', node);
|
|
}
|
|
});
|
|
if(moveNodes.length > 1) {
|
|
this.historyStore.stopRecordingUndo();
|
|
}
|
|
}
|
|
},
|
|
filter: '.node-description, .node-description .node-name, .node-description .node-subtitle',
|
|
});
|
|
},
|
|
__addNode (node: INodeUi) {
|
|
let nodeTypeData = this.nodeTypesStore.getNodeType(node.type, node.typeVersion);
|
|
if (!nodeTypeData) {
|
|
// If node type is not know use by default the base.noOp data to display it
|
|
nodeTypeData = this.nodeTypesStore.getNodeType(NO_OP_NODE_TYPE);
|
|
}
|
|
|
|
this.__addInputEndpoints(node, nodeTypeData);
|
|
this.__addOutputEndpoints(node, nodeTypeData);
|
|
this.__makeInstanceDraggable(node);
|
|
},
|
|
touchEnd(e: MouseEvent) {
|
|
if (this.isTouchDevice) {
|
|
if (this.uiStore.isActionActive('dragActive')) {
|
|
this.uiStore.removeActiveAction('dragActive');
|
|
}
|
|
}
|
|
},
|
|
mouseLeftClick (e: MouseEvent) {
|
|
// @ts-ignore
|
|
const path = e.path || (e.composedPath && e.composedPath());
|
|
for (let index = 0; index < path.length; index++) {
|
|
if (path[index].className && typeof path[index].className === 'string' && path[index].className.includes('no-select-on-click')) {
|
|
return;
|
|
}
|
|
}
|
|
|
|
if (!this.isTouchDevice) {
|
|
if (this.uiStore.isActionActive('dragActive')) {
|
|
this.uiStore.removeActiveAction('dragActive');
|
|
} else {
|
|
if (!this.isCtrlKeyPressed(e)) {
|
|
this.$emit('deselectAllNodes');
|
|
}
|
|
|
|
if (this.uiStore.isNodeSelected(this.data.name)) {
|
|
this.$emit('deselectNode', this.name);
|
|
} else {
|
|
this.$emit('nodeSelected', this.name);
|
|
}
|
|
}
|
|
}
|
|
},
|
|
},
|
|
});
|