mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-09 22:24:05 -08:00
b321c5e4ec
* ⚡ Removing authentication parameter from NDV * ⚡ Added auth type selector to credentials modal * 🔨 Extracting reusable logic to util functions * ⚡ Updating credentials position, adding label for radio buttons * ⚡ Using first node credentials for nodes with single auth options and hiding auth selector UI in that case * ⚡ Fixing credentials modal when opened from credentials page * ⚡ Showing all available credentials in NDV credentials dropdown * ⚡ Updating node credentials dropdown component to show credentials description. Disabling `Credentials of type not found` error in node * ⚡ Moving auth related fields from NDV to credentials modal. Added support for multiple auth fileds * ⚡ Moving NDV fields that authentication depends on to credentials modal * ⚡ Keeping old auth/credentials UI in NDV for HTTP Request and Webhook nodes. Pre-populating credential type for HTTP request node when selected from 'app action' menu * 💄 Use old label and field position for nodes that use old credentials UI in NDV * ⚡ Implementing more generic way to find node's auth fileds * 📚 Adding comments on parameter hiding logic * ⚡ Fixing node auth options logic for multiple auth fields * 👕 Fixing lint errors * 💄 Addressing design review comments * ⚡ Not selecting first auth option when opening new credential dialog * ⚡ Using default credentials name and icon if authentication type is not selected * ⚡ Updating credential data when auth type is changed * ⚡ Setting new credentials type for HTTP Request and Webhook nodes * ⚡ Setting nodes with access when changing auth type * 👕 Fixing lint error * ⚡ Updating active node auth type from credentials modal * ⚡ Syncronizing credentials modal and dropdown * 👕 Fixing linter error * ⚡ Handling credential dropdown UI for multiple credentials * 👕 Removing unused imports * ⚡ Handling auth selection when default auth type is the first option * ⚡ Updating credentials change listening logic * ⚡ Resetting credential data when deleting a credential, disabling 'Details' and 'Sharing' tabs if auth type is not selected * 🐛 Skipping credentials type check when showing mixed credentials in the dropdown and switching credentials type * ⚡ Showing credential modal tabs for saved credentials * ⚡ Preventing renaming credentials when no auth type is selected * 🐛 Fixing credentials modal when opened from credentials page * ⚡ Keeping auth radio buttons selected when switching tabs * ✅ Adding initial batch of credentials NDV tests * ⚡ Updating node auth filed value when new credential type is selected * ⚡ Using all available credential types for current node to sync credential dropdown with modal * ⚡ Sorting mixed credentials by date, simplifying credential dropdown option logic * 🔨 Extracting some reusable logic to utils * ⚡ Improving required vs optional credentials detection and using it to show auth radio buttons * 👕 Fixing lint errors * ✅ Adding more credentials tests * ⚡ Filtering credential options based on authentication type * 🔨 Refactoring credentials and auth utils * ⚡ Updated handling of auth options in credentials modal to work with new logic * 🔨 Getting the terminology in line * 📚 Removing leftover comment * ⚡ Updating node auth filed detection logic to account for different edge-cases * ⚡ Adding Wait node as an exception for new UI * ⚡ Updating NDV display when auth type changes * ⚡ Updating default credentials name when auth type changes * ⚡ Hiding auth settings after credentials are saved * ⚡ Always showing credentials modal menu tabs * ⚡ Improving main auth field detection logic so it doesn't account for authentication fields which can have `none` value * ⚡ Restoring accidentally deleted not existing credential issue logic * ⚡ Updating other nodes when deleted credentials have been updated * ⚡ Using filtered auth type list to show or hide radio buttons section in credentials modal * 👕 Addressing lint error * 👌 Addressing PR review feedback * 👕 Fixing lint issues * ⚡ Updating main auth filed detection logic so it checks full dependency path to determine if the field is required or optional * 👌 Addressing the rest of PR feedback * ✅ Updating credential tests * ⚡ Resetting credential data on authentication type change * ⚡ Created AuthTypeSelector component * 👌 Addressing PR comments * ⚡ Not resetting overwritten credential properties when changing auth type * ⚡ Hiding auth selector section if there are no options to show
239 lines
11 KiB
TypeScript
239 lines
11 KiB
TypeScript
import { HTTP_REQUEST_NODE_TYPE } from './../../packages/editor-ui/src/constants';
|
|
import { NEW_NOTION_ACCOUNT_NAME, NOTION_NODE_NAME, PIPEDRIVE_NODE_NAME, HTTP_REQUEST_NODE_NAME, NEW_QUERY_AUTH_ACCOUNT_NAME } from './../constants';
|
|
import { visit } from 'recast';
|
|
import { DEFAULT_USER_EMAIL, DEFAULT_USER_PASSWORD, GMAIL_NODE_NAME, NEW_GOOGLE_ACCOUNT_NAME, NEW_TRELLO_ACCOUNT_NAME, SCHEDULE_TRIGGER_NODE_NAME, TRELLO_NODE_NAME } from '../constants';
|
|
import { randFirstName, randLastName } from '@ngneat/falso';
|
|
import { CredentialsPage, CredentialsModal, WorkflowPage, NDV } from '../pages';
|
|
|
|
const email = DEFAULT_USER_EMAIL;
|
|
const password = DEFAULT_USER_PASSWORD;
|
|
const firstName = randFirstName();
|
|
const lastName = randLastName();
|
|
const credentialsPage = new CredentialsPage();
|
|
const credentialsModal = new CredentialsModal();
|
|
const workflowPage = new WorkflowPage();
|
|
const nodeDetailsView = new NDV();
|
|
|
|
const NEW_CREDENTIAL_NAME = 'Something else';
|
|
|
|
describe('Credentials', () => {
|
|
before(() => {
|
|
cy.resetAll();
|
|
cy.setup({ email, firstName, lastName, password });
|
|
});
|
|
|
|
beforeEach(() => {
|
|
cy.on('uncaught:exception', (err, runnable) => {
|
|
expect(err.message).to.include('Not logged in');
|
|
|
|
return false;
|
|
});
|
|
|
|
cy.signin({ email, password });
|
|
cy.visit(credentialsPage.url);
|
|
});
|
|
|
|
it('should create a new credential using empty state', () => {
|
|
credentialsPage.getters.emptyListCreateCredentialButton().click();
|
|
|
|
credentialsModal.getters.newCredentialModal().should('be.visible');
|
|
credentialsModal.getters.newCredentialTypeSelect().should('be.visible');
|
|
credentialsModal.getters.newCredentialTypeOption('Notion API').click();
|
|
|
|
credentialsModal.getters.newCredentialTypeButton().click();
|
|
|
|
credentialsModal.getters.connectionParameter('API Key').type('1234567890');
|
|
|
|
credentialsModal.actions.setName('My awesome Notion account');
|
|
credentialsModal.actions.save();
|
|
credentialsModal.actions.close();
|
|
|
|
credentialsPage.getters.credentialCards().should('have.length', 1);
|
|
});
|
|
|
|
it('should create a new credential using Add Credential button', () => {
|
|
credentialsPage.getters.createCredentialButton().click();
|
|
|
|
credentialsModal.getters.newCredentialModal().should('be.visible');
|
|
credentialsModal.getters.newCredentialTypeSelect().should('be.visible');
|
|
credentialsModal.getters.newCredentialTypeOption('Airtable API').click();
|
|
|
|
credentialsModal.getters.newCredentialTypeButton().click();
|
|
|
|
credentialsModal.getters.connectionParameter('API Key').type('1234567890');
|
|
|
|
credentialsModal.actions.setName('Airtable Account');
|
|
credentialsModal.actions.save();
|
|
credentialsModal.actions.close();
|
|
|
|
credentialsPage.getters.credentialCards().should('have.length', 2);
|
|
});
|
|
|
|
it('should search credentials', () => {
|
|
// Search by name
|
|
credentialsPage.actions.search('Notion');
|
|
credentialsPage.getters.credentialCards().should('have.length', 1);
|
|
|
|
// Search by Credential type
|
|
credentialsPage.actions.search('Airtable API');
|
|
credentialsPage.getters.credentialCards().should('have.length', 1);
|
|
|
|
// No results
|
|
credentialsPage.actions.search('Google');
|
|
credentialsPage.getters.credentialCards().should('have.length', 0);
|
|
credentialsPage.getters.emptyList().should('be.visible');
|
|
});
|
|
|
|
it('should sort credentials', () => {
|
|
credentialsPage.actions.search('');
|
|
credentialsPage.actions.sortBy('nameDesc');
|
|
credentialsPage.getters.credentialCards().eq(0).should('contain.text', 'Notion');
|
|
credentialsPage.actions.sortBy('nameAsc');
|
|
});
|
|
|
|
it('should create credentials from NDV for node with multiple auth options', () => {
|
|
workflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
workflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
workflowPage.actions.addNodeToCanvas(GMAIL_NODE_NAME);
|
|
workflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').type('{enter}');
|
|
workflowPage.getters.nodeCredentialsSelect().click();
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').last().click();
|
|
credentialsModal.getters.credentialsEditModal().should('be.visible');
|
|
credentialsModal.getters.credentialAuthTypeRadioButtons().should('have.length', 2);
|
|
credentialsModal.getters.credentialAuthTypeRadioButtons().first().click();
|
|
credentialsModal.actions.fillCredentialsForm();
|
|
cy.get('.el-message-box').find('button').contains('Close').click();
|
|
workflowPage.getters.nodeCredentialsSelect().should('contain', NEW_GOOGLE_ACCOUNT_NAME);
|
|
})
|
|
|
|
it('should show multiple credential types in the same dropdown', () => {
|
|
workflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
workflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
workflowPage.actions.addNodeToCanvas(GMAIL_NODE_NAME);
|
|
workflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').type('{enter}');
|
|
workflowPage.getters.nodeCredentialsSelect().click();
|
|
// Add oAuth credentials
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').last().click();
|
|
credentialsModal.getters.credentialsEditModal().should('be.visible');
|
|
credentialsModal.getters.credentialAuthTypeRadioButtons().should('have.length', 2);
|
|
credentialsModal.getters.credentialAuthTypeRadioButtons().first().click();
|
|
credentialsModal.actions.fillCredentialsForm();
|
|
cy.get('.el-message-box').find('button').contains('Close').click();
|
|
workflowPage.getters.nodeCredentialsSelect().click();
|
|
// Add Service account credentials
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').last().click();
|
|
credentialsModal.getters.credentialsEditModal().should('be.visible');
|
|
credentialsModal.getters.credentialAuthTypeRadioButtons().should('have.length', 2);
|
|
credentialsModal.getters.credentialAuthTypeRadioButtons().last().click();
|
|
credentialsModal.actions.fillCredentialsForm();
|
|
// Both (+ the 'Create new' option) should be in the dropdown
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').should('have.length.greaterThan', 3);
|
|
});
|
|
|
|
it('should correctly render required and optional credentials', () => {
|
|
workflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
workflowPage.actions.addNodeToCanvas(PIPEDRIVE_NODE_NAME, true);
|
|
cy.get('body').type('{downArrow}');
|
|
cy.get('body').type('{enter}');
|
|
// Select incoming authentication
|
|
nodeDetailsView.getters.parameterInput('incomingAuthentication').should('exist');
|
|
nodeDetailsView.getters.parameterInput('incomingAuthentication').click();
|
|
nodeDetailsView.getters.parameterInput('incomingAuthentication').find('li').first().click();
|
|
// There should be two credential fields
|
|
workflowPage.getters.nodeCredentialsSelect().should('have.length', 2);
|
|
|
|
workflowPage.getters.nodeCredentialsSelect().first().click();
|
|
workflowPage.getters.nodeCredentialsSelect().first().find('li').last().click();
|
|
// This one should show auth type selector
|
|
credentialsModal.getters.credentialAuthTypeRadioButtons().should('have.length', 2);
|
|
cy.get('body').type('{esc}');
|
|
|
|
workflowPage.getters.nodeCredentialsSelect().last().click();
|
|
workflowPage.getters.nodeCredentialsSelect().last().find('li').last().click();
|
|
// This one should not show auth type selector
|
|
credentialsModal.getters.credentialsAuthTypeSelector().should('not.exist');
|
|
});
|
|
|
|
it('should create credentials from NDV for node with no auth options', () => {
|
|
workflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
workflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
workflowPage.actions.addNodeToCanvas(TRELLO_NODE_NAME);
|
|
workflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').type('{enter}');
|
|
workflowPage.getters.nodeCredentialsSelect().click();
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').last().click();
|
|
credentialsModal.getters.credentialsAuthTypeSelector().should('not.exist');
|
|
credentialsModal.actions.fillCredentialsForm();
|
|
workflowPage.getters.nodeCredentialsSelect().should('contain', NEW_TRELLO_ACCOUNT_NAME);
|
|
});
|
|
|
|
it('should delete credentials from NDV', () => {
|
|
workflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
workflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
workflowPage.actions.addNodeToCanvas(NOTION_NODE_NAME);
|
|
workflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').type('{enter}');
|
|
workflowPage.getters.nodeCredentialsSelect().click();
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').last().click();
|
|
credentialsModal.actions.fillCredentialsForm();
|
|
workflowPage.getters.nodeCredentialsSelect().should('contain', NEW_NOTION_ACCOUNT_NAME);
|
|
|
|
workflowPage.getters.nodeCredentialsEditButton().click();
|
|
credentialsModal.getters.credentialsEditModal().should('be.visible');
|
|
credentialsModal.getters.deleteButton().click();
|
|
cy.get('.el-message-box').find('button').contains('Yes').click();
|
|
workflowPage.getters.successToast().contains('Credential deleted');
|
|
workflowPage.getters.nodeCredentialsSelect().should('not.contain', NEW_TRELLO_ACCOUNT_NAME);
|
|
});
|
|
|
|
it('should rename credentials from NDV', () => {
|
|
workflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
workflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
workflowPage.actions.addNodeToCanvas(TRELLO_NODE_NAME);
|
|
workflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').type('{enter}');
|
|
workflowPage.getters.nodeCredentialsSelect().click();
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').last().click();
|
|
credentialsModal.actions.fillCredentialsForm();
|
|
workflowPage.getters.nodeCredentialsSelect().should('contain', NEW_TRELLO_ACCOUNT_NAME);
|
|
|
|
workflowPage.getters.nodeCredentialsEditButton().click();
|
|
credentialsModal.getters.credentialsEditModal().should('be.visible');
|
|
credentialsModal.getters.name().click();
|
|
credentialsModal.actions.renameCredential(NEW_CREDENTIAL_NAME);
|
|
credentialsModal.getters.saveButton().click();
|
|
credentialsModal.getters.closeButton().click();
|
|
workflowPage.getters.nodeCredentialsSelect().should('contain', NEW_CREDENTIAL_NAME);
|
|
});
|
|
|
|
it('should setup generic authentication for HTTP node', () => {
|
|
workflowPage.actions.visit();
|
|
cy.waitForLoad();
|
|
workflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
workflowPage.actions.addNodeToCanvas(HTTP_REQUEST_NODE_NAME);
|
|
workflowPage.getters.canvasNodes().last().click();
|
|
cy.get('body').type('{enter}');
|
|
nodeDetailsView.getters.parameterInput('authentication').click();
|
|
nodeDetailsView.getters.parameterInput('authentication').find('li').should('have.length', 3);
|
|
nodeDetailsView.getters.parameterInput('authentication').find('li').last().click();
|
|
nodeDetailsView.getters.parameterInput('genericAuthType').should('exist');
|
|
nodeDetailsView.getters.parameterInput('genericAuthType').click();
|
|
nodeDetailsView.getters.parameterInput('genericAuthType').find('li').should('have.length.greaterThan', 0);
|
|
nodeDetailsView.getters.parameterInput('genericAuthType').find('li').last().click();
|
|
|
|
workflowPage.getters.nodeCredentialsSelect().should('exist');
|
|
workflowPage.getters.nodeCredentialsSelect().click();
|
|
workflowPage.getters.nodeCredentialsSelect().find('li').last().click();
|
|
credentialsModal.actions.fillCredentialsForm();
|
|
workflowPage.getters.nodeCredentialsSelect().should('contain', NEW_QUERY_AUTH_ACCOUNT_NAME);
|
|
});
|
|
});
|