mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-14 16:44:07 -08:00
38b88b946b
## Summary Ensure `ownedBy` and `sharedWith` are present and uniform for credentials and workflows. Details in story: https://linear.app/n8n/issue/PAY-987
178 lines
5 KiB
TypeScript
178 lines
5 KiB
TypeScript
import { OwnershipService } from '@/services/ownership.service';
|
|
import { SharedWorkflowRepository } from '@db/repositories/sharedWorkflow.repository';
|
|
import { Role } from '@db/entities/Role';
|
|
import { SharedWorkflow } from '@db/entities/SharedWorkflow';
|
|
import { CacheService } from '@/services/cache.service';
|
|
import { User } from '@db/entities/User';
|
|
import { RoleService } from '@/services/role.service';
|
|
import { UserService } from '@/services/user.service';
|
|
import { CredentialsEntity } from '@db/entities/CredentialsEntity';
|
|
import type { SharedCredentials } from '@db/entities/SharedCredentials';
|
|
import { mockInstance } from '../../shared/mocking';
|
|
import {
|
|
randomCredentialPayload,
|
|
randomEmail,
|
|
randomInteger,
|
|
randomName,
|
|
} from '../../integration/shared/random';
|
|
import { WorkflowEntity } from '@/databases/entities/WorkflowEntity';
|
|
|
|
const wfOwnerRole = () =>
|
|
Object.assign(new Role(), {
|
|
scope: 'workflow',
|
|
name: 'owner',
|
|
id: randomInteger(),
|
|
});
|
|
|
|
const mockCredRole = (name: 'owner' | 'editor'): Role =>
|
|
Object.assign(new Role(), {
|
|
scope: 'credentials',
|
|
name,
|
|
id: randomInteger(),
|
|
});
|
|
|
|
const mockCredential = (): CredentialsEntity =>
|
|
Object.assign(new CredentialsEntity(), randomCredentialPayload());
|
|
|
|
const mockUser = (): User =>
|
|
Object.assign(new User(), {
|
|
id: randomInteger(),
|
|
email: randomEmail(),
|
|
firstName: randomName(),
|
|
lastName: randomName(),
|
|
});
|
|
|
|
describe('OwnershipService', () => {
|
|
const cacheService = mockInstance(CacheService);
|
|
const roleService = mockInstance(RoleService);
|
|
const userService = mockInstance(UserService);
|
|
const sharedWorkflowRepository = mockInstance(SharedWorkflowRepository);
|
|
|
|
const ownershipService = new OwnershipService(
|
|
cacheService,
|
|
userService,
|
|
roleService,
|
|
sharedWorkflowRepository,
|
|
);
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
describe('getWorkflowOwner()', () => {
|
|
test('should retrieve a workflow owner', async () => {
|
|
roleService.findWorkflowOwnerRole.mockResolvedValueOnce(wfOwnerRole());
|
|
|
|
const mockOwner = new User();
|
|
const mockNonOwner = new User();
|
|
|
|
const sharedWorkflow = Object.assign(new SharedWorkflow(), {
|
|
role: new Role(),
|
|
user: mockOwner,
|
|
});
|
|
|
|
sharedWorkflowRepository.findOneOrFail.mockResolvedValueOnce(sharedWorkflow);
|
|
|
|
const returnedOwner = await ownershipService.getWorkflowOwnerCached('some-workflow-id');
|
|
|
|
expect(returnedOwner).toBe(mockOwner);
|
|
expect(returnedOwner).not.toBe(mockNonOwner);
|
|
});
|
|
|
|
test('should throw if no workflow owner role found', async () => {
|
|
roleService.findWorkflowOwnerRole.mockRejectedValueOnce(new Error());
|
|
|
|
await expect(ownershipService.getWorkflowOwnerCached('some-workflow-id')).rejects.toThrow();
|
|
});
|
|
|
|
test('should throw if no workflow owner found', async () => {
|
|
roleService.findWorkflowOwnerRole.mockResolvedValueOnce(wfOwnerRole());
|
|
|
|
sharedWorkflowRepository.findOneOrFail.mockRejectedValue(new Error());
|
|
|
|
await expect(ownershipService.getWorkflowOwnerCached('some-workflow-id')).rejects.toThrow();
|
|
});
|
|
});
|
|
|
|
describe('addOwnedByAndSharedWith()', () => {
|
|
test('should add `ownedBy` and `sharedWith` to credential', async () => {
|
|
const owner = mockUser();
|
|
const editor = mockUser();
|
|
|
|
const credential = mockCredential();
|
|
|
|
credential.shared = [
|
|
{ role: mockCredRole('owner'), user: owner },
|
|
{ role: mockCredRole('editor'), user: editor },
|
|
] as SharedCredentials[];
|
|
|
|
const { ownedBy, sharedWith } = ownershipService.addOwnedByAndSharedWith(credential);
|
|
|
|
expect(ownedBy).toStrictEqual({
|
|
id: owner.id,
|
|
email: owner.email,
|
|
firstName: owner.firstName,
|
|
lastName: owner.lastName,
|
|
});
|
|
|
|
expect(sharedWith).toStrictEqual([
|
|
{
|
|
id: editor.id,
|
|
email: editor.email,
|
|
firstName: editor.firstName,
|
|
lastName: editor.lastName,
|
|
},
|
|
]);
|
|
});
|
|
|
|
test('should add `ownedBy` and `sharedWith` to workflow', async () => {
|
|
const owner = mockUser();
|
|
const editor = mockUser();
|
|
|
|
const workflow = new WorkflowEntity();
|
|
|
|
workflow.shared = [
|
|
{ role: mockCredRole('owner'), user: owner },
|
|
{ role: mockCredRole('editor'), user: editor },
|
|
] as SharedWorkflow[];
|
|
|
|
const { ownedBy, sharedWith } = ownershipService.addOwnedByAndSharedWith(workflow);
|
|
|
|
expect(ownedBy).toStrictEqual({
|
|
id: owner.id,
|
|
email: owner.email,
|
|
firstName: owner.firstName,
|
|
lastName: owner.lastName,
|
|
});
|
|
|
|
expect(sharedWith).toStrictEqual([
|
|
{
|
|
id: editor.id,
|
|
email: editor.email,
|
|
firstName: editor.firstName,
|
|
lastName: editor.lastName,
|
|
},
|
|
]);
|
|
});
|
|
|
|
test('should produce an empty sharedWith if no sharee', async () => {
|
|
const owner = mockUser();
|
|
|
|
const credential = mockCredential();
|
|
|
|
credential.shared = [{ role: mockCredRole('owner'), user: owner }] as SharedCredentials[];
|
|
|
|
const { ownedBy, sharedWith } = ownershipService.addOwnedByAndSharedWith(credential);
|
|
|
|
expect(ownedBy).toStrictEqual({
|
|
id: owner.id,
|
|
email: owner.email,
|
|
firstName: owner.firstName,
|
|
lastName: owner.lastName,
|
|
});
|
|
|
|
expect(sharedWith).toHaveLength(0);
|
|
});
|
|
});
|
|
});
|