n8n/packages/nodes-base/nodes/Strava/StravaTrigger.node.ts
Iván Ovejero 1d27a9e87e
Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00

282 lines
7 KiB
TypeScript

import {
IHookFunctions,
IWebhookFunctions,
} from 'n8n-core';
import {
IDataObject,
INodeType,
INodeTypeDescription,
IWebhookResponseData,
NodeApiError,
} from 'n8n-workflow';
import {
stravaApiRequest,
} from './GenericFunctions';
import {
randomBytes,
} from 'crypto';
export class StravaTrigger implements INodeType {
description: INodeTypeDescription = {
displayName: 'Strava Trigger',
name: 'stravaTrigger',
icon: 'file:strava.svg',
group: ['trigger'],
version: 1,
description: 'Starts the workflow when a Strava events occurs.',
defaults: {
name: 'Strava Trigger',
color: '#ea5929',
},
inputs: [],
outputs: ['main'],
credentials: [
{
name: 'stravaOAuth2Api',
required: true,
},
],
webhooks: [
{
name: 'setup',
httpMethod: 'GET',
responseMode: 'onReceived',
path: 'webhook',
},
{
name: 'default',
httpMethod: 'POST',
responseMode: 'onReceived',
path: 'webhook',
},
],
properties: [
{
displayName: 'Object',
name: 'object',
type: 'options',
options: [
{
name: '*',
value: '*',
},
{
name: 'Activity',
value: 'activity',
},
{
name: 'Athlete',
value: 'athlete',
},
],
default: '*',
},
{
displayName: 'Event',
name: 'event',
type: 'options',
options: [
{
name: '*',
value: '*',
},
{
name: 'created',
value: 'create',
},
{
name: 'Deleted',
value: 'delete',
},
{
name: 'Updated',
value: 'update',
},
],
default: '*',
},
{
displayName: 'Resolve Data',
name: 'resolveData',
type: 'boolean',
default: true,
description: 'By default the webhook-data only contain the Object ID. If this option gets activated it<br />will resolve the data automatically.',
},
{
displayName: 'Options',
name: 'options',
type: 'collection',
placeholder: 'Add Option',
default: {},
options: [
{
displayName: 'Delete If Exist',
name: 'deleteIfExist',
type: 'boolean',
default: false,
description: `Strava allows just one subscription at all times. If you want to delete the current subscription to make<br>
room for a new subcription with the current parameters, set this parameter to true. Keep in mind this is a destructive operation.`,
},
],
},
],
};
// @ts-ignore (because of request)
webhookMethods = {
default: {
async checkExists(this: IHookFunctions): Promise<boolean> {
const webhookUrl = this.getNodeWebhookUrl('default');
const webhookData = this.getWorkflowStaticData('node');
// Check all the webhooks which exist already if it is identical to the
// one that is supposed to get created.
const endpoint = '/push_subscriptions';
const webhooks = await stravaApiRequest.call(this, 'GET', endpoint, {});
for (const webhook of webhooks) {
if (webhook.callback_url === webhookUrl) {
webhookData.webhookId = webhook.id;
return true;
}
}
return false;
},
async create(this: IHookFunctions): Promise<boolean> {
const webhookData = this.getWorkflowStaticData('node');
const webhookUrl = this.getNodeWebhookUrl('default');
const endpoint = '/push_subscriptions';
const body = {
callback_url: webhookUrl,
verify_token: randomBytes(20).toString('hex') as string,
};
let responseData;
try {
responseData = await stravaApiRequest.call(this, 'POST', endpoint, body);
} catch (error) {
const apiErrorResponse = error.cause.response;
if (apiErrorResponse?.body?.errors) {
const errors = apiErrorResponse.body.errors;
for (error of errors) {
// if there is a subscription already created
if (error.resource === 'PushSubscription' && error.code === 'already exists') {
const options = this.getNodeParameter('options') as IDataObject;
//get the current subscription
const webhooks = await stravaApiRequest.call(this, 'GET', `/push_subscriptions`, {});
if (options.deleteIfExist) {
// delete the subscription
await stravaApiRequest.call(this, 'DELETE', `/push_subscriptions/${webhooks[0].id}`);
// now there is room create a subscription with the n8n data
const body = {
callback_url: webhookUrl,
verify_token: randomBytes(20).toString('hex') as string,
};
responseData = await stravaApiRequest.call(this, 'POST', `/push_subscriptions`, body);
} else {
error.message = `A subscription already exists [${webhooks[0].callback_url}]. If you want to delete this subcription and create a new one with the current parameters please go to options and set delete if exist to true`;
throw error;
}
}
}
}
if (!responseData) {
throw error;
}
}
if (responseData.id === undefined) {
// Required data is missing so was not successful
return false;
}
webhookData.webhookId = responseData.id as string;
return true;
},
async delete(this: IHookFunctions): Promise<boolean> {
const webhookData = this.getWorkflowStaticData('node');
if (webhookData.webhookId !== undefined) {
const endpoint = `/push_subscriptions/${webhookData.webhookId}`;
try {
await stravaApiRequest.call(this, 'DELETE', endpoint);
} catch (error) {
return false;
}
// Remove from the static workflow data so that it is clear
// that no webhooks are registred anymore
delete webhookData.webhookId;
}
return true;
},
},
};
async webhook(this: IWebhookFunctions): Promise<IWebhookResponseData> {
const body = this.getBodyData() as IDataObject;
const query = this.getQueryData() as IDataObject;
const object = this.getNodeParameter('object');
const event = this.getNodeParameter('event');
const resolveData = this.getNodeParameter('resolveData') as boolean;
let objectType, eventType;
if (object === '*') {
objectType = ['activity', 'athlete'];
} else {
objectType = [object];
}
if (event === '*') {
eventType = ['create', 'update', 'delete'];
} else {
eventType = [event];
}
if (this.getWebhookName() === 'setup') {
if (query['hub.challenge']) {
// Is a create webhook confirmation request
const res = this.getResponseObject();
res.status(200).json({ 'hub.challenge': query['hub.challenge'] }).end();
return {
noWebhookResponse: true,
};
}
}
if (object !== '*' && !objectType.includes(body.object_type as string)) {
return {};
}
if (event !== '*' && !eventType.includes(body.aspect_type as string)) {
return {};
}
if (resolveData) {
let endpoint = `/athletes/${body.object_id}/stats`;
if (body.object_type === 'activity') {
endpoint = `/activities/${body.object_id}`;
}
body.object_data = await stravaApiRequest.call(this, 'GET', endpoint);
}
return {
workflowData: [
this.helpers.returnJsonArray(body),
],
};
}
}