mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-14 16:44:07 -08:00
071e6d6b6e
## Summary <img width="1240" alt="image" src="https://github.com/n8n-io/n8n/assets/8850410/2819f4ce-c343-431a-8a88-a1bc9c4b572a"> <img width="2649" alt="image" src="https://github.com/n8n-io/n8n/assets/8850410/36862aaf-cc4c-4668-bdc8-cf5a6f00babe"> 1. Add code node and open it 3. Click the fullscreen button in the bottom right 4. A fullscreen dialog should appear and allow editing the code 5. Changes made in the fullscreen dialog should be applied to the original code editor when closed It should work the same way for HTML/SQL/JSON editors ⚠️ Modal layout was updated so that modals/dialogs are centered, try to test some modals ## Related tickets and issues https://linear.app/n8n/issue/NODE-1009/add-fullscreen-view-to-code-node ## Review / Merge checklist - [ ] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. > A feature is not complete without tests. --------- Co-authored-by: Giulio Andreini <andreini@netseven.it>
68 lines
1.6 KiB
TypeScript
68 lines
1.6 KiB
TypeScript
import type {
|
|
INodeExecutionData,
|
|
IExecuteFunctions,
|
|
INodeProperties,
|
|
IDataObject,
|
|
INode,
|
|
} from 'n8n-workflow';
|
|
import { NodeOperationError } from 'n8n-workflow';
|
|
|
|
import { updateDisplayOptions } from '../../../utils/utilities';
|
|
import { parseJsonParameter, composeReturnItem, resolveRawData } from './helpers/utils';
|
|
import type { SetNodeOptions } from './helpers/interfaces';
|
|
|
|
const properties: INodeProperties[] = [
|
|
{
|
|
displayName: 'JSON Output',
|
|
name: 'jsonOutput',
|
|
type: 'json',
|
|
typeOptions: {
|
|
rows: 5,
|
|
},
|
|
default: '{\n "my_field_1": "value",\n "my_field_2": 1\n}\n',
|
|
validateType: 'object',
|
|
ignoreValidationDuringExecution: true,
|
|
},
|
|
];
|
|
|
|
const displayOptions = {
|
|
show: {
|
|
mode: ['raw'],
|
|
},
|
|
};
|
|
|
|
export const description = updateDisplayOptions(displayOptions, properties);
|
|
|
|
export async function execute(
|
|
this: IExecuteFunctions,
|
|
item: INodeExecutionData,
|
|
i: number,
|
|
options: SetNodeOptions,
|
|
rawData: IDataObject,
|
|
node: INode,
|
|
) {
|
|
try {
|
|
let newData: IDataObject;
|
|
if (rawData.jsonOutput === undefined) {
|
|
const json = this.getNodeParameter('jsonOutput', i) as string;
|
|
newData = parseJsonParameter(json, node, i);
|
|
} else {
|
|
newData = parseJsonParameter(
|
|
resolveRawData.call(this, rawData.jsonOutput as string, i),
|
|
node,
|
|
i,
|
|
);
|
|
}
|
|
|
|
return composeReturnItem.call(this, i, item, newData, options);
|
|
} catch (error) {
|
|
if (this.continueOnFail()) {
|
|
return { json: { error: (error as Error).message }, pairedItem: { item: i } };
|
|
}
|
|
throw new NodeOperationError(node, error as Error, {
|
|
itemIndex: i,
|
|
description: error.description,
|
|
});
|
|
}
|
|
}
|