mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-10 22:54:05 -08:00
d548161632
* ✨ Implement security audit * ⚡ Use logger * 🧪 Fix test * ⚡ Switch logger with stdout * 🎨 Set new logo * ⚡ Fill out Public API schema * ✏️ Fix typo * ⚡ Break dependency cycle * ⚡ Add security settings values * 🧪 Test security settings * ⚡ Add publicly accessible instance warning * ⚡ Add metric to CLI command * ✏️ Fix typo * 🔥 Remove unneeded path alias * 📘 Add type import * 🔥 Remove inferrable output type * ⚡ Set description at correct level * ⚡ Rename constant for consistency * ⚡ Sort URLs * ⚡ Rename local var * ⚡ Shorten name * ✏️ Improve phrasing * ⚡ Improve naming * ⚡ Fix casing * ✏️ Add docline * ✏️ Relocate comment * ⚡ Add singular/plurals * 🔥 Remove unneeded await * ✏️ Improve test description * ⚡ Optimize with sets * ⚡ Adjust post master merge * ✏️ Improve naming * ⚡ Adjust in spy * 🧪 Fix outdated instance test * 🧪 Make diagnostics check consistent * ⚡ Refactor `getAllExistingCreds` * ⚡ Create helper `getNodeTypes` * 🐛 Fix `InternalHooksManager` call * 🚚 Rename `execution` to `nodes` risk * ⚡ Add options to CLI command * ⚡ Make days configurable * :revert: Undo changes to `BaseCommand` * ⚡ Improve CLI command UX * ⚡ Change no-report return value Empty array to trigger empty state on FE. * ⚡ Add empty check to `reportInstanceRisk` * 🧪 Extend Jest `expect` * 📘 Augment `jest.Matchers` * 🧪 Set extend as setup file * 🔧 Override lint rule for `.d.ts` * ⚡ Use new matcher * ⚡ Update check * 📘 Improve typings * ⚡ Adjust instance risk check * ✏️ Rename `execution` → `nodes` in Public API schema * ✏️ Add clarifying comment * ✏️ Fix typo * ⚡ Validate categories in CLI command * ✏️ Improve naming * ✏️ Make audit reference consistent * 📘 Fix typing * ⚡ Use `finally` in CLI command
100 lines
2.5 KiB
TypeScript
100 lines
2.5 KiB
TypeScript
import { v4 as uuid } from 'uuid';
|
|
import * as Db from '@/Db';
|
|
import { audit } from '@/audit';
|
|
import * as packageModel from '@/CommunityNodes/packageModel';
|
|
import { OFFICIAL_RISKY_NODE_TYPES, NODES_REPORT } from '@/audit/constants';
|
|
import { getRiskSection, MOCK_PACKAGE, saveManualTriggerWorkflow } from './utils';
|
|
import * as testDb from '../shared/testDb';
|
|
import { toReportTitle } from '@/audit/utils';
|
|
|
|
let testDbName = '';
|
|
|
|
beforeAll(async () => {
|
|
const initResult = await testDb.init();
|
|
testDbName = initResult.testDbName;
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await testDb.truncate(['Workflow'], testDbName);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await testDb.terminate(testDbName);
|
|
});
|
|
|
|
test('should report risky official nodes', async () => {
|
|
const map = [...OFFICIAL_RISKY_NODE_TYPES].reduce<{ [nodeType: string]: string }>((acc, cur) => {
|
|
return (acc[cur] = uuid()), acc;
|
|
}, {});
|
|
|
|
const promises = Object.entries(map).map(async ([nodeType, nodeId]) => {
|
|
const details = {
|
|
name: 'My Test Workflow',
|
|
active: false,
|
|
connections: {},
|
|
nodeTypes: {},
|
|
nodes: [
|
|
{
|
|
id: nodeId,
|
|
name: 'My Node',
|
|
type: nodeType,
|
|
typeVersion: 1,
|
|
position: [0, 0] as [number, number],
|
|
},
|
|
],
|
|
};
|
|
|
|
return Db.collections.Workflow.save(details);
|
|
});
|
|
|
|
await Promise.all(promises);
|
|
|
|
const testAudit = await audit(['nodes']);
|
|
|
|
const section = getRiskSection(
|
|
testAudit,
|
|
NODES_REPORT.RISK,
|
|
NODES_REPORT.SECTIONS.OFFICIAL_RISKY_NODES,
|
|
);
|
|
|
|
expect(section.location).toHaveLength(OFFICIAL_RISKY_NODE_TYPES.size);
|
|
|
|
for (const loc of section.location) {
|
|
if (loc.kind === 'node') {
|
|
expect(loc.nodeId).toBe(map[loc.nodeType]);
|
|
}
|
|
}
|
|
});
|
|
|
|
test('should not report non-risky official nodes', async () => {
|
|
await saveManualTriggerWorkflow();
|
|
|
|
const testAudit = await audit(['nodes']);
|
|
|
|
const report = testAudit?.[toReportTitle('nodes')];
|
|
|
|
if (!report) return;
|
|
|
|
for (const section of report.sections) {
|
|
expect(section.title).not.toBe(NODES_REPORT.SECTIONS.OFFICIAL_RISKY_NODES);
|
|
}
|
|
});
|
|
|
|
test('should report community nodes', async () => {
|
|
jest.spyOn(packageModel, 'getAllInstalledPackages').mockResolvedValueOnce(MOCK_PACKAGE);
|
|
|
|
const testAudit = await audit(['nodes']);
|
|
|
|
const section = getRiskSection(
|
|
testAudit,
|
|
NODES_REPORT.RISK,
|
|
NODES_REPORT.SECTIONS.COMMUNITY_NODES,
|
|
);
|
|
|
|
expect(section.location).toHaveLength(1);
|
|
|
|
if (section.location[0].kind === 'community') {
|
|
expect(section.location[0].nodeType).toBe(MOCK_PACKAGE[0].installedNodes[0].type);
|
|
}
|
|
});
|