mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-14 00:24:07 -08:00
1d27a9e87e
* Add path mapping and response error interfaces * Add error handling and throwing functionality * Refactor error handling into a single function * Re-implement error handling in Hacker News node * Fix linting details * Re-implement error handling in Spotify node * Re-implement error handling in G Suite Admin node * 🚧 create basic setup NodeError * 🚧 add httpCodes * 🚧 add path priolist * 🚧 handle statusCode in error, adjust interfaces * 🚧 fixing type issues w/Ivan * 🚧 add error exploration * 👔 fix linter issues * 🔧 improve object check * 🚧 remove path passing from NodeApiError * 🚧 add multi error + refactor findProperty method * 👔 allow any * 🔧 handle multi error message callback * ⚡ change return type of callback * ⚡ add customCallback to MultiError * 🚧 refactor to use INode * 🔨 handle arrays, continue search after first null property found * 🚫 refactor method access * 🚧 setup NodeErrorView * ⚡ change timestamp to Date.now * 📚 Add documentation for methods and constants * 🚧 change message setting * 🚚 move NodeErrors to workflow * ✨ add new ErrorView for Nodes * 🎨 improve error notification * 🎨 refactor interfaces * ⚡ add WorkflowOperationError, refactor error throwing * 👕 fix linter issues * 🎨 rename param * 🐛 fix handling normal errors * ⚡ add usage of NodeApiError * 🎨 fix throw new error instead of constructor * 🎨 remove unnecessary code/comments * 🎨 adjusted spacing + updated status messages * 🎨 fix tab indentation * ✨ Replace current errors with custom errors (#1576) * ⚡ Introduce NodeApiError in catch blocks * ⚡ Introduce NodeOperationError in nodes * ⚡ Add missing errors and remove incompatible * ⚡ Fix NodeOperationError in incompatible nodes * 🔧 Adjust error handling in missed nodes PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes * 🔨 Adjust Strava Trigger node error handling * 🔨 Adjust AWS nodes error handling * 🔨 Remove duplicate instantiation of NodeApiError * 🐛 fix strava trigger node error handling * Add XML parsing to NodeApiError constructor (#1633) * 🐛 Remove type annotation from catch variable * ✨ Add XML parsing to NodeApiError * ⚡ Simplify error handling in Rekognition node * ⚡ Pass in XML flag in generic functions * 🔥 Remove try/catch wrappers at call sites * 🔨 Refactor setting description from XML * 🔨 Refactor let to const in resource loaders * ⚡ Find property in parsed XML * ⚡ Change let to const * 🔥 Remove unneeded try/catch block * 👕 Fix linting issues * 🐛 Fix errors from merge conflict resolution * ⚡ Add custom errors to latest contributions * 👕 Fix linting issues * ⚡ Refactor MongoDB helpers for custom errors * 🐛 Correct custom error type * ⚡ Apply feedback to A nodes * ⚡ Apply feedback to missed A node * ⚡ Apply feedback to B-D nodes * ⚡ Apply feedback to E-F nodes * ⚡ Apply feedback to G nodes * ⚡ Apply feedback to H-L nodes * ⚡ Apply feedback to M nodes * ⚡ Apply feedback to P nodes * ⚡ Apply feedback to R nodes * ⚡ Apply feedback to S nodes * ⚡ Apply feedback to T nodes * ⚡ Apply feedback to V-Z nodes * ⚡ Add HTTP code to iterable node error * 🔨 Standardize e as error * 🔨 Standardize err as error * ⚡ Fix error handling for non-standard nodes Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com> Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
126 lines
3.2 KiB
TypeScript
126 lines
3.2 KiB
TypeScript
import { IExecuteFunctions } from 'n8n-core';
|
|
import {
|
|
IBinaryKeyData,
|
|
IDataObject,
|
|
INodeExecutionData,
|
|
INodeType,
|
|
INodeTypeDescription,
|
|
NodeOperationError,
|
|
} from 'n8n-workflow';
|
|
|
|
const { NodeVM } = require('vm2');
|
|
|
|
export class FunctionItem implements INodeType {
|
|
description: INodeTypeDescription = {
|
|
displayName: 'Function Item',
|
|
name: 'functionItem',
|
|
icon: 'fa:code',
|
|
group: ['transform'],
|
|
version: 1,
|
|
description: 'Run custom function code which gets executed once per item.',
|
|
defaults: {
|
|
name: 'FunctionItem',
|
|
color: '#ddbb33',
|
|
},
|
|
inputs: ['main'],
|
|
outputs: ['main'],
|
|
properties: [
|
|
{
|
|
displayName: 'JavaScript Code',
|
|
name: 'functionCode',
|
|
typeOptions: {
|
|
alwaysOpenEditWindow: true,
|
|
editor: 'code',
|
|
rows: 10,
|
|
},
|
|
type: 'string',
|
|
default: 'item.myVariable = 1;\nreturn item;',
|
|
description: 'The JavaScript code to execute for each item.',
|
|
noDataExpression: true,
|
|
},
|
|
],
|
|
};
|
|
|
|
async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
|
|
const items = this.getInputData();
|
|
|
|
const returnData: INodeExecutionData[] = [];
|
|
const length = items.length as unknown as number;
|
|
let item: INodeExecutionData;
|
|
|
|
for (let itemIndex = 0; itemIndex < length; itemIndex++) {
|
|
|
|
item = items[itemIndex];
|
|
|
|
// Copy the items as they may get changed in the functions
|
|
item = JSON.parse(JSON.stringify(item));
|
|
|
|
// Define the global objects for the custom function
|
|
const sandbox = {
|
|
getBinaryData: (): IBinaryKeyData | undefined => {
|
|
return item.binary;
|
|
},
|
|
getNodeParameter: this.getNodeParameter,
|
|
getWorkflowStaticData: this.getWorkflowStaticData,
|
|
helpers: this.helpers,
|
|
item: item.json,
|
|
setBinaryData: (data: IBinaryKeyData) => {
|
|
item.binary = data;
|
|
},
|
|
};
|
|
|
|
// Make it possible to access data via $node, $parameter, ...
|
|
const dataProxy = this.getWorkflowDataProxy(itemIndex);
|
|
Object.assign(sandbox, dataProxy);
|
|
|
|
const options = {
|
|
console: 'inherit',
|
|
sandbox,
|
|
require: {
|
|
external: false as boolean | { modules: string[] },
|
|
builtin: [] as string[],
|
|
},
|
|
};
|
|
|
|
if (process.env.NODE_FUNCTION_ALLOW_BUILTIN) {
|
|
options.require.builtin = process.env.NODE_FUNCTION_ALLOW_BUILTIN.split(',');
|
|
}
|
|
|
|
if (process.env.NODE_FUNCTION_ALLOW_EXTERNAL) {
|
|
options.require.external = { modules: process.env.NODE_FUNCTION_ALLOW_EXTERNAL.split(',') };
|
|
}
|
|
|
|
const vm = new NodeVM(options);
|
|
|
|
// Get the code to execute
|
|
const functionCode = this.getNodeParameter('functionCode', itemIndex) as string;
|
|
|
|
|
|
|
|
let jsonData: IDataObject;
|
|
try {
|
|
// Execute the function code
|
|
jsonData = await vm.run(`module.exports = async function() {${functionCode}}()`, __dirname);
|
|
} catch (error) {
|
|
return Promise.reject(error);
|
|
}
|
|
|
|
// Do very basic validation of the data
|
|
if (jsonData === undefined) {
|
|
throw new NodeOperationError(this.getNode(), 'No data got returned. Always an object has to be returned!');
|
|
}
|
|
|
|
const returnItem: INodeExecutionData = {
|
|
json: jsonData,
|
|
};
|
|
|
|
if (item.binary) {
|
|
returnItem.binary = item.binary;
|
|
}
|
|
|
|
returnData.push(returnItem);
|
|
}
|
|
return this.prepareOutputData(returnData);
|
|
}
|
|
}
|