mirror of
https://github.com/n8n-io/n8n.git
synced 2024-09-21 15:27:32 -07:00
6d6e2488c6
Depends on: #7092 | Story: [PAY-768](https://linear.app/n8n/issue/PAY-768) This PR: - Generalizes the `IBinaryDataManager` interface. - Adjusts `Filesystem.ts` to satisfy the interface. - Sets up an S3 client stub to be filled in in the next PR. - Turns `BinaryDataManager` into an injectable service. - Adjusts the config schema and adds new validators. Note that the PR looks large but all the main changes are in `packages/core/src/binaryData`. Out of scope: - `BinaryDataManager` (now `BinaryDataService`) and `Filesystem.ts` (now `fs.client.ts`) were slightly refactored for maintainability, but fully overhauling them is **not** the focus of this PR, which is meant to clear the way for the S3 implementation. Future improvements for these two should include setting up a backwards-compatible dir structure that makes it easier to locate binary data files to delete, removing duplication, simplifying cloning methods, using integers for binary data size instead of `prettyBytes()`, writing tests for existing binary data logic, etc. --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
46 lines
1 KiB
TypeScript
46 lines
1 KiB
TypeScript
import nock from 'nock';
|
|
import {
|
|
setup,
|
|
equalityTest,
|
|
workflowToTests,
|
|
getWorkflowFilenames,
|
|
initBinaryDataService,
|
|
} from '@test/nodes/Helpers';
|
|
|
|
describe('Test Binary Data Download', () => {
|
|
const workflows = getWorkflowFilenames(__dirname);
|
|
const tests = workflowToTests(workflows);
|
|
|
|
const baseUrl = 'https://dummy.domain';
|
|
|
|
beforeAll(async () => {
|
|
await initBinaryDataService();
|
|
|
|
nock.disableNetConnect();
|
|
|
|
nock(baseUrl)
|
|
.persist()
|
|
.get('/path/to/image.png')
|
|
.reply(200, Buffer.from('test'), { 'content-type': 'image/png' });
|
|
|
|
nock(baseUrl)
|
|
.persist()
|
|
.get('/redirect-to-image')
|
|
.reply(302, {}, { location: baseUrl + '/path/to/image.png' });
|
|
|
|
nock(baseUrl).persist().get('/custom-content-disposition').reply(200, Buffer.from('testing'), {
|
|
'content-disposition': 'attachment; filename="testing.jpg"',
|
|
});
|
|
});
|
|
|
|
afterAll(() => {
|
|
nock.restore();
|
|
});
|
|
|
|
const nodeTypes = setup(tests);
|
|
|
|
for (const testData of tests) {
|
|
test(testData.description, async () => equalityTest(testData, nodeTypes));
|
|
}
|
|
});
|