mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 17:14:05 -08:00
d143f3f2ec
* adds ExecutionEvents view modal to ExecutionList * fix time rendering and remove wf column * checks for unfinished executions and fails them * prevent re-setting stoppedAt for execution * some cleanup / manually create rundata after crash * quicksave * remove Threads lib, log worker rewrite * cleanup comment * fix sentry destination return value * test for tests... * run tests with single worker * fix tests * remove console log * add endpoint for execution data recovery * lint cleanup and some refactoring * fix accidental recursion * remove cyclic imports * add rundata recovery to Workflowrunner * remove comments * cleanup and refactor * adds a status field to executions * setExecutionStatus on queued worker * fix onWorkflowPostExecute * set waiting from worker * get crashed status into frontend * remove comment * merge fix * cleanup * catch empty rundata in recovery * refactor IExecutionsSummary and inject nodeExecution Errors * reduce default event log size to 10mb from 100mb * add per node execution status * lint fix * merge and lint fix * phrasing change * improve preview rendering and messaging * remove debug * Improve partial rundata recovery * fix labels * fix line through * send manual rundata to ui at crash * some type and msg push fixes * improve recovered item rendering in preview * update workflowStatistics on recover * merge fix * review fixes * merge fix * notify eventbus when ui is back up * add a small timeout to make sure the UI is back up * increase reconnect timeout to 30s * adjust recover timeout and ui connection lost msg * do not stop execution in editor after x reconnects * add executionRecovered push event * fix recovered connection not green * remove reconnect toast and merge existing rundata * merge editor and recovered data for own mode
405 lines
13 KiB
TypeScript
405 lines
13 KiB
TypeScript
import express from 'express';
|
|
import config from '@/config';
|
|
import axios from 'axios';
|
|
import syslog from 'syslog-client';
|
|
import * as utils from './shared/utils';
|
|
import * as testDb from './shared/testDb';
|
|
import { Role } from '@db/entities/Role';
|
|
import { User } from '@db/entities/User';
|
|
import {
|
|
defaultMessageEventBusDestinationSentryOptions,
|
|
defaultMessageEventBusDestinationSyslogOptions,
|
|
defaultMessageEventBusDestinationWebhookOptions,
|
|
MessageEventBusDestinationSentryOptions,
|
|
MessageEventBusDestinationSyslogOptions,
|
|
MessageEventBusDestinationWebhookOptions,
|
|
} from 'n8n-workflow';
|
|
import { eventBus } from '@/eventbus';
|
|
import { SuperAgentTest } from 'supertest';
|
|
import { EventMessageGeneric } from '@/eventbus/EventMessageClasses/EventMessageGeneric';
|
|
import { MessageEventBusDestinationSyslog } from '@/eventbus/MessageEventBusDestination/MessageEventBusDestinationSyslog.ee';
|
|
import { MessageEventBusDestinationWebhook } from '@/eventbus/MessageEventBusDestination/MessageEventBusDestinationWebhook.ee';
|
|
import { MessageEventBusDestinationSentry } from '@/eventbus/MessageEventBusDestination/MessageEventBusDestinationSentry.ee';
|
|
import { EventMessageAudit } from '@/eventbus/EventMessageClasses/EventMessageAudit';
|
|
import { v4 as uuid } from 'uuid';
|
|
import { EventNamesTypes } from '../../src/eventbus/EventMessageClasses';
|
|
|
|
jest.unmock('@/eventbus/MessageEventBus/MessageEventBus');
|
|
jest.mock('axios');
|
|
const mockedAxios = axios as jest.Mocked<typeof axios>;
|
|
jest.mock('syslog-client');
|
|
const mockedSyslog = syslog as jest.Mocked<typeof syslog>;
|
|
|
|
let app: express.Application;
|
|
let globalOwnerRole: Role;
|
|
let owner: User;
|
|
let unAuthOwnerAgent: SuperAgentTest;
|
|
let authOwnerAgent: SuperAgentTest;
|
|
|
|
const testSyslogDestination: MessageEventBusDestinationSyslogOptions = {
|
|
...defaultMessageEventBusDestinationSyslogOptions,
|
|
id: 'b88038f4-0a89-4e94-89a9-658dfdb74539',
|
|
protocol: 'udp',
|
|
label: 'Test Syslog',
|
|
enabled: false,
|
|
subscribedEvents: ['n8n.test.message', 'n8n.audit.user.updated'],
|
|
};
|
|
|
|
const testWebhookDestination: MessageEventBusDestinationWebhookOptions = {
|
|
...defaultMessageEventBusDestinationWebhookOptions,
|
|
id: '88be6560-bfb4-455c-8aa1-06971e9e5522',
|
|
url: 'http://localhost:3456',
|
|
method: `POST`,
|
|
label: 'Test Webhook',
|
|
enabled: false,
|
|
subscribedEvents: ['n8n.test.message', 'n8n.audit.user.updated'],
|
|
};
|
|
const testSentryDestination: MessageEventBusDestinationSentryOptions = {
|
|
...defaultMessageEventBusDestinationSentryOptions,
|
|
id: '450ca04b-87dd-4837-a052-ab3a347a00e9',
|
|
dsn: 'http://localhost:3000',
|
|
label: 'Test Sentry',
|
|
enabled: false,
|
|
subscribedEvents: ['n8n.test.message', 'n8n.audit.user.updated'],
|
|
};
|
|
|
|
async function confirmIdInAll(id: string) {
|
|
const sent = await eventBus.getEventsAll();
|
|
expect(sent.length).toBeGreaterThan(0);
|
|
expect(sent.find((msg) => msg.id === id)).toBeTruthy();
|
|
}
|
|
|
|
async function confirmIdSent(id: string) {
|
|
const sent = await eventBus.getEventsSent();
|
|
expect(sent.length).toBeGreaterThan(0);
|
|
expect(sent.find((msg) => msg.id === id)).toBeTruthy();
|
|
}
|
|
|
|
beforeAll(async () => {
|
|
app = await utils.initTestServer({ endpointGroups: ['eventBus'] });
|
|
|
|
globalOwnerRole = await testDb.getGlobalOwnerRole();
|
|
owner = await testDb.createUser({ globalRole: globalOwnerRole });
|
|
|
|
unAuthOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'internal',
|
|
auth: false,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
authOwnerAgent = utils.createAgent(app, {
|
|
apiPath: 'internal',
|
|
auth: true,
|
|
user: owner,
|
|
version: 1,
|
|
});
|
|
|
|
mockedSyslog.createClient.mockImplementation(() => new syslog.Client());
|
|
|
|
utils.initConfigFile();
|
|
config.set('eventBus.logWriter.logBaseName', 'n8n-test-logwriter');
|
|
config.set('eventBus.logWriter.keepLogCount', '1');
|
|
config.set('enterprise.features.logStreaming', true);
|
|
|
|
await eventBus.initialize();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
config.set('userManagement.disabled', false);
|
|
config.set('userManagement.isInstanceOwnerSetUp', true);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
jest.mock('@/eventbus/MessageEventBus/MessageEventBus');
|
|
await testDb.terminate();
|
|
await eventBus.close();
|
|
});
|
|
|
|
test('should have a running logwriter process', () => {
|
|
const thread = eventBus.logWriter.worker;
|
|
expect(thread).toBeDefined();
|
|
});
|
|
|
|
test('should have logwriter log messages', async () => {
|
|
const testMessage = new EventMessageGeneric({
|
|
eventName: 'n8n.test.message' as EventNamesTypes,
|
|
id: uuid(),
|
|
});
|
|
await eventBus.send(testMessage);
|
|
await new Promise((resolve) => {
|
|
eventBus.logWriter.worker?.once('message', async (msg: { command: string; data: any }) => {
|
|
expect(msg.command).toBe('appendMessageToLog');
|
|
expect(msg.data).toBe(true);
|
|
await confirmIdInAll(testMessage.id);
|
|
resolve(true);
|
|
});
|
|
});
|
|
});
|
|
|
|
test('GET /eventbus/destination should fail due to missing authentication', async () => {
|
|
const response = await unAuthOwnerAgent.get('/eventbus/destination');
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
test('POST /eventbus/destination create syslog destination', async () => {
|
|
const response = await authOwnerAgent.post('/eventbus/destination').send(testSyslogDestination);
|
|
expect(response.statusCode).toBe(200);
|
|
});
|
|
|
|
test('POST /eventbus/destination create sentry destination', async () => {
|
|
const response = await authOwnerAgent.post('/eventbus/destination').send(testSentryDestination);
|
|
expect(response.statusCode).toBe(200);
|
|
});
|
|
|
|
test('POST /eventbus/destination create webhook destination', async () => {
|
|
const response = await authOwnerAgent.post('/eventbus/destination').send(testWebhookDestination);
|
|
expect(response.statusCode).toBe(200);
|
|
});
|
|
|
|
test('GET /eventbus/destination all returned destinations should exist in eventbus', async () => {
|
|
const response = await authOwnerAgent.get('/eventbus/destination');
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const data = response.body.data;
|
|
expect(data).toBeTruthy();
|
|
expect(Array.isArray(data)).toBeTruthy();
|
|
|
|
for (let index = 0; index < data.length; index++) {
|
|
const destination = data[index];
|
|
const foundDestinations = await eventBus.findDestination(destination.id);
|
|
expect(Array.isArray(foundDestinations)).toBeTruthy();
|
|
expect(foundDestinations.length).toBe(1);
|
|
expect(foundDestinations[0].label).toBe(destination.label);
|
|
}
|
|
});
|
|
|
|
// this test (presumably the mocking) is causing the test suite to randomly fail
|
|
test.skip('should send message to syslog', async () => {
|
|
const testMessage = new EventMessageGeneric({
|
|
eventName: 'n8n.test.message' as EventNamesTypes,
|
|
id: uuid(),
|
|
});
|
|
config.set('enterprise.features.logStreaming', true);
|
|
|
|
const syslogDestination = eventBus.destinations[
|
|
testSyslogDestination.id!
|
|
] as MessageEventBusDestinationSyslog;
|
|
|
|
syslogDestination.enable();
|
|
|
|
const mockedSyslogClientLog = jest.spyOn(syslogDestination.client, 'log');
|
|
mockedSyslogClientLog.mockImplementation((_m, _options, _cb) => {
|
|
eventBus.confirmSent(testMessage, {
|
|
id: syslogDestination.id,
|
|
name: syslogDestination.label,
|
|
});
|
|
return syslogDestination.client;
|
|
});
|
|
|
|
await eventBus.send(testMessage);
|
|
await new Promise((resolve) => {
|
|
eventBus.logWriter.worker?.on(
|
|
'message',
|
|
async function handler001(msg: { command: string; data: any }) {
|
|
if (msg.command === 'appendMessageToLog') {
|
|
await confirmIdInAll(testMessage.id);
|
|
} else if (msg.command === 'confirmMessageSent') {
|
|
await confirmIdSent(testMessage.id);
|
|
expect(mockedSyslogClientLog).toHaveBeenCalled();
|
|
syslogDestination.disable();
|
|
eventBus.logWriter.worker?.removeListener('message', handler001);
|
|
resolve(true);
|
|
}
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
test.skip('should confirm send message if there are no subscribers', async () => {
|
|
const testMessageUnsubscribed = new EventMessageGeneric({
|
|
eventName: 'n8n.test.unsub' as EventNamesTypes,
|
|
id: uuid(),
|
|
});
|
|
config.set('enterprise.features.logStreaming', true);
|
|
|
|
const syslogDestination = eventBus.destinations[
|
|
testSyslogDestination.id!
|
|
] as MessageEventBusDestinationSyslog;
|
|
|
|
syslogDestination.enable();
|
|
|
|
await eventBus.send(testMessageUnsubscribed);
|
|
|
|
await new Promise((resolve) => {
|
|
eventBus.logWriter.worker?.on(
|
|
'message',
|
|
async function handler002(msg: { command: string; data: any }) {
|
|
if (msg.command === 'appendMessageToLog') {
|
|
await confirmIdInAll(testMessageUnsubscribed.id);
|
|
} else if (msg.command === 'confirmMessageSent') {
|
|
await confirmIdSent(testMessageUnsubscribed.id);
|
|
syslogDestination.disable();
|
|
eventBus.logWriter.worker?.removeListener('message', handler002);
|
|
resolve(true);
|
|
}
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
test('should anonymize audit message to syslog ', async () => {
|
|
const testAuditMessage = new EventMessageAudit({
|
|
eventName: 'n8n.audit.user.updated',
|
|
payload: {
|
|
_secret: 'secret',
|
|
public: 'public',
|
|
},
|
|
id: uuid(),
|
|
});
|
|
config.set('enterprise.features.logStreaming', true);
|
|
|
|
const syslogDestination = eventBus.destinations[
|
|
testSyslogDestination.id!
|
|
] as MessageEventBusDestinationSyslog;
|
|
|
|
syslogDestination.enable();
|
|
|
|
const mockedSyslogClientLog = jest.spyOn(syslogDestination.client, 'log');
|
|
mockedSyslogClientLog.mockImplementation((m, _options, _cb) => {
|
|
const o = JSON.parse(m);
|
|
expect(o).toHaveProperty('payload');
|
|
expect(o.payload).toHaveProperty('_secret');
|
|
syslogDestination.anonymizeAuditMessages
|
|
? expect(o.payload._secret).toBe('*')
|
|
: expect(o.payload._secret).toBe('secret');
|
|
expect(o.payload).toHaveProperty('public');
|
|
expect(o.payload.public).toBe('public');
|
|
return syslogDestination.client;
|
|
});
|
|
|
|
syslogDestination.anonymizeAuditMessages = true;
|
|
await eventBus.send(testAuditMessage);
|
|
await new Promise((resolve) => {
|
|
eventBus.logWriter.worker?.on(
|
|
'message',
|
|
async function handler005(msg: { command: string; data: any }) {
|
|
if (msg.command === 'appendMessageToLog') {
|
|
const sent = await eventBus.getEventsAll();
|
|
await confirmIdInAll(testAuditMessage.id);
|
|
expect(mockedSyslogClientLog).toHaveBeenCalled();
|
|
eventBus.logWriter.worker?.removeListener('message', handler005);
|
|
resolve(true);
|
|
}
|
|
},
|
|
);
|
|
});
|
|
|
|
syslogDestination.anonymizeAuditMessages = false;
|
|
await eventBus.send(testAuditMessage);
|
|
await new Promise((resolve) => {
|
|
eventBus.logWriter.worker?.on(
|
|
'message',
|
|
async function handler006(msg: { command: string; data: any }) {
|
|
if (msg.command === 'appendMessageToLog') {
|
|
const sent = await eventBus.getEventsAll();
|
|
await confirmIdInAll(testAuditMessage.id);
|
|
expect(mockedSyslogClientLog).toHaveBeenCalled();
|
|
syslogDestination.disable();
|
|
eventBus.logWriter.worker?.removeListener('message', handler006);
|
|
resolve(true);
|
|
}
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
test('should send message to webhook ', async () => {
|
|
const testMessage = new EventMessageGeneric({
|
|
eventName: 'n8n.test.message' as EventNamesTypes,
|
|
id: uuid(),
|
|
});
|
|
config.set('enterprise.features.logStreaming', true);
|
|
|
|
const webhookDestination = eventBus.destinations[
|
|
testWebhookDestination.id!
|
|
] as MessageEventBusDestinationWebhook;
|
|
|
|
webhookDestination.enable();
|
|
|
|
mockedAxios.post.mockResolvedValue({ status: 200, data: { msg: 'OK' } });
|
|
mockedAxios.request.mockResolvedValue({ status: 200, data: { msg: 'OK' } });
|
|
|
|
await eventBus.send(testMessage);
|
|
await new Promise((resolve) => {
|
|
eventBus.logWriter.worker?.on(
|
|
'message',
|
|
async function handler003(msg: { command: string; data: any }) {
|
|
if (msg.command === 'appendMessageToLog') {
|
|
await confirmIdInAll(testMessage.id);
|
|
} else if (msg.command === 'confirmMessageSent') {
|
|
await confirmIdSent(testMessage.id);
|
|
expect(mockedAxios.request).toHaveBeenCalled();
|
|
webhookDestination.disable();
|
|
eventBus.logWriter.worker?.removeListener('message', handler003);
|
|
resolve(true);
|
|
}
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
test('should send message to sentry ', async () => {
|
|
const testMessage = new EventMessageGeneric({
|
|
eventName: 'n8n.test.message' as EventNamesTypes,
|
|
id: uuid(),
|
|
});
|
|
config.set('enterprise.features.logStreaming', true);
|
|
|
|
const sentryDestination = eventBus.destinations[
|
|
testSentryDestination.id!
|
|
] as MessageEventBusDestinationSentry;
|
|
|
|
sentryDestination.enable();
|
|
|
|
const mockedSentryCaptureMessage = jest.spyOn(sentryDestination.sentryClient!, 'captureMessage');
|
|
mockedSentryCaptureMessage.mockImplementation((_m, _level, _hint, _scope) => {
|
|
eventBus.confirmSent(testMessage, {
|
|
id: sentryDestination.id,
|
|
name: sentryDestination.label,
|
|
});
|
|
return testMessage.id;
|
|
});
|
|
|
|
await eventBus.send(testMessage);
|
|
await new Promise((resolve) => {
|
|
eventBus.logWriter.worker?.on(
|
|
'message',
|
|
async function handler004(msg: { command: string; data: any }) {
|
|
if (msg.command === 'appendMessageToLog') {
|
|
await confirmIdInAll(testMessage.id);
|
|
} else if (msg.command === 'confirmMessageSent') {
|
|
await confirmIdSent(testMessage.id);
|
|
expect(mockedSentryCaptureMessage).toHaveBeenCalled();
|
|
sentryDestination.disable();
|
|
eventBus.logWriter.worker?.removeListener('message', handler004);
|
|
resolve(true);
|
|
}
|
|
},
|
|
);
|
|
});
|
|
});
|
|
|
|
test('DEL /eventbus/destination delete all destinations by id', async () => {
|
|
const existingDestinationIds = [...Object.keys(eventBus.destinations)];
|
|
|
|
await Promise.all(
|
|
existingDestinationIds.map(async (id) => {
|
|
const response = await authOwnerAgent.del('/eventbus/destination').query({ id });
|
|
expect(response.statusCode).toBe(200);
|
|
}),
|
|
);
|
|
|
|
expect(Object.keys(eventBus.destinations).length).toBe(0);
|
|
});
|