mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-25 20:54:07 -08:00
dd6a4c956a
* feat: remove vue-fragment (no-changelog)
* feat: partial design-system migration
* feat: migrate info-accordion and info-tip components
* feat: migrate several components to vue 3
* feat: migrated several components
* feat: migrate several components
* feat: migrate several components
* feat: migrate several components
* feat: re-exported all design system components
* fix: fix design for popper components
* fix: editor kind of working, lots of issues to fix
* fix: fix several vue 3 migration issues
* fix: replace @change with @update:modelValue in several places
* fix: fix translation linking
* fix: fix inline-edit input
* fix: fix ndv and dialog design
* fix: update parameter input event bindings
* fix: rename deprecated lifecycle methods
* fix: fix json view mapping
* build: update lock file
* fix(editor): revisit last conflict with master and fix issues
* fix(editor): revisit last conflict with master and fix issues
* fix: fix expression editor bug causing code mirror to no longer be reactive
* fix: fix resource locator bug
* fix: fix vue-agile integration
* fix: remove global import for vue-agile
* fix: replace element-plus buttons with n8n-buttons everywhere
* fix(editor): Fix various element-plus styles (#6571)
* fix(editor): Fix various element-plus styles
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove debugging code
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): Fix loading in production mode [Vue 3] (#6578)
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix(editor): First round of e2e tests fixes with Vue 3 (#6579)
* fix(editor): Fix broken smoke and workflow list e2e tests
* ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests
* feat: add vue 3 eslint rules and fix issues
* fix: fix tags-dropdown
* fix: fix white-space issues caused by i18n-t
* fix: rename non-generic click events
* fix: fix search in resources list layout
* fix: fix datatable paginator
* fix: fix popper select caret and dropdown size
* fix: add width to action-dropdown
* fix: fix workflow settings icon not being hidden
* fix: refactor newly added code
* fix: fix merge issue
* fix: fix ndv credentials watcher
* fix: fix workflow saving and grabber notch
* fix: fix nodes list panel transition
* fix: fix node title visibility
* fix: fix data unpinning
* fix: fix value access
* fix: show input panel only if trigger panel enabled or not trigger node
* fix: fix tags dropdown and executions status spcing
* fix(editor): Prevent execution list to load back when leaving the route (#6697)
fix(editor): prevent execution list to load back when leaving the route
* fix: fix drawer visibility
* fix: fix expression toggle padding
* fix: fix expressions editor styling
* chore: prepare for testing
* fix: fix styling for el-button without patching
* test: fix unit tests in design-system
* test: fix most unit tests
* fix: remove import cycle.
* fix: fix personalization modal tests
* fix further resource mapper test adjustments
* fix: fix multiple tests and n8n-route attr duplication
* fix: fix source control tets
* fix: fixed remaining unit tests
* fix: fix workflows and credentials e2e tests
* fix: fix localizeNodeNames
* fix: update ndv e2e tests
* fix: fix popper left placement arrow
* fix: fix 5-ndv e2e tests
* fix: fix 6-code-node e2e tests
* fix(editor): Drop click outside directive from NodeCreator (#6716)
* fix(editor): Drop click outside directive from NodeCreator
* fix(editor): make sure mouseup outside is unbound at least before the component is unmounted
* fix: fix 10-settings-log-streaming e2e tests
* fix: fix node redrawing
* fix: fix tooltip buttons styling
* fix: fix varous e2e suites
* fix: fix 15-scheduler-node e2e suite
* fix: fix route watcher
* fix: fixed param name update and credential edit
* feat: update event names
* refactor: Remove deprecated `$data` (#6576)
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix: fix 17-sharing e2e suite
* fix: fix tags dropdown
* fix: fix tags manager
* fix(editor): move :deep selectors to a separate scoped style block
* fix: fix sticky component and inline text edit
* fix: update e2e tests
* fix: remove button override references
* fix(editor): Adjust spacing in templates for Vue 3 (#6744)
* fix(editor): Adjust spacing in templates
* fix: Undo unneeded change
* fix: Undo unneeded change
* fix(editor): Adjust NDV height for Vue 3 (#6742)
fix(editor): Adjust NDV height
* fix(editor): Restore collapsed sidebar items for Vue 3 (#6743)
fix(editor): Restore collapsed sidebar items
* fix: fix linting issues
* fix: fix design-system deps
* fix: post-merge fixes
* fix: update tests
* fix: increase timeout for executionslist tets
* chore: fix linting issue
* fix: fix 14-mapping e2e tests in ci
* fix: re-enable tests
* fix: fix workflow duplication e2e tests after tags update
* fix(editor): Change component prop to be typed
* fix: fix tags dropdown in duplicate wf modal
* fix: fix focus behaviour in tags selector
* fix: fix tag creation
* fix: fix log streaming e2e race condition
* fix(editor): Fix Vue 3 linting issues (#6748)
* fix(editor): Fix Vue 3 linting issues
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix MainSidebar linter issues
* revert pnpm lock
* update pnpm lock file
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Some css fixes for vue3 branch (#6749)
* ✨ Fixing filter button height
* ✨ Update input modal button position
* ✨ Updating tags styling
* ✨ Fix event logging settings spacing
* 👕 Fixing lint errors
* fix: fix linting issues
* Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix css issue
* fix(editor): Lint fix
* fix(editor): Fix settings initialisation (#6750)
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* fix: fix initial settings loading
* fix: replace realClick with click force
* fix: fix randomly failing mapping e2e tests
* fix(editor): Fix menu item event handling
* fix: fix resource filters dropdown events (#6752)
* fix: fix resource filters dropdown events
* fix: remove teleported:false
* fix: fix event selection event naming (#6753)
* fix: removed console.log (#6754)
* fix: rever await nextTick changes
* fix: redo linting changes
* fix(editor): Redraw node connections if adding more than one node to canvas (#6755)
* fix(editor): Redraw node connections if adding more than one node to canvas
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Update position before connection two nodes
* Lint fix
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
* fix(editor): Fix `ResourceMapper` unit tests (#6758)
* ✔️ Fix matching columns test
* ✔️ Fix multiple matching columns test
* ✔️ Removing `skip` from the last test
* fix: Allow pasting a big workflow (#6760)
* fix: pasting a big workflow
* chore: update comment
* refactor: move try/catch to function
* refactor: move try/catch to function
* fix(editor): Fix modal layer width
* fix: fix position changes
* fix: undo it.only
* fix: make undo/redo multiple steps more verbose
* fix: Fix value survey styles (#6764)
* fix: fix value survey styles
* fix: lint
* Revert "fix: lint"
72869c431f
* fix: lint
* fix(editor): Fix collapsed sub menu
* fix: Fix drawer animation (#6767)
fix: drawer animation
* fix(editor): Fix source control buttons (#6769)
* fix(editor): Fix App loading & auth (#6768)
* fix(editor): Fix App loading & auth
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Await promises
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix eslint error
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Co-authored-by: OlegIvaniv <me@olegivaniv.com>
Co-authored-by: Milorad FIlipović <milorad@n8n.io>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
254 lines
10 KiB
TypeScript
254 lines
10 KiB
TypeScript
import {
|
|
CODE_NODE_NAME,
|
|
MANUAL_TRIGGER_NODE_NAME,
|
|
META_KEY,
|
|
SCHEDULE_TRIGGER_NODE_NAME,
|
|
} from '../constants';
|
|
import { WorkflowPage as WorkflowPageClass } from '../pages/workflow';
|
|
import { WorkflowsPage as WorkflowsPageClass } from '../pages/workflows';
|
|
import { getVisibleDropdown, getVisibleSelect } from '../utils';
|
|
|
|
const NEW_WORKFLOW_NAME = 'Something else';
|
|
const IMPORT_WORKFLOW_URL =
|
|
'https://gist.githubusercontent.com/OlegIvaniv/010bd3f45c8a94f8eb7012e663a8b671/raw/3afea1aec15573cc168d9af7e79395bd76082906/test-workflow.json';
|
|
const DUPLICATE_WORKFLOW_NAME = 'Duplicated workflow';
|
|
const DUPLICATE_WORKFLOW_TAG = 'Duplicate';
|
|
|
|
const WorkflowPage = new WorkflowPageClass();
|
|
const WorkflowPages = new WorkflowsPageClass();
|
|
|
|
describe('Workflow Actions', () => {
|
|
beforeEach(() => {
|
|
WorkflowPage.actions.visit();
|
|
});
|
|
|
|
it('should be able to save on button click', () => {
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
WorkflowPage.getters.isWorkflowSaved();
|
|
});
|
|
|
|
it('should save workflow on keyboard shortcut', () => {
|
|
WorkflowPage.actions.saveWorkflowUsingKeyboardShortcut();
|
|
WorkflowPage.getters.isWorkflowSaved();
|
|
});
|
|
|
|
it('should not be able to activate unsaved workflow', () => {
|
|
WorkflowPage.getters.activatorSwitch().find('input').first().should('be.disabled');
|
|
});
|
|
|
|
it('should not be able to activate workflow without trigger node', () => {
|
|
// Manual trigger is not enough to activate the workflow
|
|
WorkflowPage.actions.addNodeToCanvas(MANUAL_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
WorkflowPage.getters.activatorSwitch().find('input').first().should('be.disabled');
|
|
});
|
|
|
|
it('should be able to activate workflow', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
WorkflowPage.actions.activateWorkflow();
|
|
WorkflowPage.getters.isWorkflowActivated();
|
|
});
|
|
|
|
it('should save new workflow after renaming', () => {
|
|
WorkflowPage.actions.renameWorkflow(NEW_WORKFLOW_NAME);
|
|
WorkflowPage.getters.isWorkflowSaved();
|
|
});
|
|
|
|
it('should rename workflow', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
WorkflowPage.actions.renameWorkflow(NEW_WORKFLOW_NAME);
|
|
WorkflowPage.getters.isWorkflowSaved();
|
|
WorkflowPage.getters
|
|
.workflowNameInputContainer()
|
|
.invoke('attr', 'title')
|
|
.should('eq', NEW_WORKFLOW_NAME);
|
|
});
|
|
|
|
it('should not save workflow if canvas is loading', () => {
|
|
let interceptCalledCount = 0;
|
|
|
|
// There's no way in Cypress to check if intercept was not called
|
|
// so we'll count the number of times it was called
|
|
cy.intercept('PATCH', '/rest/workflows/*', () => {
|
|
interceptCalledCount++;
|
|
}).as('saveWorkflow');
|
|
|
|
WorkflowPage.actions.addNodeToCanvas(MANUAL_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
cy.intercept(
|
|
{
|
|
url: '/rest/workflows/*',
|
|
method: 'GET',
|
|
middleware: true,
|
|
},
|
|
(req) => {
|
|
// Delay the response to give time for the save to be triggered
|
|
req.on('response', async (res) => {
|
|
await new Promise((resolve) => setTimeout(resolve, 2000));
|
|
res.send();
|
|
});
|
|
},
|
|
);
|
|
cy.reload();
|
|
cy.get('.el-loading-mask').should('exist');
|
|
cy.get('body').type(META_KEY, { release: false }).type('s');
|
|
cy.get('body').type(META_KEY, { release: false }).type('s');
|
|
cy.get('body').type(META_KEY, { release: false }).type('s');
|
|
cy.wrap(null).then(() => expect(interceptCalledCount).to.eq(0));
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
cy.get('body').type(META_KEY, { release: false }).type('s');
|
|
cy.wait('@saveWorkflow');
|
|
cy.wrap(null).then(() => expect(interceptCalledCount).to.eq(1));
|
|
});
|
|
it('should copy nodes', () => {
|
|
WorkflowPage.actions.addNodeToCanvas(SCHEDULE_TRIGGER_NODE_NAME);
|
|
WorkflowPage.actions.addNodeToCanvas(CODE_NODE_NAME);
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
|
|
cy.get('#node-creator').should('not.exist');
|
|
cy.get('body').type(META_KEY, { delay: 500, release: false }).type('a');
|
|
cy.get('.jtk-drag-selected').should('have.length', 2);
|
|
cy.get('body').type(META_KEY, { delay: 500, release: false }).type('c');
|
|
WorkflowPage.getters.successToast().should('exist');
|
|
});
|
|
|
|
it('should paste nodes', () => {
|
|
cy.fixture('Test_workflow-actions_paste-data.json').then((data) => {
|
|
cy.get('body').paste(JSON.stringify(data));
|
|
WorkflowPage.getters.canvasNodes().should('have.have.length', 2);
|
|
});
|
|
});
|
|
|
|
it('should import workflow from url', () => {
|
|
WorkflowPage.getters.workflowMenu().should('be.visible');
|
|
WorkflowPage.getters.workflowMenu().click();
|
|
WorkflowPage.getters.workflowMenuItemImportFromURLItem().should('be.visible');
|
|
WorkflowPage.getters.workflowMenuItemImportFromURLItem().click();
|
|
cy.get('.el-message-box').should('be.visible');
|
|
cy.get('.el-message-box').find('input').type(IMPORT_WORKFLOW_URL);
|
|
cy.get('body').type('{enter}');
|
|
cy.waitForLoad(false);
|
|
WorkflowPage.actions.zoomToFit();
|
|
WorkflowPage.getters.canvasNodes().should('have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
});
|
|
|
|
it('should import workflow from file', () => {
|
|
WorkflowPage.getters
|
|
.workflowImportInput()
|
|
.selectFile('cypress/fixtures/Test_workflow-actions_paste-data.json', { force: true });
|
|
cy.waitForLoad(false);
|
|
WorkflowPage.actions.zoomToFit();
|
|
WorkflowPage.getters.canvasNodes().should('have.length', 2);
|
|
WorkflowPage.getters.nodeConnections().should('have.length', 1);
|
|
});
|
|
|
|
it('should update workflow settings', () => {
|
|
cy.visit(WorkflowPages.url);
|
|
WorkflowPages.getters.workflowCards().then((cards) => {
|
|
const totalWorkflows = cards.length;
|
|
|
|
WorkflowPage.actions.visit();
|
|
// Open settings dialog
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
WorkflowPage.getters.workflowMenu().should('be.visible');
|
|
WorkflowPage.getters.workflowMenu().click();
|
|
WorkflowPage.getters.workflowMenuItemSettings().should('be.visible');
|
|
WorkflowPage.getters.workflowMenuItemSettings().click();
|
|
// Change all settings
|
|
// totalWorkflows + 1 (current workflow) + 1 (no workflow option)
|
|
WorkflowPage.getters.workflowSettingsErrorWorkflowSelect().click();
|
|
getVisibleSelect()
|
|
.find('li')
|
|
.should('have.length', totalWorkflows + 2);
|
|
getVisibleSelect().find('li').last().click({ force: true });
|
|
WorkflowPage.getters.workflowSettingsTimezoneSelect().click();
|
|
getVisibleSelect().find('li').should('exist');
|
|
getVisibleSelect().find('li').eq(1).click({ force: true });
|
|
WorkflowPage.getters.workflowSettingsSaveFiledExecutionsSelect().click();
|
|
getVisibleSelect().find('li').should('have.length', 3);
|
|
getVisibleSelect().find('li').last().click({ force: true });
|
|
WorkflowPage.getters.workflowSettingsSaveSuccessExecutionsSelect().click();
|
|
getVisibleSelect().find('li').should('have.length', 3);
|
|
getVisibleSelect().find('li').last().click({ force: true });
|
|
WorkflowPage.getters.workflowSettingsSaveManualExecutionsSelect().click();
|
|
getVisibleSelect().find('li').should('have.length', 3);
|
|
getVisibleSelect().find('li').last().click({ force: true });
|
|
WorkflowPage.getters.workflowSettingsSaveExecutionProgressSelect().click();
|
|
getVisibleSelect().find('li').should('have.length', 3);
|
|
getVisibleSelect().find('li').last().click({ force: true });
|
|
WorkflowPage.getters.workflowSettingsTimeoutWorkflowSwitch().click();
|
|
WorkflowPage.getters.workflowSettingsTimeoutForm().find('input').first().type('1');
|
|
// Save settings
|
|
WorkflowPage.getters.workflowSettingsSaveButton().click();
|
|
WorkflowPage.getters.workflowSettingsModal().should('not.exist');
|
|
WorkflowPage.getters.successToast().should('exist');
|
|
});
|
|
});
|
|
|
|
it('should not be able to delete unsaved workflow', () => {
|
|
WorkflowPage.getters.workflowMenu().should('be.visible');
|
|
WorkflowPage.getters.workflowMenu().click();
|
|
WorkflowPage.getters.workflowMenuItemDelete().closest('li').should('have.class', 'is-disabled');
|
|
});
|
|
|
|
it('should delete workflow', () => {
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
WorkflowPage.getters.workflowMenu().should('be.visible');
|
|
WorkflowPage.getters.workflowMenu().click();
|
|
WorkflowPage.getters.workflowMenuItemDelete().click();
|
|
cy.get('div[role=dialog][aria-modal=true]').should('be.visible');
|
|
cy.get('button.btn--confirm').should('be.visible').click();
|
|
WorkflowPage.getters.successToast().should('exist');
|
|
cy.url().should('include', '/workflow/new');
|
|
});
|
|
|
|
describe('duplicate workflow', () => {
|
|
function duplicateWorkflow() {
|
|
WorkflowPage.getters.workflowMenu().should('be.visible');
|
|
WorkflowPage.getters.workflowMenu().click();
|
|
WorkflowPage.getters.workflowMenuItemDuplicate().click();
|
|
WorkflowPage.getters.duplicateWorkflowModal().should('be.visible');
|
|
WorkflowPage.getters.duplicateWorkflowModal().find('input').first().should('be.visible');
|
|
WorkflowPage.getters.duplicateWorkflowModal().find('input').first().type('{selectall}');
|
|
WorkflowPage.getters
|
|
.duplicateWorkflowModal()
|
|
.find('input')
|
|
.first()
|
|
.type(DUPLICATE_WORKFLOW_NAME);
|
|
WorkflowPage.getters
|
|
.duplicateWorkflowModal()
|
|
.find('.el-select__tags input')
|
|
.type(DUPLICATE_WORKFLOW_TAG);
|
|
WorkflowPage.getters.duplicateWorkflowModal().find('.el-select__tags input').type('{enter}');
|
|
WorkflowPage.getters.duplicateWorkflowModal().find('.el-select__tags input').type('{esc}');
|
|
WorkflowPage.getters
|
|
.duplicateWorkflowModal()
|
|
.find('button')
|
|
.contains('Duplicate')
|
|
.should('be.visible');
|
|
WorkflowPage.getters.duplicateWorkflowModal().find('button').contains('Duplicate').click();
|
|
WorkflowPage.getters.errorToast().should('not.exist');
|
|
}
|
|
|
|
beforeEach(() => {
|
|
// Stub window.open so new tab is not getting opened
|
|
cy.window().then((win) => {
|
|
cy.stub(win, 'open').as('open');
|
|
});
|
|
WorkflowPage.actions.addNodeToCanvas(MANUAL_TRIGGER_NODE_NAME);
|
|
});
|
|
|
|
it('should duplicate unsaved workflow', () => {
|
|
duplicateWorkflow();
|
|
});
|
|
|
|
it('should duplicate saved workflow', () => {
|
|
WorkflowPage.actions.saveWorkflowOnButtonClick();
|
|
duplicateWorkflow();
|
|
});
|
|
});
|
|
});
|