mirror of
https://github.com/n8n-io/n8n.git
synced 2025-02-21 02:56:40 -08:00
f5502cc628
## Summary What: Fix issue of login endpoint returning secret and recovery codes when MFA is enabled. Bug was introduced in this [PR](https://github.com/n8n-io/n8n/pull/6994), specifically in this [line](https://github.com/n8n-io/n8n/pull/6994/files#diff-95a87cb029a3d26e6722df2e68132453fc254fc1f4540cbdaa95cfdbda1893deL91). Why: We should not be filtering the secret and recovery codes Same PR caused the issues on ticket -> https://linear.app/n8n/issue/ADO-1494/on-user-list-copy-password-reset-link-and-copy-invite-link-are-broken ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [x] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [x] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e). |
||
|---|---|---|
| .. | ||
| commands | ||
| environments | ||
| ExternalSecrets | ||
| ldap | ||
| mfa | ||
| middlewares | ||
| publicApi | ||
| saml | ||
| security-audit | ||
| shared | ||
| ActiveWorkflowRunner.test.ts | ||
| auth.api.test.ts | ||
| auth.mw.test.ts | ||
| binaryData.api.test.ts | ||
| community-packages.api.test.ts | ||
| credentials.controller.test.ts | ||
| credentials.ee.test.ts | ||
| credentials.test.ts | ||
| eventbus.ee.test.ts | ||
| eventbus.test.ts | ||
| executions.controller.test.ts | ||
| invitations.api.test.ts | ||
| license.api.test.ts | ||
| me.api.test.ts | ||
| metrics.test.ts | ||
| owner.api.test.ts | ||
| passwordReset.api.test.ts | ||
| pruning.service.test.ts | ||
| role.api.test.ts | ||
| tags.api.test.ts | ||
| users.api.test.ts | ||
| variables.test.ts | ||
| webhooks.api.test.ts | ||
| workflow.service.test.ts | ||
| workflowHistory.api.test.ts | ||
| workflowHistoryManager.test.ts | ||
| workflows.controller.ee.test.ts | ||
| workflows.controller.test.ts | ||