mirror of
https://github.com/n8n-io/n8n.git
synced 2024-11-15 09:04:07 -08:00
2c6ffb0153
- Move webhook, poller and trigger activation logs closer to activation event - Enrich response of `/debug/multi-main-setup` - Ensure workflow updates broadcast activation state changes only if state changed - Fix bug on workflow activation after leadership change - Ensure debug controller is not available in production --------- Co-authored-by: Omar Ajoue <krynble@gmail.com>
112 lines
3.5 KiB
TypeScript
112 lines
3.5 KiB
TypeScript
import Container from 'typedi';
|
|
import { ActiveWorkflowRunner } from '@/ActiveWorkflowRunner';
|
|
import * as testDb from './shared/testDb';
|
|
import { WorkflowService } from '@/workflows/workflow.service';
|
|
import { mockInstance } from '../shared/mocking';
|
|
import { createOwner } from './shared/db/users';
|
|
import { createWorkflow } from './shared/db/workflows';
|
|
import { SharedWorkflowRepository } from '@/databases/repositories/sharedWorkflow.repository';
|
|
import { mock } from 'jest-mock-extended';
|
|
import { WorkflowRepository } from '@/databases/repositories/workflow.repository';
|
|
import { Telemetry } from '@/telemetry';
|
|
import { MultiMainSetup } from '@/services/orchestration/main/MultiMainSetup.ee';
|
|
|
|
let workflowService: WorkflowService;
|
|
let activeWorkflowRunner: ActiveWorkflowRunner;
|
|
let multiMainSetup: MultiMainSetup;
|
|
|
|
beforeAll(async () => {
|
|
await testDb.init();
|
|
|
|
activeWorkflowRunner = mockInstance(ActiveWorkflowRunner);
|
|
multiMainSetup = mockInstance(MultiMainSetup);
|
|
mockInstance(Telemetry);
|
|
|
|
workflowService = new WorkflowService(
|
|
mock(),
|
|
mock(),
|
|
Container.get(SharedWorkflowRepository),
|
|
Container.get(WorkflowRepository),
|
|
mock(),
|
|
mock(),
|
|
mock(),
|
|
mock(),
|
|
mock(),
|
|
multiMainSetup,
|
|
mock(),
|
|
mock(),
|
|
mock(),
|
|
activeWorkflowRunner,
|
|
);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await testDb.truncate(['Workflow']);
|
|
jest.restoreAllMocks();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await testDb.terminate();
|
|
});
|
|
|
|
describe('update()', () => {
|
|
test('should remove and re-add to active workflows on `active: true` payload', async () => {
|
|
const owner = await createOwner();
|
|
const workflow = await createWorkflow({ active: true }, owner);
|
|
|
|
const removeSpy = jest.spyOn(activeWorkflowRunner, 'remove');
|
|
const addSpy = jest.spyOn(activeWorkflowRunner, 'add');
|
|
|
|
await workflowService.update(owner, workflow, workflow.id);
|
|
|
|
expect(removeSpy).toHaveBeenCalledTimes(1);
|
|
const [removedWorkflowId] = removeSpy.mock.calls[0];
|
|
expect(removedWorkflowId).toBe(workflow.id);
|
|
|
|
expect(addSpy).toHaveBeenCalledTimes(1);
|
|
const [addedWorkflowId, activationMode] = addSpy.mock.calls[0];
|
|
expect(addedWorkflowId).toBe(workflow.id);
|
|
expect(activationMode).toBe('update');
|
|
});
|
|
|
|
test('should remove from active workflows on `active: false` payload', async () => {
|
|
const owner = await createOwner();
|
|
const workflow = await createWorkflow({ active: true }, owner);
|
|
|
|
const removeSpy = jest.spyOn(activeWorkflowRunner, 'remove');
|
|
const addSpy = jest.spyOn(activeWorkflowRunner, 'add');
|
|
|
|
workflow.active = false;
|
|
await workflowService.update(owner, workflow, workflow.id);
|
|
|
|
expect(removeSpy).toHaveBeenCalledTimes(1);
|
|
const [removedWorkflowId] = removeSpy.mock.calls[0];
|
|
expect(removedWorkflowId).toBe(workflow.id);
|
|
|
|
expect(addSpy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
test('should broadcast active workflow state change if state changed', async () => {
|
|
const owner = await createOwner();
|
|
const workflow = await createWorkflow({ active: true }, owner);
|
|
|
|
const broadcastSpy = jest.spyOn(multiMainSetup, 'broadcastWorkflowActiveStateChanged');
|
|
|
|
workflow.active = false;
|
|
await workflowService.update(owner, workflow, workflow.id);
|
|
|
|
expect(broadcastSpy).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
test('should not broadcast active workflow state change if state did not change', async () => {
|
|
const owner = await createOwner();
|
|
const workflow = await createWorkflow({ active: true }, owner);
|
|
|
|
const broadcastSpy = jest.spyOn(multiMainSetup, 'broadcastWorkflowActiveStateChanged');
|
|
|
|
await workflowService.update(owner, workflow, workflow.id);
|
|
|
|
expect(broadcastSpy).not.toHaveBeenCalled();
|
|
});
|
|
});
|