mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2024-12-28 23:19:46 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix smartmon.sh textfile script (#700)

Browse source 
When there are no SMART compatible devices (Raspberry Pi for example) an
error is returned, but the return code is still 0.

`# scan_smart_devices: glob(3) aborted matching pattern /dev/discs/disc*`

* Remove unused `disks` variable.
* Filter for only valid `/dev` devices.
This commit is contained in:
Ben Kochie 2017-10-18 07:37:47 +02:00 committed by GitHub
parent f3a7022602
commit 1824ac3b9e
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
text_collector_examples/smartmon.sh
View file

@ -7,8 +7,6 @@
# data in them than you'd think. # data in them than you'd think.
# http://arstechnica.com/civis/viewtopic.php?p=22062211 # http://arstechnica.com/civis/viewtopic.php?p=22062211
disks="$(/usr/sbin/smartctl --scan | awk '{print $1 "|" $3}')"
parse_smartctl_attributes_awk="$(cat << 'SMARTCTLAWK' parse_smartctl_attributes_awk="$(cat << 'SMARTCTLAWK'
$1 ~ /^[0-9]+$/ && $2 ~ /^[a-zA-Z0-9_-]+$/ { $1 ~ /^[0-9]+$/ && $2 ~ /^[a-zA-Z0-9_-]+$/ {
gsub(/-/, "_"); gsub(/-/, "_");
@ -136,7 +134,7 @@ if [[ "$(expr "${smartctl_version}" : '\([0-9]*\)\..*')" -lt 6 ]] ; then
exit exit
fi fi
device_list="$(/usr/sbin/smartctl --scan-open | awk '{print $1 "|" $3}')" device_list="$(/usr/sbin/smartctl --scan-open | awk '/^\/dev/{print $1 "|" $3}')"
for device in ${device_list}; do for device in ${device_list}; do
disk="$(echo ${device} | cut -f1 -d'|')" disk="$(echo ${device} | cut -f1 -d'|')"