mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2024-11-13 17:14:23 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix: Add safety check to hwmon read
Some checks failed
golangci-lint / lint (push) Has been cancelled
Details

Browse source 
Avoid panic for accessing slice out of range in hwmon.

Fixes: https://github.com/prometheus/node_exporter/issues/3108

Signed-off-by: Ben Kochie <superq@gmail.com>
This commit is contained in:
Ben Kochie 2024-09-26 00:00:04 +02:00 committed by Johannes 'fish' Ziemke
parent ebf3cbfbb3
commit 1b332edfe8
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
collector/hwmon_linux.go
View file

@ -18,6 +18,7 @@ package collector
import ( import (
"errors" "errors"
"fmt"
"log/slog" "log/slog"
"os" "os"
"path/filepath" "path/filepath"
@ -107,6 +108,9 @@ func sysReadFile(file string) ([]byte, error) {
if err != nil { if err != nil {
return nil, err return nil, err
} }
if n < 0 {
return nil, fmt.Errorf("failed to read file: %q, read returned negative bytes value: %d", file, n)
}
return b[:n], nil return b[:n], nil
} }