mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2024-11-09 23:24:09 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Downgrade CPU counter warnings

Browse source 
We've gathered enough evidence that the CPU counter bug workaround is
working as intended. Downgrade the message from Warning to Debug.

Signed-off-by: Ben Kochie <superq@gmail.com>
This commit is contained in:
Ben Kochie 2020-09-25 08:42:51 +02:00 committed by Johannes 'fish' Ziemke
parent a3aaf63bb1
commit 306a365377
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
collector/cpu_linux.go
View file

@ -314,7 +314,7 @@ func (c *cpuCollector) updateCPUStats(newStats []procfs.CPUStat) {
for i, n := range newStats { for i, n := range newStats {
// If idle jumps backwards, assume we had a hotplug event and reset the stats for this CPU. // If idle jumps backwards, assume we had a hotplug event and reset the stats for this CPU.
if n.Idle < c.cpuStats[i].Idle { if n.Idle < c.cpuStats[i].Idle {
level.Warn(c.logger).Log("msg", "CPU Idle counter jumped backwards, possible hotplug event, resetting CPU stats", "cpu", i, "old_value", c.cpuStats[i].Idle, "new_value", n.Idle) level.Debug(c.logger).Log("msg", "CPU Idle counter jumped backwards, possible hotplug event, resetting CPU stats", "cpu", i, "old_value", c.cpuStats[i].Idle, "new_value", n.Idle)
c.cpuStats[i] = procfs.CPUStat{} c.cpuStats[i] = procfs.CPUStat{}
} }
c.cpuStats[i].Idle = n.Idle c.cpuStats[i].Idle = n.Idle
@ -322,55 +322,55 @@ func (c *cpuCollector) updateCPUStats(newStats []procfs.CPUStat) {
if n.User >= c.cpuStats[i].User { if n.User >= c.cpuStats[i].User {
c.cpuStats[i].User = n.User c.cpuStats[i].User = n.User
} else { } else {
level.Warn(c.logger).Log("msg", "CPU User counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].User, "new_value", n.User) level.Debug(c.logger).Log("msg", "CPU User counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].User, "new_value", n.User)
} }
if n.Nice >= c.cpuStats[i].Nice { if n.Nice >= c.cpuStats[i].Nice {
c.cpuStats[i].Nice = n.Nice c.cpuStats[i].Nice = n.Nice
} else { } else {
level.Warn(c.logger).Log("msg", "CPU Nice counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Nice, "new_value", n.Nice) level.Debug(c.logger).Log("msg", "CPU Nice counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Nice, "new_value", n.Nice)
} }
if n.System >= c.cpuStats[i].System { if n.System >= c.cpuStats[i].System {
c.cpuStats[i].System = n.System c.cpuStats[i].System = n.System
} else { } else {
level.Warn(c.logger).Log("msg", "CPU System counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].System, "new_value", n.System) level.Debug(c.logger).Log("msg", "CPU System counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].System, "new_value", n.System)
} }
if n.Iowait >= c.cpuStats[i].Iowait { if n.Iowait >= c.cpuStats[i].Iowait {
c.cpuStats[i].Iowait = n.Iowait c.cpuStats[i].Iowait = n.Iowait
} else { } else {
level.Warn(c.logger).Log("msg", "CPU Iowait counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Iowait, "new_value", n.Iowait) level.Debug(c.logger).Log("msg", "CPU Iowait counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Iowait, "new_value", n.Iowait)
} }
if n.IRQ >= c.cpuStats[i].IRQ { if n.IRQ >= c.cpuStats[i].IRQ {
c.cpuStats[i].IRQ = n.IRQ c.cpuStats[i].IRQ = n.IRQ
} else { } else {
level.Warn(c.logger).Log("msg", "CPU IRQ counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].IRQ, "new_value", n.IRQ) level.Debug(c.logger).Log("msg", "CPU IRQ counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].IRQ, "new_value", n.IRQ)
} }
if n.SoftIRQ >= c.cpuStats[i].SoftIRQ { if n.SoftIRQ >= c.cpuStats[i].SoftIRQ {
c.cpuStats[i].SoftIRQ = n.SoftIRQ c.cpuStats[i].SoftIRQ = n.SoftIRQ
} else { } else {
level.Warn(c.logger).Log("msg", "CPU SoftIRQ counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].SoftIRQ, "new_value", n.SoftIRQ) level.Debug(c.logger).Log("msg", "CPU SoftIRQ counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].SoftIRQ, "new_value", n.SoftIRQ)
} }
if n.Steal >= c.cpuStats[i].Steal { if n.Steal >= c.cpuStats[i].Steal {
c.cpuStats[i].Steal = n.Steal c.cpuStats[i].Steal = n.Steal
} else { } else {
level.Warn(c.logger).Log("msg", "CPU Steal counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Steal, "new_value", n.Steal) level.Debug(c.logger).Log("msg", "CPU Steal counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Steal, "new_value", n.Steal)
} }
if n.Guest >= c.cpuStats[i].Guest { if n.Guest >= c.cpuStats[i].Guest {
c.cpuStats[i].Guest = n.Guest c.cpuStats[i].Guest = n.Guest
} else { } else {
level.Warn(c.logger).Log("msg", "CPU Guest counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Guest, "new_value", n.Guest) level.Debug(c.logger).Log("msg", "CPU Guest counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].Guest, "new_value", n.Guest)
} }
if n.GuestNice >= c.cpuStats[i].GuestNice { if n.GuestNice >= c.cpuStats[i].GuestNice {
c.cpuStats[i].GuestNice = n.GuestNice c.cpuStats[i].GuestNice = n.GuestNice
} else { } else {
level.Warn(c.logger).Log("msg", "CPU GuestNice counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].GuestNice, "new_value", n.GuestNice) level.Debug(c.logger).Log("msg", "CPU GuestNice counter jumped backwards", "cpu", i, "old_value", c.cpuStats[i].GuestNice, "new_value", n.GuestNice)
} }
} }
} }