mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2025-02-02 08:42:31 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Improvement of comments and panel titles

Browse source 
Signed-off-by: beorn7 <beorn@grafana.com>
This commit is contained in:
beorn7 2019-07-22 14:06:27 +02:00
parent e01d9f9e78
commit 36dc7451c9
2 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
docs/node-mixin/dashboards/use.libsonnet
View file

@ -23,7 +23,8 @@ local g = import 'grafana-builder/grafana.libsonnet';
{ yaxes: g.yaxes({ format: 'percentunit', max: 1 }) }, { yaxes: g.yaxes({ format: 'percentunit', max: 1 }) },
) )
.addPanel( .addPanel(
// TODO: Is this a useful panel? // TODO: Is this a useful panel? At least there should be some explanation how load
// average relates to the "CPU saturation" in the title.
g.panel('CPU Saturation (load1 per CPU)') + g.panel('CPU Saturation (load1 per CPU)') +
g.queryPanel(||| g.queryPanel(|||
( (
@ -58,6 +59,8 @@ local g = import 'grafana-builder/grafana.libsonnet';
g.panel('Disk IO Utilisation') + g.panel('Disk IO Utilisation') +
// Full utilisation would be all disks on each node spending an average of // Full utilisation would be all disks on each node spending an average of
// 1 second per second doing I/O, normalize by metric cardinality for stacked charts. // 1 second per second doing I/O, normalize by metric cardinality for stacked charts.
// TODO: Does the partition by device make sense? Using the most utilized device per
// instance might make more sense.
g.queryPanel(||| g.queryPanel(|||
( (
instance_device:node_disk_io_time_seconds:rate1m{%(nodeExporterSelector)s} instance_device:node_disk_io_time_seconds:rate1m{%(nodeExporterSelector)s}
@ -113,7 +116,7 @@ local g = import 'grafana-builder/grafana.libsonnet';
.addRow( .addRow(
g.row('Storage') g.row('Storage')
.addPanel( .addPanel(
g.panel('Disk Capacity') + g.panel('Disk Space Utilisation') +
g.queryPanel(||| g.queryPanel(|||
( (
sum without (device) ( sum without (device) (
@ -145,6 +148,8 @@ local g = import 'grafana-builder/grafana.libsonnet';
{ yaxes: g.yaxes('percentunit') }, { yaxes: g.yaxes('percentunit') },
) )
.addPanel( .addPanel(
// TODO: Is this a useful panel? At least there should be some explanation how load
// average relates to the "CPU saturation" in the title.
g.panel('CPU Saturation (Load1)') + g.panel('CPU Saturation (Load1)') +
g.queryPanel('instance:node_cpu_saturation_load1:{%(nodeExporterSelector)s, instance="$instance"}' % $._config, 'Saturation') + g.queryPanel('instance:node_cpu_saturation_load1:{%(nodeExporterSelector)s, instance="$instance"}' % $._config, 'Saturation') +
{ yaxes: g.yaxes('percentunit') }, { yaxes: g.yaxes('percentunit') },

8
docs/node-mixin/rules/rules.libsonnet
View file

@ -28,7 +28,7 @@
// This is CPU saturation: 1min avg run queue length / number of CPUs. // This is CPU saturation: 1min avg run queue length / number of CPUs.
// Can go over 1. // Can go over 1.
// TODO: There are situation where a run queue >1/core is just normal and fine. // TODO: There are situation where a run queue >1/core is just normal and fine.
// We need to clarify how to lead this metric and if its usage is helpful at all. // We need to clarify how to read this metric and if its usage is helpful at all.
record: 'instance:node_load1_per_cpu:ratio', record: 'instance:node_load1_per_cpu:ratio',
expr: ||| expr: |||
( (
@ -39,7 +39,7 @@
||| % $._config, ||| % $._config,
}, },
{ {
// Memory utilisation per node, normalized by per-node memory // Memory utilisation (ratio of used memory per instance).
record: 'instance:node_memory_utilisation:ratio', record: 'instance:node_memory_utilisation:ratio',
expr: ||| expr: |||
1 - ( 1 - (
@ -60,14 +60,14 @@
||| % $._config, ||| % $._config,
}, },
{ {
// Disk utilisation (seconds spent, 1 second rate) // Disk utilisation (seconds spent, 1 second rate).
record: 'instance_device:node_disk_io_time_seconds:rate1m', record: 'instance_device:node_disk_io_time_seconds:rate1m',
expr: ||| expr: |||
rate(node_disk_io_time_seconds_total{%(nodeExporterSelector)s, %(diskDeviceSelector)s}[1m]) rate(node_disk_io_time_seconds_total{%(nodeExporterSelector)s, %(diskDeviceSelector)s}[1m])
||| % $._config, ||| % $._config,
}, },
{ {
// Disk saturation (weighted seconds spent, 1 second rate) // Disk saturation (weighted seconds spent, 1 second rate).
record: 'instance_device:node_disk_io_time_weighted_seconds:rate1m', record: 'instance_device:node_disk_io_time_weighted_seconds:rate1m',
expr: ||| expr: |||
rate(node_disk_io_time_weighted_seconds_total{%(nodeExporterSelector)s, %(diskDeviceSelector)s}[1m]) rate(node_disk_io_time_weighted_seconds_total{%(nodeExporterSelector)s, %(diskDeviceSelector)s}[1m])