mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2025-03-05 21:00:12 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

review: Optimize getArpEntriesRTNL via deferring string lookup

Browse source 
Signed-off-by: Emin Umut Gercek <eumutgercek@gmail.com>
This commit is contained in:
Emin Umut Gercek 2025-02-02 18:30:43 +03:00
parent 81e132146d
commit 3ca9f7d482
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
collector/arp_linux.go
View file

@ -89,7 +89,7 @@ func getTotalArpEntries(deviceEntries []procfs.ARPEntry) map[string]uint32 {
return entries return entries
} }
func getArpEntriesRTNL() (map[string]uint32, map[string]map[string]uint32, error) { func getArpEntriesRTNL() (map[string]uint32, map[string]map[uint16]uint32, error) {
conn, err := rtnl.Dial(nil) conn, err := rtnl.Dial(nil)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
@ -105,8 +105,8 @@ func getArpEntriesRTNL() (map[string]uint32, map[string]map[string]uint32, error
// Map of interface name to ARP neighbor count. // Map of interface name to ARP neighbor count.
entries := make(map[string]uint32) entries := make(map[string]uint32)
// Map of map[InterfaceName]map[StateName]int // Map of map[InterfaceName]map[StateCode]CountOfTheState
states := make(map[string]map[string]uint32) states := make(map[string]map[uint16]uint32)
for _, n := range neighbors { for _, n := range neighbors {
// Skip entries which have state NUD_NOARP to conform to output of /proc/net/arp. // Skip entries which have state NUD_NOARP to conform to output of /proc/net/arp.
@ -117,10 +117,10 @@ func getArpEntriesRTNL() (map[string]uint32, map[string]map[string]uint32, error
entries[n.Interface.Name]++ entries[n.Interface.Name]++
if _, ok := states[n.Interface.Name]; !ok { if _, ok := states[n.Interface.Name]; !ok {
states[n.Interface.Name] = make(map[string]uint32) states[n.Interface.Name] = make(map[uint16]uint32)
} }
states[n.Interface.Name][neighborStatesMap[n.State]]++ states[n.Interface.Name][n.State]++
} }
return entries, states, nil return entries, states, nil
@ -129,7 +129,7 @@ func getArpEntriesRTNL() (map[string]uint32, map[string]map[string]uint32, error
func (c *arpCollector) Update(ch chan<- prometheus.Metric) error { func (c *arpCollector) Update(ch chan<- prometheus.Metric) error {
var ( var (
enumeratedEntry map[string]uint32 enumeratedEntry map[string]uint32
enumStates map[string]map[string]uint32 enumStates map[string]map[uint16]uint32
) )
if *arpNetlink { if *arpNetlink {
@ -158,7 +158,7 @@ func (c *arpCollector) Update(ch chan<- prometheus.Metric) error {
if *arpNetlink { if *arpNetlink {
for state, count := range enumStates[device] { for state, count := range enumStates[device] {
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
c.states, prometheus.GaugeValue, float64(count), device, state) c.states, prometheus.GaugeValue, float64(count), device, neighborStatesMap[state])
} }
} }
} }