mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2024-09-19 23:57:30 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

collector: fix golint problems in ZFS collector (#1132)

Browse source 
Signed-off-by: Matt Layher <mdlayher@gmail.com>
This commit is contained in:
Matt Layher 2018-10-27 03:18:33 -04:00 committed by Ben Kochie
parent 7519967619
commit 3d798aa4a1
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
collector/zfs_linux.go
View file

@ -29,14 +29,14 @@ import (
// constants from https://github.com/zfsonlinux/zfs/blob/master/lib/libspl/include/sys/kstat.h
// kept as strings for comparison thus avoiding conversion to int
const (
KSTAT_DATA_CHAR = "0"
KSTAT_DATA_INT32 = "1"
KSTAT_DATA_UINT32 = "2"
KSTAT_DATA_INT64 = "3"
KSTAT_DATA_UINT64 = "4"
KSTAT_DATA_LONG = "5"
KSTAT_DATA_ULONG = "6"
KSTAT_DATA_STRING = "7"
kstatDataChar = "0"
kstatDataInt32 = "1"
kstatDataUint32 = "2"
kstatDataInt64 = "3"
kstatDataUint64 = "4"
kstatDataLong = "5"
kstatDataUlong = "6"
kstatDataString = "7"
)
func (c *zfsCollector) openProcFile(path string) (*os.File, error) {
@ -112,7 +112,7 @@ func (c *zfsCollector) parseProcfsFile(reader io.Reader, fmtExt string, handler
// kstat data type (column 2) should be KSTAT_DATA_UINT64, otherwise ignore
// TODO: when other KSTAT_DATA_* types arrive, much of this will need to be restructured
if parts[1] == KSTAT_DATA_UINT64 {
if parts[1] == kstatDataUint64 {
key := fmt.Sprintf("kstat.zfs.misc.%s.%s", fmtExt, parts[0])
value, err := strconv.ParseUint(parts[2], 10, 64)
if err != nil {