mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2025-02-02 08:42:31 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Wrap accesses of c.osFilename and c.osMtime in

Browse source 
mutex to prevent race condition.

Signed-off-by: Robin Nabel <rnabel@ucdavis.edu>
This commit is contained in:
Robin Nabel 2022-08-28 10:24:33 +01:00 committed by Johannes 'fish' Ziemke
parent 4ad86b349b
commit 8755e852fa
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
collector/os_release.go
View file

@ -59,7 +59,7 @@ type osReleaseCollector struct {
os *osRelease os *osRelease
osFilename string // file name of cached release information osFilename string // file name of cached release information
osMtime time.Time // mtime of cached release file osMtime time.Time // mtime of cached release file
osMutex sync.Mutex osMutex sync.RWMutex
osReleaseFilenames []string // all os-release file names to check osReleaseFilenames []string // all os-release file names to check
version float64 version float64
versionDesc *prometheus.Desc versionDesc *prometheus.Desc
@ -120,7 +120,10 @@ func (c *osReleaseCollector) UpdateStruct(path string) error {
} }
t := stat.ModTime() t := stat.ModTime()
if path == c.osFilename && t == c.osMtime { c.osMutex.RLock()
upToDate := path == c.osFilename && t == c.osMtime
c.osMutex.RUnlock()
if upToDate {
// osReleaseCollector struct is already up-to-date. // osReleaseCollector struct is already up-to-date.
return nil return nil
} }