mudhorn/node_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/node_exporter.git synced 2024-09-20 08:07:31 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Convert BSD meminfo collector to use ConstMetrics

Browse source 
This suffers from the same concurrency bug as the netstat one:
https://github.com/prometheus/node_exporter/issues/280
This commit is contained in:
Julius Volz 2016-08-12 01:41:47 +02:00
parent 1001548e43
commit f0796683fe
1 changed files with 11 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
collector/meminfo_bsd.go
View file

@ -20,7 +20,6 @@ import (
"errors"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/common/log"
)
/*
@ -46,9 +45,7 @@ const (
memInfoSubsystem = "memory"
)
type meminfoCollector struct {
metrics map[string]prometheus.Gauge
}
type meminfoCollector struct{}
func init() {
Factories["meminfo"] = NewMeminfoCollector
@ -57,9 +54,7 @@ func init() {
// Takes a prometheus registry and returns a new Collector exposing
// Memory stats.
func NewMeminfoCollector() (Collector, error) {
return &meminfoCollector{
metrics: map[string]prometheus.Gauge{},
}, nil
return &meminfoCollector{}, nil
}
func (c *meminfoCollector) Update(ch chan<- prometheus.Metric) (err error) {
@ -92,19 +87,16 @@ func (c *meminfoCollector) Update(ch chan<- prometheus.Metric) (err error) {
}
}
log.Debugf("Set node_mem: %#v", pages)
for k, v := range pages {
if _, ok := c.metrics[k]; !ok {
c.metrics[k] = prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: Namespace,
Subsystem: memInfoSubsystem,
Name: k,
Help: k + " from sysctl()",
})
}
// Convert metrics to kB (same as Linux meminfo).
c.metrics[k].Set(float64(v) * float64(size))
c.metrics[k].Collect(ch)
ch <- prometheus.MustNewConstMetric(
prometheus.NewDesc(
prometheus.BuildFQName(Namespace, memInfoSubsystem, k),
k+" from sysctl()",
nil, nil,
),
// Convert metrics to kB (same as Linux meminfo).
prometheus.UntypedValue, float64(v)*float64(size),
)
}
return err
}