fix(install): validate permissions before upgrade

resolves #5318

src/cli/upgrade.go

@@ -86,7 +86,6 @@ func executeUpgrade(latest string) {
 		return
 	}
 
-	fmt.Printf("\n❌ %s\n\n", err)
 	os.Exit(1)
 }
 

src/upgrade/cli.go

@@ -58,7 +58,7 @@ func (m *model) Init() tea.Cmd {
 		go func() {
 			if err := install(m.tag); err != nil {
 				m.error = err
-				program.Quit()
+				program.Send(resultMsg(fmt.Sprintf("❌ upgrade failed: %v", err)))
 				return
 			}
 
@@ -132,11 +132,7 @@ func Run(latest string) error {
 	title = titleStyle.Render(title)
 
 	program = tea.NewProgram(initialModel(latest))
-	resultModel, err := program.Run()
+	resultModel, _ := program.Run()
-
-	if err != nil {
-		return err
-	}
 
 	programModel, OK := resultModel.(*model)
 	if !OK {

src/upgrade/install.go

@@ -2,6 +2,7 @@ package upgrade
 
 import (
 	"bytes"
+	"errors"
 	"fmt"
 	"io"
 	"os"
@@ -16,6 +17,15 @@ func install(tag string) error {
 		return err
 	}
 
+	targetDir := filepath.Dir(executable)
+	fileName := filepath.Base(executable)
+
+	newPath := filepath.Join(targetDir, fmt.Sprintf(".%s.new", fileName))
+	fp, err := os.OpenFile(newPath, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0775)
+	if err != nil {
+		return errors.New("we do not have permissions to update")
+	}
+
 	setState(downloading)
 
 	data, err := downloadAndVerify(tag)
@@ -25,15 +35,6 @@ func install(tag string) error {
 
 	setState(installing)
 
-	targetDir := filepath.Dir(executable)
-	fileName := filepath.Base(executable)
-
-	newPath := filepath.Join(targetDir, fmt.Sprintf(".%s.new", fileName))
-	fp, err := os.OpenFile(newPath, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0775)
-	if err != nil {
-		return err
-	}
-
 	_, err = io.Copy(fp, bytes.NewReader(data))
 	// windows will have a lock when we do not close the file
 	fp.Close()