mudhorn/oh-my-posh
1
0
Fork 0
mirror of https://github.com/JanDeDobbeleer/oh-my-posh.git synced 2024-11-10 13:04:04 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(windows): writable should also look for group membership

Browse source 
resolves #3073
This commit is contained in:
Jan De Dobbeleer 2022-11-24 11:36:02 +01:00 committed by Jan De Dobbeleer
parent 735d171b9f
commit 0d101537e6
1 changed files with 43 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
src/platform/win32_windows.go
View file

@ -209,8 +209,13 @@ const (
type accessMask uint32 type accessMask uint32
func (m accessMask) canWrite() bool { func (m accessMask) canWrite() bool {
allowMask := ^(windows.GENERIC_WRITE | windows.GENERIC_ALL | windows.WRITE_DAC | windows.WRITE_OWNER) allowed := []int{windows.GENERIC_WRITE, windows.WRITE_DAC, windows.WRITE_OWNER}
return m&accessMask(allowMask) != 0 for _, v := range allowed {
if m&accessMask(v) != 0 {
return true
}
}
return false
} }
func (m accessMask) permissions() string { func (m accessMask) permissions() string {
@ -259,17 +264,45 @@ type AccessAllowedAce struct {
SidStart uint32 SidStart uint32
} }
func getCurrentUser() (sid *windows.SID, err error) { func getCurrentUser() (user *tokenUser, err error) {
token := windows.GetCurrentProcessToken() token := windows.GetCurrentProcessToken()
defer token.Close() defer token.Close()
tokenuser, err := token.GetTokenUser() tokenuser, err := token.GetTokenUser()
sid = tokenuser.User.Sid if err != nil {
return return
}
tokenGroups, err := token.GetTokenGroups()
if err != nil {
return
}
user = &tokenUser{
sid: tokenuser.User.Sid,
groups: tokenGroups.AllGroups(),
}
return
}
type tokenUser struct {
sid *windows.SID
groups []windows.SIDAndAttributes
}
func (u *tokenUser) isMemberOf(sid *windows.SID) bool {
if u.sid.Equals(sid) {
return true
}
for _, g := range u.groups {
if g.Sid.Equals(sid) {
return true
}
}
return false
} }
func (env *Shell) isWriteable(folder string) bool { func (env *Shell) isWriteable(folder string) bool {
cu, err := getCurrentUser() cu, err := getCurrentUser()
if err != nil { if err != nil {
// unable to get current user // unable to get current user
env.Error("isWriteable", err) env.Error("isWriteable", err)
@ -303,12 +336,13 @@ func (env *Shell) isWriteable(folder string) bool {
aceSid := (*windows.SID)(unsafe.Pointer(&ace.SidStart)) aceSid := (*windows.SID)(unsafe.Pointer(&ace.SidStart))
env.debugF("isWriteable", func() string { return fmt.Sprintf("ace SID: %s", aceSid.String()) }) if !cu.isMemberOf(aceSid) {
if !aceSid.Equals(cu) && !aceSid.IsWellKnown(windows.WinWorldSid) { env.Debug("isWriteable", "not current user or in group")
env.Debug("isWriteable", "not current user or world")
continue continue
} }
env.Debug("isWriteable", fmt.Sprintf("current user is member of %s", aceSid.String()))
// this gets priority over the other access types // this gets priority over the other access types
if ace.AceType == ACCESS_DENIED_ACE_TYPE { if ace.AceType == ACCESS_DENIED_ACE_TYPE {
env.Debug("isWriteable", "ACCESS_DENIED_ACE_TYPE") env.Debug("isWriteable", "ACCESS_DENIED_ACE_TYPE")
@ -317,9 +351,10 @@ func (env *Shell) isWriteable(folder string) bool {
env.debugF("isWriteable", func() string { return ace.AccessMask.permissions() }) env.debugF("isWriteable", func() string { return ace.AccessMask.permissions() })
if ace.AccessMask.canWrite() { if ace.AccessMask.canWrite() {
env.Debug("isWriteable", "user has write access")
return true return true
} }
} }
env.Debug("isWriteable", "no access control on the folder") env.Debug("isWriteable", "no write access")
return false return false
} }