mudhorn/oh-my-posh
1
0
Fork 0
mirror of https://github.com/JanDeDobbeleer/oh-my-posh.git synced 2025-03-05 20:49:04 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(upgrade): stop spinner correctly

Browse source
This commit is contained in:
Jan De Dobbeleer 2024-07-06 15:06:44 +02:00 committed by Jan De Dobbeleer
parent e9119d4a2d
commit 4c3110f3e5
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/cli/upgrade.go
View file

@ -43,8 +43,7 @@ var upgradeCmd = &cobra.Command{
latest, err := upgrade.Latest(env) latest, err := upgrade.Latest(env)
if err != nil { if err != nil {
fmt.Printf("\n❌ %s\n\n", err) fmt.Printf("\n❌ %s\n\n%s", err, terminal.StopProgress())
terminal.StopProgress()
os.Exit(1) os.Exit(1)
return return
} }
@ -58,27 +57,29 @@ var upgradeCmd = &cobra.Command{
version := fmt.Sprintf("v%s", build.Version) version := fmt.Sprintf("v%s", build.Version)
if version == latest { if version != latest {
if !cfg.DisableNotice { executeUpgrade(latest)
fmt.Print("\n✅ no new version available\n\n")
}
terminal.StopProgress()
return return
} }
executeUpgrade(latest) message := terminal.StopProgress()
if !cfg.DisableNotice {
message += "\n✅ no new version available\n\n"
}
fmt.Print(message)
}, },
} }
func executeUpgrade(latest string) { func executeUpgrade(latest string) {
err := upgrade.Run(latest) err := upgrade.Run(latest)
fmt.Print(terminal.StopProgress())
if err == nil { if err == nil {
return return
} }
fmt.Printf("\n❌ %s\n\n", err) fmt.Printf("\n❌ %s\n\n", err)
terminal.StopProgress()
os.Exit(1) os.Exit(1)
} }