From 6798da704bc1c0804a8b6b7bc569e5470cbfe470 Mon Sep 17 00:00:00 2001 From: Jan De Dobbeleer Date: Wed, 17 Mar 2021 18:34:09 +0100 Subject: [PATCH] chore: remove go-bindata references --- docs/docs/contributing-started.mdx | 50 +++--------------------------- 1 file changed, 5 insertions(+), 45 deletions(-) diff --git a/docs/docs/contributing-started.mdx b/docs/docs/contributing-started.mdx index 7f2cbdc4..923c24a6 100644 --- a/docs/docs/contributing-started.mdx +++ b/docs/docs/contributing-started.mdx @@ -11,58 +11,18 @@ import TabItem from "@theme/TabItem"; ### go -The code base is in [go][go], meaning we need a working go setup before we can do anything else. +The codebase is in [go][go], meaning we need a working go setup before we can do anything else. Have a look at the [go guide][go-started] to get up and running with go in no time! +:::info +Oh my Posh needs at least go 1.16. +::: + ### golangci-lint To make sure we keep on writing quality code, [golang-ci lint][golang-ci-lint] is used to validate the changes. Have a look at the [local installation guide][golang-ci-lint-local] to make sure you can validate this yourself as well. -### go-bindata - -Oh my Posh packs the initialization scipts for the different shells, but go does not ship with the ability to add -files other than go code to your compiled binary. [go-bindata][go-bindata] allows us to add initialization files and -ship them in the source code to easily bootstrap your shell with Oh my Posh. - -There are multiple ways to install go-bindata. - - - - -```bash -brew install go-bindata -``` - - - - -```bash -curl --silent --location --output /usr/local/bin/go-bindata https://github.com/kevinburke/go-bindata/releases/download/v3.11.0/go-bindata-linux-amd64 -chmod 755 /usr/local/bin/go-bindata -``` - - - - -```bash -go get -u github.com/kevinburke/go-bindata/... -``` - -Be careful as executing this inside the Oh my Posh repository will adjust the `go.mod` file with this dependency. -Today, there's no way to install a dependency system wide for go, although that's [in the works][go-global]. -Make sure to remove this before submitting a PR as there's [a check][pr-go-mod] in place to avoid adding unused dependencies. - - - - ## Get the source code The source is hosted on [Github][omp]. When you want to contribute, create a [fork][gh-fork] so you can make changes in