mudhorn/oh-my-posh
1
0
Fork 0
mirror of https://github.com/JanDeDobbeleer/oh-my-posh.git synced 2025-02-02 05:41:10 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor(migrate): delete redundant type conversion

Browse source 
`Property` is a defined type with underlying type of `string`. From the
Go specification [1]:

  "two types are identical if their underlying type literals are
structurally equivalent".

Therefore, we don't need to explicitly convert the string values to
`Property`.

[1]: https://go.dev/ref/spec#Type_identity

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun 2023-10-31 01:19:43 +08:00 committed by Jan De Dobbeleer
parent 0706a5b144
commit 7172ee42f6
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/engine/migrate.go
View file

@ -65,7 +65,7 @@ func (segment *Segment) migrationOne(env platform.Environment) {
segment.migrateIconOverride("stash_count_icon", " \uF692 ")
segment.migrateIconOverride("worktree_count_icon", " \uf1bb ")
segment.migrateIconOverride("status_separator_icon", " |")
if segment.Properties.GetBool(properties.Property("status_colors_enabled"), false) {
if segment.Properties.GetBool("status_colors_enabled", false) {
background := segment.Properties.GetBool(colorBackground, true)
segment.migrateColorOverride("local_changes_color", "{{ if or (.Working.Changed) (.Staging.Changed) }}%s{{ end }}", background)
segment.migrateColorOverride("ahead_and_behind_color", "{{ if and (gt .Ahead 0) (gt .Behind 0) }}%s{{ end }}", background)
@ -87,10 +87,10 @@ func (segment *Segment) migrationOne(env platform.Environment) {
segment.migrateColorOverride("charging_color", `{{ if eq "Charging" .State.String }}%s{{ end }}`, background)
segment.migrateColorOverride("discharging_color", `{{ if eq "Discharging" .State.String }}%s{{ end }}`, background)
stateList := []string{`"Discharging"`}
if segment.Properties.GetBool(properties.Property("display_charging"), true) {
if segment.Properties.GetBool("display_charging", true) {
stateList = append(stateList, `"Charging"`)
}
if segment.Properties.GetBool(properties.Property("display_charged"), true) {
if segment.Properties.GetBool("display_charged", true) {
stateList = append(stateList, `"Full"`)
}
if len(stateList) < 3 {
@ -112,10 +112,10 @@ func (segment *Segment) migrationOne(env platform.Environment) {
segment.migrateIconOverride("ssh_icon", "\ueba9 ")
template := segment.Properties.GetString(segmentTemplate, segment.writer.Template())
template = strings.ReplaceAll(template, ".ComputerName", ".HostName")
if !segment.Properties.GetBool(properties.Property("display_host"), true) {
if !segment.Properties.GetBool("display_host", true) {
template = strings.ReplaceAll(template, "@{{ .HostName }}", "")
}
if !segment.Properties.GetBool(properties.Property("display_user"), true) {
if !segment.Properties.GetBool("display_user", true) {
template = strings.ReplaceAll(template, "@", "")
template = strings.ReplaceAll(template, "{{ .UserName }}", "")
}