mudhorn/oh-my-posh
1
0
Fork 0
mirror of https://github.com/JanDeDobbeleer/oh-my-posh.git synced 2025-03-05 20:49:04 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(node): trim spaces from expected version

Browse source 
resolves #3583
This commit is contained in:
Jan De Dobbeleer 2023-03-13 21:57:56 +01:00 committed by Jan De Dobbeleer
parent 71f81a0b79
commit 8dbdc160db
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/segments/node.go
View file

@ -76,7 +76,8 @@ func (n *Node) matchesVersionFile() (string, bool) {
n.language.version.Patch, n.language.version.Patch,
) )
version := strings.TrimPrefix(fileVersion, "v") version := strings.TrimSpace(fileVersion)
version = strings.TrimPrefix(version, "v")
return version, regex.MatchString(re, fileVersion) return version, regex.MatchString(re, fileVersion)
} }

1
src/segments/node_test.go
View file

@ -24,6 +24,7 @@ func TestNodeMatchesVersionFile(t *testing.T) {
}{ }{
{Case: "no file context", Expected: true, RCVersion: ""}, {Case: "no file context", Expected: true, RCVersion: ""},
{Case: "version match", Expected: true, ExpectedVersion: "1.2.3", RCVersion: "1.2.3"}, {Case: "version match", Expected: true, ExpectedVersion: "1.2.3", RCVersion: "1.2.3"},
{Case: "version match with newline", Expected: true, ExpectedVersion: "1.2.3", RCVersion: "1.2.3\n"},
{Case: "version mismatch", Expected: false, ExpectedVersion: "3.2.1", RCVersion: "3.2.1"}, {Case: "version mismatch", Expected: false, ExpectedVersion: "3.2.1", RCVersion: "3.2.1"},
{Case: "version match in other format", Expected: true, ExpectedVersion: "1.2.3", RCVersion: "v1.2.3"}, {Case: "version match in other format", Expected: true, ExpectedVersion: "1.2.3", RCVersion: "v1.2.3"},
{Case: "version match without patch", Expected: true, ExpectedVersion: "1.2", RCVersion: "1.2"}, {Case: "version match without patch", Expected: true, ExpectedVersion: "1.2", RCVersion: "1.2"},