diff --git a/src/.golangci.yml b/src/.golangci.yml index 82199d05..a6c3afe7 100644 --- a/src/.golangci.yml +++ b/src/.golangci.yml @@ -36,13 +36,11 @@ linters-settings: gocritic: enabled-tags: - diagnostic - - experimental + # - experimental - opinionated - performance - style disabled-tags: - experimental - disabled-checks: - - ifElseChain lll: line-length: 180 diff --git a/src/ansi/ansi_writer.go b/src/ansi/ansi_writer.go index a7f8652c..487253b7 100644 --- a/src/ansi/ansi_writer.go +++ b/src/ansi/ansi_writer.go @@ -428,7 +428,7 @@ func (w *Writer) writeSegmentColors() { return } - if fg.IsTransparent() && len(w.TerminalBackground) != 0 { + if fg.IsTransparent() && len(w.TerminalBackground) != 0 { //nolint: gocritic background := w.getAnsiFromColorString(w.TerminalBackground, false) w.writeEscapedAnsiString(fmt.Sprintf(colorise, background)) w.writeEscapedAnsiString(fmt.Sprintf(colorise, bg.ToForeground())) diff --git a/src/segments/owm_test.go b/src/segments/owm_test.go index fed85fd2..6bc85888 100644 --- a/src/segments/owm_test.go +++ b/src/segments/owm_test.go @@ -86,7 +86,7 @@ func TestOWMSegmentSingle(t *testing.T) { for _, tc := range cases { env := &mock.MockedEnvironment{} var props properties.Map - if tc.Latitude != 0 && tc.Longitude != 0 && tc.Location != "" { + if tc.Latitude != 0 && tc.Longitude != 0 && tc.Location != "" { //nolint: gocritic props = properties.Map{ APIKey: "key", Location: tc.Location, diff --git a/src/segments/ui5tooling_test.go b/src/segments/ui5tooling_test.go index 370b7807..12e05e3a 100644 --- a/src/segments/ui5tooling_test.go +++ b/src/segments/ui5tooling_test.go @@ -105,7 +105,7 @@ func mockFilePresence(tc *testCase, ui5tooling *UI5Tooling, env *mock.MockedEnvi } if match { - if tc.DisplayMode == DisplayModeFiles && tc.WorkingDir == WorkingDirRoot { + if tc.DisplayMode == DisplayModeFiles && tc.WorkingDir == WorkingDirRoot { //nolint: gocritic env.On("HasFiles", f).Return(true) env.On("HasFileInParentDirs", f, uint(4)).Return(false) // mode context, working dir != working dir root diff --git a/src/template/text.go b/src/template/text.go index 45df6060..116e0e9c 100644 --- a/src/template/text.go +++ b/src/template/text.go @@ -158,7 +158,7 @@ func (t *Text) cleanTemplate() { continue } // end of a variable, needs to be appended - if !isKnownVariable(property) { + if !isKnownVariable(property) { //nolint: gocritic result += ".Data" + property } else if strings.HasPrefix(property, ".Segments") && !strings.HasSuffix(property, ".Contains") { // as we can't provide a clean way to access the list