From c80e486e46dd0e8ababc9d6d8919c65d435e484c Mon Sep 17 00:00:00 2001 From: "L. Yeung" Date: Tue, 23 Aug 2022 21:53:32 +0800 Subject: [PATCH] docs(fish): update version requirement to v3.4.0+ --- website/docs/faq.mdx | 5 +++++ website/docs/installation/customize.mdx | 4 ++++ website/docs/installation/prompt.mdx | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/website/docs/faq.mdx b/website/docs/faq.mdx index 84140fca..eca237fc 100644 --- a/website/docs/faq.mdx +++ b/website/docs/faq.mdx @@ -195,6 +195,10 @@ to the top of your `$PROFILE`: $OutputEncoding = [console]::InputEncoding = [console]::OutputEncoding = New-Object System.Text.UTF8Encoding ``` +### Fish: $( ... ) is not supported + +You should update fish to v3.4.0 or higher. Fish supports `$(...)` and `"$(...)"` since v3.4.0, as described in its [changelog][fish-changelog]. + [exclusion]: https://support.microsoft.com/en-us/windows/add-an-exclusion-to-windows-security-811816c0-4dfd-af4a-47e4-c301afe13b26 [arch-terminfo]: https://wiki.archlinux.org/title/Bash/Prompt_customization#Terminfo_escape_sequences [ps-ansi-docs]: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_ansi_terminals?view=powershell-7.2 @@ -211,3 +215,4 @@ $OutputEncoding = [console]::InputEncoding = [console]::OutputEncoding = New-Obj [wt-vim]: https://github.com/microsoft/terminal/issues/3794 [vim-wt]: https://github.com/vim/vim/issues/5092 [utf-8]: https://github.com/PowerShell/PowerShell/issues/7233#issuecomment-640243647 +[fish-changelog]: https://fishshell.com/docs/current/relnotes.html#id1 diff --git a/website/docs/installation/customize.mdx b/website/docs/installation/customize.mdx index 683f68ba..56df45b6 100644 --- a/website/docs/installation/customize.mdx +++ b/website/docs/installation/customize.mdx @@ -122,6 +122,10 @@ exec bash +:::caution +Oh My Posh requires fish v3.4.0 or higher. +::: + ```bash oh-my-posh init fish --config ~/.jandedobbeleer.omp.json | source ``` diff --git a/website/docs/installation/prompt.mdx b/website/docs/installation/prompt.mdx index 0f6197aa..eced5813 100644 --- a/website/docs/installation/prompt.mdx +++ b/website/docs/installation/prompt.mdx @@ -138,7 +138,7 @@ Or, when using `~/.profile`. :::caution -It's advised to be on the latest version of fish. Versions below 3.1.2 have issues displaying the prompt. +Oh My Posh requires fish v3.4.0 or higher. ::: Initialize Oh My Posh in `~/.config/fish/config.fish`: