mudhorn/oh-my-posh
1
0
Fork 0
mirror of https://github.com/JanDeDobbeleer/oh-my-posh.git synced 2025-03-05 20:49:04 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(install): release file lock before return

Browse source
This commit is contained in:
Jan De Dobbeleer 2024-07-09 22:22:32 +02:00 committed by Jan De Dobbeleer
parent b8180b197c
commit d9c2fbb784
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/upgrade/install.go
View file

@ -32,16 +32,14 @@ func install(tag string) error {
return err return err
} }
defer fp.Close()
_, err = io.Copy(fp, bytes.NewReader(data)) _, err = io.Copy(fp, bytes.NewReader(data))
// windows will have a lock when we do not close the file
fp.Close()
if err != nil { if err != nil {
return err return err
} }
// windows will have a lock when we do not close the file
fp.Close()
oldPath := filepath.Join(targetDir, fmt.Sprintf(".%s.old", fileName)) oldPath := filepath.Join(targetDir, fmt.Sprintf(".%s.old", fileName))
_ = os.Remove(oldPath) _ = os.Remove(oldPath)