2015-03-30 09:12:51 -07:00
|
|
|
// Copyright 2015 The Prometheus Authors
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
2020-02-03 08:23:44 -08:00
|
|
|
package parser
|
2015-03-30 09:12:51 -07:00
|
|
|
|
|
|
|
import (
|
2020-02-03 09:00:41 -08:00
|
|
|
"context"
|
2022-06-08 01:47:52 -07:00
|
|
|
"fmt"
|
2015-03-30 09:12:51 -07:00
|
|
|
"time"
|
|
|
|
|
2021-11-08 06:23:17 -08:00
|
|
|
"github.com/prometheus/prometheus/model/labels"
|
2016-12-24 16:40:28 -08:00
|
|
|
"github.com/prometheus/prometheus/storage"
|
2023-09-14 09:57:31 -07:00
|
|
|
|
|
|
|
"github.com/prometheus/prometheus/promql/parser/posrange"
|
2015-03-30 09:12:51 -07:00
|
|
|
)
|
|
|
|
|
|
|
|
// Node is a generic interface for all nodes in an AST.
|
|
|
|
//
|
|
|
|
// Whenever numerous nodes are listed such as in a switch-case statement
|
2020-07-25 01:05:58 -07:00
|
|
|
// or a chain of function definitions (e.g. String(), PromQLExpr(), etc.) convention is
|
2015-03-30 09:12:51 -07:00
|
|
|
// to list them as follows:
|
|
|
|
//
|
2022-09-07 02:30:48 -07:00
|
|
|
// - Statements
|
|
|
|
// - statement types (alphabetical)
|
|
|
|
// - ...
|
|
|
|
// - Expressions
|
|
|
|
// - expression types (alphabetical)
|
|
|
|
// - ...
|
2015-03-30 09:12:51 -07:00
|
|
|
type Node interface {
|
|
|
|
// String representation of the node that returns the given node when parsed
|
|
|
|
// as part of a valid query.
|
|
|
|
String() string
|
2020-01-14 08:12:15 -08:00
|
|
|
|
2022-07-07 05:43:36 -07:00
|
|
|
// Pretty returns the prettified representation of the node.
|
|
|
|
// It uses the level information to determine at which level/depth the current
|
|
|
|
// node is in the AST and uses this to apply indentation.
|
|
|
|
Pretty(level int) string
|
|
|
|
|
2020-01-14 08:12:15 -08:00
|
|
|
// PositionRange returns the position of the AST Node in the query string.
|
2023-09-14 09:57:31 -07:00
|
|
|
PositionRange() posrange.PositionRange
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// Statement is a generic interface for all statements.
|
|
|
|
type Statement interface {
|
|
|
|
Node
|
|
|
|
|
2020-07-25 01:05:58 -07:00
|
|
|
// PromQLStmt ensures that no other type accidentally implements the interface
|
|
|
|
PromQLStmt()
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// EvalStmt holds an expression and information on the range it should
|
|
|
|
// be evaluated on.
|
|
|
|
type EvalStmt struct {
|
|
|
|
Expr Expr // Expression to be evaluated.
|
|
|
|
|
|
|
|
// The time boundaries for the evaluation. If Start equals End an instant
|
|
|
|
// is evaluated.
|
2016-12-23 04:51:59 -08:00
|
|
|
Start, End time.Time
|
2015-03-30 09:12:51 -07:00
|
|
|
// Time between two evaluated instants for the range [Start:End].
|
|
|
|
Interval time.Duration
|
2022-08-02 02:15:39 -07:00
|
|
|
// Lookback delta to use for this evaluation.
|
|
|
|
LookbackDelta time.Duration
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2020-07-25 01:05:58 -07:00
|
|
|
func (*EvalStmt) PromQLStmt() {}
|
2015-03-30 09:12:51 -07:00
|
|
|
|
|
|
|
// Expr is a generic interface for all expression types.
|
|
|
|
type Expr interface {
|
|
|
|
Node
|
|
|
|
|
|
|
|
// Type returns the type the expression evaluates to. It does not perform
|
|
|
|
// in-depth checks as this is done at parsing-time.
|
2016-12-23 04:51:59 -08:00
|
|
|
Type() ValueType
|
2020-07-25 01:05:58 -07:00
|
|
|
// PromQLExpr ensures that no other types accidentally implement the interface.
|
|
|
|
PromQLExpr()
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// Expressions is a list of expression nodes that implements Node.
|
|
|
|
type Expressions []Expr
|
|
|
|
|
2016-12-24 01:42:54 -08:00
|
|
|
// AggregateExpr represents an aggregation operation on a Vector.
|
2015-03-30 09:12:51 -07:00
|
|
|
type AggregateExpr struct {
|
2018-03-08 08:52:44 -08:00
|
|
|
Op ItemType // The used aggregation operation.
|
2017-10-05 05:19:52 -07:00
|
|
|
Expr Expr // The Vector expression over which is aggregated.
|
|
|
|
Param Expr // Parameter used by some aggregators.
|
|
|
|
Grouping []string // The labels by which to group the Vector.
|
|
|
|
Without bool // Whether to drop the given labels rather than keep them.
|
2023-09-14 09:57:31 -07:00
|
|
|
PosRange posrange.PositionRange
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// BinaryExpr represents a binary expression between two child expressions.
|
|
|
|
type BinaryExpr struct {
|
2018-03-08 08:52:44 -08:00
|
|
|
Op ItemType // The operation of the expression.
|
2015-03-30 09:12:51 -07:00
|
|
|
LHS, RHS Expr // The operands on the respective sides of the operator.
|
|
|
|
|
2016-12-24 01:42:54 -08:00
|
|
|
// The matching behavior for the operation if both operands are Vectors.
|
2015-03-30 09:12:51 -07:00
|
|
|
// If they are not this field is nil.
|
|
|
|
VectorMatching *VectorMatching
|
2015-09-02 06:51:44 -07:00
|
|
|
|
|
|
|
// If a comparison operator, return 0/1 rather than filtering.
|
|
|
|
ReturnBool bool
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// Call represents a function call.
|
|
|
|
type Call struct {
|
|
|
|
Func *Function // The function that was called.
|
|
|
|
Args Expressions // Arguments used in the call.
|
2020-01-14 08:12:15 -08:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
PosRange posrange.PositionRange
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2016-12-24 01:42:54 -08:00
|
|
|
// MatrixSelector represents a Matrix selection.
|
2015-03-30 09:12:51 -07:00
|
|
|
type MatrixSelector struct {
|
2020-01-17 07:16:58 -08:00
|
|
|
// It is safe to assume that this is an VectorSelector
|
|
|
|
// if the parser hasn't returned an error.
|
|
|
|
VectorSelector Expr
|
2020-01-10 06:25:41 -08:00
|
|
|
Range time.Duration
|
2020-01-14 08:12:15 -08:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
EndPos posrange.Pos
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2018-12-22 05:47:13 -08:00
|
|
|
// SubqueryExpr represents a subquery.
|
|
|
|
type SubqueryExpr struct {
|
2021-01-20 02:57:39 -08:00
|
|
|
Expr Expr
|
|
|
|
Range time.Duration
|
|
|
|
// OriginalOffset is the actual offset that was set in the query.
|
|
|
|
// This never changes.
|
|
|
|
OriginalOffset time.Duration
|
|
|
|
// Offset is the offset used during the query execution
|
|
|
|
// which is calculated using the original offset, at modifier time,
|
|
|
|
// eval time, and subquery offsets in the AST tree.
|
2021-02-09 08:03:16 -08:00
|
|
|
Offset time.Duration
|
|
|
|
Timestamp *int64
|
|
|
|
StartOrEnd ItemType // Set when @ is used with start() or end()
|
|
|
|
Step time.Duration
|
2020-01-14 08:12:15 -08:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
EndPos posrange.Pos
|
2018-12-22 05:47:13 -08:00
|
|
|
}
|
|
|
|
|
2015-03-30 09:12:51 -07:00
|
|
|
// NumberLiteral represents a number.
|
|
|
|
type NumberLiteral struct {
|
2016-12-23 04:51:59 -08:00
|
|
|
Val float64
|
2020-01-14 08:12:15 -08:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
PosRange posrange.PositionRange
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// ParenExpr wraps an expression so it cannot be disassembled as a consequence
|
2016-02-09 18:47:00 -08:00
|
|
|
// of operator precedence.
|
2015-03-30 09:12:51 -07:00
|
|
|
type ParenExpr struct {
|
2020-01-14 08:12:15 -08:00
|
|
|
Expr Expr
|
2023-09-14 09:57:31 -07:00
|
|
|
PosRange posrange.PositionRange
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// StringLiteral represents a string.
|
|
|
|
type StringLiteral struct {
|
2020-01-14 08:12:15 -08:00
|
|
|
Val string
|
2023-09-14 09:57:31 -07:00
|
|
|
PosRange posrange.PositionRange
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// UnaryExpr represents a unary operation on another expression.
|
2016-12-24 01:44:04 -08:00
|
|
|
// Currently unary operations are only supported for Scalars.
|
2015-03-30 09:12:51 -07:00
|
|
|
type UnaryExpr struct {
|
2018-03-08 08:52:44 -08:00
|
|
|
Op ItemType
|
2015-03-30 09:12:51 -07:00
|
|
|
Expr Expr
|
2020-01-14 08:12:15 -08:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
StartPos posrange.Pos
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2021-01-20 02:57:39 -08:00
|
|
|
// StepInvariantExpr represents a query which evaluates to the same result
|
|
|
|
// irrespective of the evaluation time given the raw samples from TSDB remain unchanged.
|
|
|
|
// Currently this is only used for engine optimisations and the parser does not produce this.
|
|
|
|
type StepInvariantExpr struct {
|
|
|
|
Expr Expr
|
|
|
|
}
|
|
|
|
|
|
|
|
func (e *StepInvariantExpr) String() string { return e.Expr.String() }
|
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *StepInvariantExpr) PositionRange() posrange.PositionRange {
|
|
|
|
return e.Expr.PositionRange()
|
|
|
|
}
|
2021-01-20 02:57:39 -08:00
|
|
|
|
2016-12-24 01:42:54 -08:00
|
|
|
// VectorSelector represents a Vector selection.
|
2015-03-30 09:12:51 -07:00
|
|
|
type VectorSelector struct {
|
2021-01-20 02:57:39 -08:00
|
|
|
Name string
|
|
|
|
// OriginalOffset is the actual offset that was set in the query.
|
|
|
|
// This never changes.
|
|
|
|
OriginalOffset time.Duration
|
|
|
|
// Offset is the offset used during the query execution
|
|
|
|
// which is calculated using the original offset, at modifier time,
|
|
|
|
// eval time, and subquery offsets in the AST tree.
|
2024-06-06 08:17:13 -07:00
|
|
|
Offset time.Duration
|
|
|
|
Timestamp *int64
|
|
|
|
SkipHistogramBuckets bool // Set when decoding native histogram buckets is not needed for query evaluation.
|
|
|
|
StartOrEnd ItemType // Set when @ is used with start() or end()
|
|
|
|
LabelMatchers []*labels.Matcher
|
2015-03-30 09:12:51 -07:00
|
|
|
|
2018-11-30 06:27:12 -08:00
|
|
|
// The unexpanded seriesSet populated at query preparation time.
|
2020-02-03 09:19:54 -08:00
|
|
|
UnexpandedSeriesSet storage.SeriesSet
|
|
|
|
Series []storage.Series
|
2020-01-14 08:12:15 -08:00
|
|
|
|
2024-10-16 05:52:11 -07:00
|
|
|
// BypassEmptyMatcherCheck is true when the VectorSelector isn't required to have at least one matcher matching the empty string.
|
|
|
|
// This is the case when VectorSelector is used to represent the info function's second argument.
|
|
|
|
BypassEmptyMatcherCheck bool
|
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
PosRange posrange.PositionRange
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2020-02-03 09:00:41 -08:00
|
|
|
// TestStmt is an internal helper statement that allows execution
|
|
|
|
// of an arbitrary function during handling. It is used to test the Engine.
|
|
|
|
type TestStmt func(context.Context) error
|
|
|
|
|
2022-07-07 05:43:36 -07:00
|
|
|
func (TestStmt) String() string { return "test statement" }
|
|
|
|
func (TestStmt) PromQLStmt() {}
|
|
|
|
func (t TestStmt) Pretty(int) string { return t.String() }
|
2020-02-03 09:00:41 -08:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (TestStmt) PositionRange() posrange.PositionRange {
|
|
|
|
return posrange.PositionRange{
|
2020-02-03 09:00:41 -08:00
|
|
|
Start: -1,
|
|
|
|
End: -1,
|
|
|
|
}
|
|
|
|
}
|
2016-12-23 04:51:59 -08:00
|
|
|
func (e *AggregateExpr) Type() ValueType { return ValueTypeVector }
|
|
|
|
func (e *Call) Type() ValueType { return e.Func.ReturnType }
|
|
|
|
func (e *MatrixSelector) Type() ValueType { return ValueTypeMatrix }
|
2018-12-22 05:47:13 -08:00
|
|
|
func (e *SubqueryExpr) Type() ValueType { return ValueTypeMatrix }
|
2016-12-23 04:51:59 -08:00
|
|
|
func (e *NumberLiteral) Type() ValueType { return ValueTypeScalar }
|
|
|
|
func (e *ParenExpr) Type() ValueType { return e.Expr.Type() }
|
|
|
|
func (e *StringLiteral) Type() ValueType { return ValueTypeString }
|
|
|
|
func (e *UnaryExpr) Type() ValueType { return e.Expr.Type() }
|
|
|
|
func (e *VectorSelector) Type() ValueType { return ValueTypeVector }
|
|
|
|
func (e *BinaryExpr) Type() ValueType {
|
|
|
|
if e.LHS.Type() == ValueTypeScalar && e.RHS.Type() == ValueTypeScalar {
|
|
|
|
return ValueTypeScalar
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
2016-12-28 00:16:48 -08:00
|
|
|
return ValueTypeVector
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
2021-01-20 02:57:39 -08:00
|
|
|
func (e *StepInvariantExpr) Type() ValueType { return e.Expr.Type() }
|
|
|
|
|
|
|
|
func (*AggregateExpr) PromQLExpr() {}
|
|
|
|
func (*BinaryExpr) PromQLExpr() {}
|
|
|
|
func (*Call) PromQLExpr() {}
|
|
|
|
func (*MatrixSelector) PromQLExpr() {}
|
|
|
|
func (*SubqueryExpr) PromQLExpr() {}
|
|
|
|
func (*NumberLiteral) PromQLExpr() {}
|
|
|
|
func (*ParenExpr) PromQLExpr() {}
|
|
|
|
func (*StringLiteral) PromQLExpr() {}
|
|
|
|
func (*UnaryExpr) PromQLExpr() {}
|
|
|
|
func (*VectorSelector) PromQLExpr() {}
|
|
|
|
func (*StepInvariantExpr) PromQLExpr() {}
|
2015-03-30 09:12:51 -07:00
|
|
|
|
2015-08-24 06:07:27 -07:00
|
|
|
// VectorMatchCardinality describes the cardinality relationship
|
2016-12-24 01:42:54 -08:00
|
|
|
// of two Vectors in a binary operation.
|
2015-03-30 09:12:51 -07:00
|
|
|
type VectorMatchCardinality int
|
|
|
|
|
|
|
|
const (
|
|
|
|
CardOneToOne VectorMatchCardinality = iota
|
|
|
|
CardManyToOne
|
|
|
|
CardOneToMany
|
|
|
|
CardManyToMany
|
|
|
|
)
|
|
|
|
|
|
|
|
func (vmc VectorMatchCardinality) String() string {
|
|
|
|
switch vmc {
|
|
|
|
case CardOneToOne:
|
|
|
|
return "one-to-one"
|
|
|
|
case CardManyToOne:
|
|
|
|
return "many-to-one"
|
|
|
|
case CardOneToMany:
|
|
|
|
return "one-to-many"
|
|
|
|
case CardManyToMany:
|
|
|
|
return "many-to-many"
|
|
|
|
}
|
|
|
|
panic("promql.VectorMatchCardinality.String: unknown match cardinality")
|
|
|
|
}
|
|
|
|
|
2016-12-24 01:42:54 -08:00
|
|
|
// VectorMatching describes how elements from two Vectors in a binary
|
2015-03-30 09:12:51 -07:00
|
|
|
// operation are supposed to be matched.
|
|
|
|
type VectorMatching struct {
|
2016-12-24 01:42:54 -08:00
|
|
|
// The cardinality of the two Vectors.
|
2015-03-30 09:12:51 -07:00
|
|
|
Card VectorMatchCardinality
|
2016-04-26 06:28:36 -07:00
|
|
|
// MatchingLabels contains the labels which define equality of a pair of
|
2016-12-24 01:42:54 -08:00
|
|
|
// elements from the Vectors.
|
2016-12-23 04:51:59 -08:00
|
|
|
MatchingLabels []string
|
2016-06-23 09:23:44 -07:00
|
|
|
// On includes the given label names from matching,
|
|
|
|
// rather than excluding them.
|
|
|
|
On bool
|
2015-03-30 09:12:51 -07:00
|
|
|
// Include contains additional labels that should be included in
|
2016-04-26 06:31:00 -07:00
|
|
|
// the result from the side with the lower cardinality.
|
2016-12-23 04:51:59 -08:00
|
|
|
Include []string
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2015-08-24 06:07:27 -07:00
|
|
|
// Visitor allows visiting a Node and its child nodes. The Visit method is
|
2018-01-09 08:44:23 -08:00
|
|
|
// invoked for each node with the path leading to the node provided additionally.
|
2018-06-07 09:27:34 -07:00
|
|
|
// If the result visitor w is not nil and no error, Walk visits each of the children
|
2018-01-09 08:44:23 -08:00
|
|
|
// of node with the visitor w, followed by a call of w.Visit(nil, nil).
|
2015-03-30 09:12:51 -07:00
|
|
|
type Visitor interface {
|
2018-06-07 09:27:34 -07:00
|
|
|
Visit(node Node, path []Node) (w Visitor, err error)
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// Walk traverses an AST in depth-first order: It starts by calling
|
2018-01-09 08:44:23 -08:00
|
|
|
// v.Visit(node, path); node must not be nil. If the visitor w returned by
|
2018-06-07 09:27:34 -07:00
|
|
|
// v.Visit(node, path) is not nil and the visitor returns no error, Walk is
|
|
|
|
// invoked recursively with visitor w for each of the non-nil children of node,
|
|
|
|
// followed by a call of w.Visit(nil), returning an error
|
2018-01-09 08:44:23 -08:00
|
|
|
// As the tree is descended the path of previous nodes is provided.
|
2018-06-07 09:27:34 -07:00
|
|
|
func Walk(v Visitor, node Node, path []Node) error {
|
|
|
|
var err error
|
|
|
|
if v, err = v.Visit(node, path); v == nil || err != nil {
|
|
|
|
return err
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
2018-01-09 08:44:23 -08:00
|
|
|
path = append(path, node)
|
2015-03-30 09:12:51 -07:00
|
|
|
|
2019-11-25 03:41:59 -08:00
|
|
|
for _, e := range Children(node) {
|
|
|
|
if err := Walk(v, e, path); err != nil {
|
2018-06-07 09:27:34 -07:00
|
|
|
return err
|
|
|
|
}
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2018-06-07 09:27:34 -07:00
|
|
|
_, err = v.Visit(nil, nil)
|
|
|
|
return err
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
2021-03-16 02:47:45 -07:00
|
|
|
func ExtractSelectors(expr Expr) [][]*labels.Matcher {
|
|
|
|
var selectors [][]*labels.Matcher
|
|
|
|
Inspect(expr, func(node Node, _ []Node) error {
|
|
|
|
vs, ok := node.(*VectorSelector)
|
|
|
|
if ok {
|
|
|
|
selectors = append(selectors, vs.LabelMatchers)
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
return selectors
|
|
|
|
}
|
|
|
|
|
2018-06-07 09:27:34 -07:00
|
|
|
type inspector func(Node, []Node) error
|
2015-03-30 09:12:51 -07:00
|
|
|
|
2018-06-07 09:27:34 -07:00
|
|
|
func (f inspector) Visit(node Node, path []Node) (Visitor, error) {
|
2019-01-08 10:26:02 -08:00
|
|
|
if err := f(node, path); err != nil {
|
2018-06-07 09:27:34 -07:00
|
|
|
return nil, err
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
2019-01-08 10:26:02 -08:00
|
|
|
|
|
|
|
return f, nil
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// Inspect traverses an AST in depth-first order: It starts by calling
|
2018-06-07 09:27:34 -07:00
|
|
|
// f(node, path); node must not be nil. If f returns a nil error, Inspect invokes f
|
2015-03-30 09:12:51 -07:00
|
|
|
// for all the non-nil children of node, recursively.
|
2018-06-07 09:27:34 -07:00
|
|
|
func Inspect(node Node, f inspector) {
|
lint: Revamp our linting rules, mostly around doc comments
Several things done here:
- Set `max-issues-per-linter` to 0 so that we actually see all linter
warnings and not just 50 per linter. (As we also set
`max-same-issues` to 0, I assume this was the intention from the
beginning.)
- Stop using the golangci-lint default excludes (by setting
`exclude-use-default: false`. Those are too generous and don't match
our style conventions. (I have re-added some of the excludes
explicitly in this commit. See below.)
- Re-add the `errcheck` exclusion we have used so far via the
defaults.
- Exclude the signature requirement `govet` has for `Seek` methods
because we use non-standard `Seek` methods a lot. (But we keep other
requirements, while the default excludes completely disabled the
check for common method segnatures.)
- Exclude warnings about missing doc comments on exported symbols. (We
used to be pretty adamant about doc comments, but stopped that at
some point in the past. By now, we have about 500 missing doc
comments. We may consider reintroducing this check, but that's
outside of the scope of this commit. The default excludes of
golangci-lint essentially ignore doc comments completely.)
- By stop using the default excludes, we now get warnings back on
malformed doc comments. That's the most impactful change in this
commit. It does not enforce doc comments (again), but _if_ there is
a doc comment, it has to have the recommended form. (Most of the
changes in this commit are fixing this form.)
- Improve wording/spelling of some comments in .golangci.yml, and
remove an outdated comment.
- Leave `package-comments` inactive, but add a TODO asking if we
should change that.
- Add a new sub-linter `comment-spacings` (and fix corresponding
comments), which avoids missing spaces after the leading `//`.
Signed-off-by: beorn7 <beorn@grafana.com>
2024-08-22 04:59:36 -07:00
|
|
|
Walk(f, node, nil) //nolint:errcheck
|
2015-03-30 09:12:51 -07:00
|
|
|
}
|
2019-11-25 03:41:59 -08:00
|
|
|
|
|
|
|
// Children returns a list of all child nodes of a syntax tree node.
|
|
|
|
func Children(node Node) []Node {
|
|
|
|
// For some reasons these switches have significantly better performance than interfaces
|
|
|
|
switch n := node.(type) {
|
|
|
|
case *EvalStmt:
|
|
|
|
return []Node{n.Expr}
|
|
|
|
case Expressions:
|
|
|
|
// golang cannot convert slices of interfaces
|
|
|
|
ret := make([]Node, len(n))
|
|
|
|
for i, e := range n {
|
|
|
|
ret[i] = e
|
|
|
|
}
|
|
|
|
return ret
|
|
|
|
case *AggregateExpr:
|
|
|
|
// While this does not look nice, it should avoid unnecessary allocations
|
|
|
|
// caused by slice resizing
|
2023-04-09 00:08:40 -07:00
|
|
|
switch {
|
|
|
|
case n.Expr == nil && n.Param == nil:
|
2019-11-25 03:41:59 -08:00
|
|
|
return nil
|
2023-04-09 00:08:40 -07:00
|
|
|
case n.Expr == nil:
|
2019-11-25 03:41:59 -08:00
|
|
|
return []Node{n.Param}
|
2023-04-09 00:08:40 -07:00
|
|
|
case n.Param == nil:
|
2019-11-25 03:41:59 -08:00
|
|
|
return []Node{n.Expr}
|
2023-04-09 00:08:40 -07:00
|
|
|
default:
|
2019-11-25 03:41:59 -08:00
|
|
|
return []Node{n.Expr, n.Param}
|
|
|
|
}
|
|
|
|
case *BinaryExpr:
|
|
|
|
return []Node{n.LHS, n.RHS}
|
|
|
|
case *Call:
|
|
|
|
// golang cannot convert slices of interfaces
|
|
|
|
ret := make([]Node, len(n.Args))
|
|
|
|
for i, e := range n.Args {
|
|
|
|
ret[i] = e
|
|
|
|
}
|
|
|
|
return ret
|
|
|
|
case *SubqueryExpr:
|
|
|
|
return []Node{n.Expr}
|
|
|
|
case *ParenExpr:
|
|
|
|
return []Node{n.Expr}
|
|
|
|
case *UnaryExpr:
|
|
|
|
return []Node{n.Expr}
|
2020-01-10 06:25:41 -08:00
|
|
|
case *MatrixSelector:
|
|
|
|
return []Node{n.VectorSelector}
|
2021-01-20 02:57:39 -08:00
|
|
|
case *StepInvariantExpr:
|
|
|
|
return []Node{n.Expr}
|
2020-01-10 06:25:41 -08:00
|
|
|
case *NumberLiteral, *StringLiteral, *VectorSelector:
|
2019-11-25 03:41:59 -08:00
|
|
|
// nothing to do
|
|
|
|
return []Node{}
|
|
|
|
default:
|
2022-06-08 01:47:52 -07:00
|
|
|
panic(fmt.Errorf("promql.Children: unhandled node type %T", node))
|
2019-11-25 03:41:59 -08:00
|
|
|
}
|
|
|
|
}
|
2020-01-14 08:12:15 -08:00
|
|
|
|
|
|
|
// mergeRanges is a helper function to merge the PositionRanges of two Nodes.
|
|
|
|
// Note that the arguments must be in the same order as they
|
|
|
|
// occur in the input string.
|
2023-09-14 09:57:31 -07:00
|
|
|
func mergeRanges(first, last Node) posrange.PositionRange {
|
|
|
|
return posrange.PositionRange{
|
2020-01-14 08:12:15 -08:00
|
|
|
Start: first.PositionRange().Start,
|
|
|
|
End: last.PositionRange().End,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
lint: Revamp our linting rules, mostly around doc comments
Several things done here:
- Set `max-issues-per-linter` to 0 so that we actually see all linter
warnings and not just 50 per linter. (As we also set
`max-same-issues` to 0, I assume this was the intention from the
beginning.)
- Stop using the golangci-lint default excludes (by setting
`exclude-use-default: false`. Those are too generous and don't match
our style conventions. (I have re-added some of the excludes
explicitly in this commit. See below.)
- Re-add the `errcheck` exclusion we have used so far via the
defaults.
- Exclude the signature requirement `govet` has for `Seek` methods
because we use non-standard `Seek` methods a lot. (But we keep other
requirements, while the default excludes completely disabled the
check for common method segnatures.)
- Exclude warnings about missing doc comments on exported symbols. (We
used to be pretty adamant about doc comments, but stopped that at
some point in the past. By now, we have about 500 missing doc
comments. We may consider reintroducing this check, but that's
outside of the scope of this commit. The default excludes of
golangci-lint essentially ignore doc comments completely.)
- By stop using the default excludes, we now get warnings back on
malformed doc comments. That's the most impactful change in this
commit. It does not enforce doc comments (again), but _if_ there is
a doc comment, it has to have the recommended form. (Most of the
changes in this commit are fixing this form.)
- Improve wording/spelling of some comments in .golangci.yml, and
remove an outdated comment.
- Leave `package-comments` inactive, but add a TODO asking if we
should change that.
- Add a new sub-linter `comment-spacings` (and fix corresponding
comments), which avoids missing spaces after the leading `//`.
Signed-off-by: beorn7 <beorn@grafana.com>
2024-08-22 04:59:36 -07:00
|
|
|
// PositionRange implements the Node interface.
|
2020-01-14 08:12:15 -08:00
|
|
|
// This makes it possible to call mergeRanges on them.
|
2023-09-14 09:57:31 -07:00
|
|
|
func (i *Item) PositionRange() posrange.PositionRange {
|
|
|
|
return posrange.PositionRange{
|
2020-01-14 08:12:15 -08:00
|
|
|
Start: i.Pos,
|
2023-09-14 09:57:31 -07:00
|
|
|
End: i.Pos + posrange.Pos(len(i.Val)),
|
2020-01-14 08:12:15 -08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *AggregateExpr) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return e.PosRange
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *BinaryExpr) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return mergeRanges(e.LHS, e.RHS)
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *Call) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return e.PosRange
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *EvalStmt) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return e.Expr.PositionRange()
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e Expressions) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
if len(e) == 0 {
|
|
|
|
// Position undefined.
|
2023-09-14 09:57:31 -07:00
|
|
|
return posrange.PositionRange{
|
2020-01-14 08:12:15 -08:00
|
|
|
Start: -1,
|
|
|
|
End: -1,
|
|
|
|
}
|
|
|
|
}
|
2020-03-23 07:47:11 -07:00
|
|
|
return mergeRanges(e[0], e[len(e)-1])
|
2020-01-14 08:12:15 -08:00
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *MatrixSelector) PositionRange() posrange.PositionRange {
|
|
|
|
return posrange.PositionRange{
|
2020-01-14 08:12:15 -08:00
|
|
|
Start: e.VectorSelector.PositionRange().Start,
|
|
|
|
End: e.EndPos,
|
|
|
|
}
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *SubqueryExpr) PositionRange() posrange.PositionRange {
|
|
|
|
return posrange.PositionRange{
|
2020-01-14 08:12:15 -08:00
|
|
|
Start: e.Expr.PositionRange().Start,
|
|
|
|
End: e.EndPos,
|
|
|
|
}
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *NumberLiteral) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return e.PosRange
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *ParenExpr) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return e.PosRange
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *StringLiteral) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return e.PosRange
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *UnaryExpr) PositionRange() posrange.PositionRange {
|
|
|
|
return posrange.PositionRange{
|
2020-01-14 08:12:15 -08:00
|
|
|
Start: e.StartPos,
|
|
|
|
End: e.Expr.PositionRange().End,
|
|
|
|
}
|
|
|
|
}
|
2021-10-22 01:06:44 -07:00
|
|
|
|
2023-09-14 09:57:31 -07:00
|
|
|
func (e *VectorSelector) PositionRange() posrange.PositionRange {
|
2020-01-14 08:12:15 -08:00
|
|
|
return e.PosRange
|
|
|
|
}
|