mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-13 06:47:28 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix a locking bug.

Browse source 
Change-Id: I183780785991d0b4165ce9186f53eb8201fb3ed5
This commit is contained in:
Bjoern Rabenstein 2014-10-02 16:06:57 +02:00
parent 358f97791d
commit 01dd618a20
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
storage/local/storage.go
View file

@ -115,7 +115,6 @@ func (s *memorySeriesStorage) appendSample(sample *clientmodel.Sample) {
fp := sample.Metric.Fingerprint()
series := s.getOrCreateSeries(fp, sample.Metric)
// TODO: Can we release s.mtx here already?
series.add(fp, &metric.SamplePair{
Value: sample.Value,
Timestamp: sample.Timestamp,
@ -181,7 +180,9 @@ func (s *memorySeriesStorage) preloadChunksForRange(fp clientmodel.Fingerprint,
if err != nil {
return nil, err
}
s.mtx.Lock()
series = s.getOrCreateSeries(fp, metric)
defer s.mtx.Unlock() // Ugh.
}
}
return series.preloadChunksForRange(from, through, s.persistence)