From 050b5fc25721282d3a1f4f41176718e2eb9f2da2 Mon Sep 17 00:00:00 2001
From: Jeanette Tan <jeanette.tan@grafana.com>
Date: Wed, 3 Jul 2024 17:56:48 +0800
Subject: [PATCH] refine test cases according to spec

Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
---
 scrape/scrape_test.go | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/scrape/scrape_test.go b/scrape/scrape_test.go
index de37903fd6..d380bfc348 100644
--- a/scrape/scrape_test.go
+++ b/scrape/scrape_test.go
@@ -3760,27 +3760,27 @@ metric: <
 		} {
 			var expectedClassicHistCount, expectedNativeHistCount int
 			var expectCustomBuckets bool
-			switch {
-			case tc.scrapeClassicHistograms && tc.convertClassicHistograms:
-				expectedClassicHistCount = 1
-				expectedNativeHistCount = 1
-				expectCustomBuckets = true
-			case !tc.scrapeClassicHistograms && tc.convertClassicHistograms:
-				expectedClassicHistCount = 0
-				expectedNativeHistCount = 1
-				expectCustomBuckets = true
-			case tc.scrapeClassicHistograms && !tc.convertClassicHistograms:
-				expectedClassicHistCount = 1
-				expectedNativeHistCount = 0
-			case !tc.scrapeClassicHistograms && !tc.convertClassicHistograms:
-				expectedClassicHistCount = 1 // since these are sent without native histograms
-				expectedNativeHistCount = 0
-			}
 			if metricsText.hasExponential {
 				expectedNativeHistCount = 1
 				expectCustomBuckets = false
-			} else {
-				expectCustomBuckets = true
+				expectedClassicHistCount = 0
+				if metricsText.hasClassic && tc.scrapeClassicHistograms {
+					expectedClassicHistCount = 1
+				}
+			} else if metricsText.hasClassic {
+				switch {
+				case tc.scrapeClassicHistograms && tc.convertClassicHistograms:
+					expectedClassicHistCount = 1
+					expectedNativeHistCount = 1
+					expectCustomBuckets = true
+				case !tc.scrapeClassicHistograms && tc.convertClassicHistograms:
+					expectedClassicHistCount = 0
+					expectedNativeHistCount = 1
+					expectCustomBuckets = true
+				case !tc.convertClassicHistograms:
+					expectedClassicHistCount = 1
+					expectedNativeHistCount = 0
+				}
 			}
 
 			t.Run(fmt.Sprintf("%s with %s", name, metricsTextName), func(t *testing.T) {