mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Automate part of TestMaxQuerySamples (#8314)

Browse source 
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
This commit is contained in:
Ganesh Vernekar 2021-01-04 14:33:36 +05:30 committed by GitHub
parent 83c5fa1ea5
commit 063154eab7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 50 additions and 176 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

226
promql/engine_test.go
View file

@ -555,10 +555,11 @@ load 10s
err = test.Run() err = test.Run()
require.NoError(t, err) require.NoError(t, err)
// These test cases should be touching the limit exactly (hence no exceeding).
// Exceeding the limit will be tested by doing -1 to the MaxSamples.
cases := []struct { cases := []struct {
Query string Query string
MaxSamples int MaxSamples int
Result Result
Start time.Time Start time.Time
End time.Time End time.Time
Interval time.Duration Interval time.Duration
@ -567,209 +568,82 @@ load 10s
{ {
Query: "1", Query: "1",
MaxSamples: 1, MaxSamples: 1,
Result: Result{ Start: time.Unix(1, 0),
nil, }, {
Scalar{V: 1, T: 1000},
nil},
Start: time.Unix(1, 0),
},
{
Query: "1",
MaxSamples: 0,
Result: Result{
ErrTooManySamples(env),
nil,
nil,
},
Start: time.Unix(1, 0),
},
{
Query: "metric",
MaxSamples: 0,
Result: Result{
ErrTooManySamples(env),
nil,
nil,
},
Start: time.Unix(1, 0),
},
{
Query: "metric", Query: "metric",
MaxSamples: 1, MaxSamples: 1,
Result: Result{ Start: time.Unix(1, 0),
nil, }, {
Vector{
Sample{Point: Point{V: 1, T: 1000},
Metric: labels.FromStrings("__name__", "metric")},
},
nil,
},
Start: time.Unix(1, 0),
},
{
Query: "metric[20s]", Query: "metric[20s]",
MaxSamples: 2, MaxSamples: 2,
Result: Result{ Start: time.Unix(10, 0),
nil, }, {
Matrix{Series{
Points: []Point{{V: 1, T: 0}, {V: 2, T: 10000}},
Metric: labels.FromStrings("__name__", "metric")},
},
nil,
},
Start: time.Unix(10, 0),
},
{
Query: "rate(metric[20s])", Query: "rate(metric[20s])",
MaxSamples: 3, MaxSamples: 3,
Result: Result{ Start: time.Unix(10, 0),
nil, }, {
Vector{
Sample{
Point: Point{V: 0.1, T: 10000},
Metric: labels.Labels{},
},
},
nil,
},
Start: time.Unix(10, 0),
},
{
Query: "metric[20s:5s]", Query: "metric[20s:5s]",
MaxSamples: 3, MaxSamples: 3,
Result: Result{ Start: time.Unix(10, 0),
nil,
Matrix{Series{
Points: []Point{{V: 1, T: 0}, {V: 1, T: 5000}, {V: 2, T: 10000}},
Metric: labels.FromStrings("__name__", "metric")},
},
nil,
},
Start: time.Unix(10, 0),
},
{
Query: "metric[20s]",
MaxSamples: 0,
Result: Result{
ErrTooManySamples(env),
nil,
nil,
},
Start: time.Unix(10, 0),
}, },
// Range queries. // Range queries.
{ {
Query: "1", Query: "1",
MaxSamples: 3, MaxSamples: 3,
Result: Result{ Start: time.Unix(0, 0),
nil, End: time.Unix(2, 0),
Matrix{Series{ Interval: time.Second,
Points: []Point{{V: 1, T: 0}, {V: 1, T: 1000}, {V: 1, T: 2000}}, }, {
Metric: labels.FromStrings()},
},
nil,
},
Start: time.Unix(0, 0),
End: time.Unix(2, 0),
Interval: time.Second,
},
{
Query: "1", Query: "1",
MaxSamples: 0, MaxSamples: 3,
Result: Result{ Start: time.Unix(0, 0),
ErrTooManySamples(env), End: time.Unix(2, 0),
nil, Interval: time.Second,
nil, }, {
},
Start: time.Unix(0, 0),
End: time.Unix(2, 0),
Interval: time.Second,
},
{
Query: "metric", Query: "metric",
MaxSamples: 3, MaxSamples: 3,
Result: Result{ Start: time.Unix(0, 0),
nil, End: time.Unix(2, 0),
Matrix{Series{ Interval: time.Second,
Points: []Point{{V: 1, T: 0}, {V: 1, T: 1000}, {V: 1, T: 2000}}, }, {
Metric: labels.FromStrings("__name__", "metric")},
},
nil,
},
Start: time.Unix(0, 0),
End: time.Unix(2, 0),
Interval: time.Second,
},
{
Query: "metric",
MaxSamples: 2,
Result: Result{
ErrTooManySamples(env),
nil,
nil,
},
Start: time.Unix(0, 0),
End: time.Unix(2, 0),
Interval: time.Second,
},
{
Query: "metric", Query: "metric",
MaxSamples: 3, MaxSamples: 3,
Result: Result{ Start: time.Unix(0, 0),
nil, End: time.Unix(10, 0),
Matrix{Series{ Interval: 5 * time.Second,
Points: []Point{{V: 1, T: 0}, {V: 1, T: 5000}, {V: 2, T: 10000}}, }, {
Metric: labels.FromStrings("__name__", "metric")},
},
nil,
},
Start: time.Unix(0, 0),
End: time.Unix(10, 0),
Interval: 5 * time.Second,
},
{
Query: "metric",
MaxSamples: 2,
Result: Result{
ErrTooManySamples(env),
nil,
nil,
},
Start: time.Unix(0, 0),
End: time.Unix(10, 0),
Interval: 5 * time.Second,
},
{
Query: "rate(bigmetric[1s])", Query: "rate(bigmetric[1s])",
MaxSamples: 1, MaxSamples: 1,
Result: Result{ Start: time.Unix(0, 0),
nil, End: time.Unix(10, 0),
Matrix{}, Interval: 5 * time.Second,
nil,
},
Start: time.Unix(0, 0),
End: time.Unix(10, 0),
Interval: 5 * time.Second,
}, },
} }
engine := test.QueryEngine() engine := test.QueryEngine()
for _, c := range cases { for _, c := range cases {
var err error t.Run(c.Query, func(t *testing.T) {
var qry Query var err error
var qry Query
engine.maxSamplesPerQuery = c.MaxSamples engine.maxSamplesPerQuery = c.MaxSamples
if c.Interval == 0 { if c.Interval == 0 {
qry, err = engine.NewInstantQuery(test.Queryable(), c.Query, c.Start) qry, err = engine.NewInstantQuery(test.Queryable(), c.Query, c.Start)
} else { } else {
qry, err = engine.NewRangeQuery(test.Queryable(), c.Query, c.Start, c.End, c.Interval) qry, err = engine.NewRangeQuery(test.Queryable(), c.Query, c.Start, c.End, c.Interval)
} }
require.NoError(t, err) require.NoError(t, err)
res := qry.Exec(test.Context()) // Within limit.
require.Equal(t, c.Result.Err, res.Err) res := qry.Exec(test.Context())
require.Equal(t, c.Result.Value, res.Value, "query %q failed", c.Query) require.NoError(t, res.Err)
// Exceeding limit.
engine.maxSamplesPerQuery = c.MaxSamples - 1
res = qry.Exec(test.Context())
require.Equal(t, ErrTooManySamples(env), res.Err)
})
} }
} }